)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"1362f5b039f5ab05229e69de023dbbc92c14f582","unresolved":false,"context_lines":[{"line_number":11,"context_line":"for PV driver to be connected. It depends on which goes first for"},{"line_number":12,"context_line":"the VBD.unplug and the PV driver being connected to xen."},{"line_number":13,"context_line":"The fix is to retry unplug. If really no PV driver installed in"},{"line_number":14,"context_line":"VM, failed after the attempts."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I6b788ba24aa3e7c061dac06c52570ff3818bc91a"},{"line_number":17,"context_line":"Closes-Bug: #1727134"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f4b6375_87d548e8","line":14,"updated":"2017-10-27 19:08:12.000000000","message":"in the commit message, other than the very common term \"VM\", could you please spell out what the other acronyms mean and then use the acronym after?\n\nFor instance, do this:\n\n The error can be reproduced when unplugging the VM\u0027s virtual block device (VBD) ...\n\nand:\n\n ... for physical volume (PV) driver\n\nor does PV stand for paravirtual?","commit_id":"d188de787b6d43cf0f44d66f1cbe959fa5755d45"},{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"cc5ff911d364e9b5aa4011866a25b3bbeb1136f0","unresolved":false,"context_lines":[{"line_number":11,"context_line":"for PV driver to be connected. It depends on which goes first for"},{"line_number":12,"context_line":"the VBD.unplug and the PV driver being connected to xen."},{"line_number":13,"context_line":"The fix is to retry unplug. If really no PV driver installed in"},{"line_number":14,"context_line":"VM, failed after the attempts."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I6b788ba24aa3e7c061dac06c52570ff3818bc91a"},{"line_number":17,"context_line":"Closes-Bug: #1727134"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f4b6375_d672c249","line":14,"in_reply_to":"3f4b6375_87d548e8","updated":"2017-10-28 09:21:42.000000000","message":"Thanks for your advice. Yes, I should spell out the acronyms for the first usage. I will keep that in mind for future commit.","commit_id":"d188de787b6d43cf0f44d66f1cbe959fa5755d45"}],"nova/virt/xenapi/vm_utils.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"1362f5b039f5ab05229e69de023dbbc92c14f582","unresolved":false,"context_lines":[{"line_number":328,"context_line":"            or"},{"line_number":329,"context_line":"            err \u003d\u003d \u0027INTERNAL_ERROR\u0027"},{"line_number":330,"context_line":"            or"},{"line_number":331,"context_line":"            err \u003d\u003d \u0027VM_MISSING_PV_DRIVERS\u0027)"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"def unplug_vbd(session, vbd_ref, this_vm_ref):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_73bc4a6c","line":331,"updated":"2017-10-27 19:08:12.000000000","message":"The above can be more readable/simple if done like so:\n\n can_retry_errs \u003d (\n     \u0027DEVICE_DETACH_REJECTED\u0027,\n     \u0027INTERNAL_ERROR\u0027,\n     \u0027VM_MISSING_PV_DRIVERS\u0027,\n )\n return err in can_retry_errs","commit_id":"d188de787b6d43cf0f44d66f1cbe959fa5755d45"},{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"cc5ff911d364e9b5aa4011866a25b3bbeb1136f0","unresolved":false,"context_lines":[{"line_number":328,"context_line":"            or"},{"line_number":329,"context_line":"            err \u003d\u003d \u0027INTERNAL_ERROR\u0027"},{"line_number":330,"context_line":"            or"},{"line_number":331,"context_line":"            err \u003d\u003d \u0027VM_MISSING_PV_DRIVERS\u0027)"},{"line_number":332,"context_line":""},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"def unplug_vbd(session, vbd_ref, this_vm_ref):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_96920a4b","line":331,"in_reply_to":"3f4b6375_73bc4a6c","updated":"2017-10-28 09:21:42.000000000","message":"yeah, agreed.","commit_id":"d188de787b6d43cf0f44d66f1cbe959fa5755d45"}]}