)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"7fa0c7d960e5342ca622b325082ac14c4712c11e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Sylvain Bauza \u003csbauza@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-10-25 09:04:38 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VGPU: Account for flavors supporting VGPUs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We previously only accepted flavors having extraspecs only supporting"},{"line_number":10,"context_line":"to call a custom resource class or overriding an existing resource class"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4b6375_5f7881c2","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":42},"updated":"2017-10-25 11:39:29.000000000","message":"This title should change.\n\n\"Accept all standard resource classes in flavor extra specs\"\n\nor similar.","commit_id":"76a87716120875a44d452513f4de6672d4d14676"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"05b65e20cacddb31dd20c743f970f8154d8a0648","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"VGPU: Account for flavors supporting VGPUs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We previously only accepted flavors having extraspecs only supporting"},{"line_number":10,"context_line":"to call a custom resource class or overriding an existing resource class"},{"line_number":11,"context_line":"in the flavor (ie. VCPU, MEMORY_MB and DISK_GB only). Now we would like"},{"line_number":12,"context_line":"to ask for VGPUs but since it\u0027s neither a custom resource class nor a"},{"line_number":13,"context_line":"flavor resource class, we need to make sure we can accept additional"},{"line_number":14,"context_line":"existing resource classes that aren\u0027t in the flavor."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4b6375_447c381e","line":11,"range":{"start_line":9,"start_character":1,"end_line":11,"end_character":13},"updated":"2017-10-25 10:46:58.000000000","message":"I don\u0027t understand this sentence.","commit_id":"76a87716120875a44d452513f4de6672d4d14676"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d9338f668773204000da85d66191d9633203dfd9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"in the flavor (ie. VCPU, MEMORY_MB and DISK_GB only). Now we would like"},{"line_number":12,"context_line":"to ask for VGPUs but since it\u0027s neither a custom resource class nor a"},{"line_number":13,"context_line":"flavor resource class, we need to make sure we can accept additional"},{"line_number":14,"context_line":"existing resource classes that aren\u0027t in the flavor."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Partially Implements: blueprint add-support-for-vgpu"},{"line_number":17,"context_line":"Co-Authored-By: naichuans \u003cnaichuan.sun@citrix.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4b6375_a590834b","line":14,"updated":"2017-10-25 13:59:57.000000000","message":"Ah this clears up for me the reason we need this change. Thanks.","commit_id":"76a87716120875a44d452513f4de6672d4d14676"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"7fa0c7d960e5342ca622b325082ac14c4712c11e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"flavor resource class, we need to make sure we can accept additional"},{"line_number":14,"context_line":"existing resource classes that aren\u0027t in the flavor."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Partially Implements: blueprint add-support-for-vgpu"},{"line_number":17,"context_line":"Co-Authored-By: naichuans \u003cnaichuan.sun@citrix.com\u003e"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I84ea7779b196ec535f4109c5343c8de9056a2b2d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4b6375_1f7e89ae","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":52},"updated":"2017-10-25 11:39:29.000000000","message":"Arguably this partially implements every approved Queens blueprint :)","commit_id":"76a87716120875a44d452513f4de6672d4d14676"}],"nova/scheduler/utils.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d9338f668773204000da85d66191d9633203dfd9","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"def _process_extra_specs(extra_specs, resources):"},{"line_number":87,"context_line":"    \"\"\"Check the flavor\u0027s extra_specs for custom/standard resource information."},{"line_number":88,"context_line":"    These will be a dict that is generated from the flavor; and in the"},{"line_number":89,"context_line":"    flavor, the extra_specs entries will be in the format of either:"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_e5a67bab","line":87,"range":{"start_line":87,"start_character":42,"end_line":87,"end_character":66},"updated":"2017-10-25 13:59:57.000000000","message":"I would change this to \"resource override\"","commit_id":"76a87716120875a44d452513f4de6672d4d14676"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d9338f668773204000da85d66191d9633203dfd9","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                continue"},{"line_number":130,"context_line":"            resources[custom_key] \u003d custom_val"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    # Some standard class like VGPU and VGPU_DISPLAY_HEAD are using"},{"line_number":133,"context_line":"    # flavor.extra_spec for schedule, so deal with all standard resource here"},{"line_number":134,"context_line":"    for std_key in std_keys:"},{"line_number":135,"context_line":"        if std_key not in set(resources).union(fields.ResourceClass.STANDARD):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_457f8f14","line":132,"range":{"start_line":132,"start_character":20,"end_line":132,"end_character":25},"updated":"2017-10-25 13:59:57.000000000","message":"classes","commit_id":"76a87716120875a44d452513f4de6672d4d14676"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d9338f668773204000da85d66191d9633203dfd9","unresolved":false,"context_lines":[{"line_number":130,"context_line":"            resources[custom_key] \u003d custom_val"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    # Some standard class like VGPU and VGPU_DISPLAY_HEAD are using"},{"line_number":133,"context_line":"    # flavor.extra_spec for schedule, so deal with all standard resource here"},{"line_number":134,"context_line":"    for std_key in std_keys:"},{"line_number":135,"context_line":"        if std_key not in set(resources).union(fields.ResourceClass.STANDARD):"},{"line_number":136,"context_line":"            LOG.warning(\"Received an invalid ResourceClass \u0027%(key)s\u0027 in \""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_a5952335","line":133,"updated":"2017-10-25 13:59:57.000000000","message":"This comment should be as clear as the commit message.\n\nSomething like \"allow standard and custom resources to be overridden in the flavor extra_specs\"","commit_id":"76a87716120875a44d452513f4de6672d4d14676"},{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"c11b2a5137b7447dcf252ed5461cf6edbafd90dd","unresolved":false,"context_lines":[{"line_number":130,"context_line":"                continue"},{"line_number":131,"context_line":"            resources[custom_key] \u003d custom_val"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    # Accept all standard resource classes to be overrided whether they exist"},{"line_number":134,"context_line":"    # as flavor fields or not."},{"line_number":135,"context_line":"    for std_key in std_keys:"},{"line_number":136,"context_line":"        if std_key not in set(resources).union(fields.ResourceClass.STANDARD):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_7b06aa1e","line":133,"range":{"start_line":133,"start_character":49,"end_line":133,"end_character":58},"updated":"2017-10-25 14:40:47.000000000","message":"overridden (English is stupid)","commit_id":"ab89ab7808a4973c67bdeabea357e2979a821042"},{"author":{"_account_id":17920,"name":"Jianghua Wang","email":"jianghua.wang@citrix.com","username":"wjhfresh"},"change_message_id":"228b9bb1a7ab7b5f2816bd27f3ed9b587a1728b8","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    # Accept all standard resource classes to be overrided whether they exist"},{"line_number":134,"context_line":"    # as flavor fields or not."},{"line_number":135,"context_line":"    for std_key in std_keys:"},{"line_number":136,"context_line":"        if std_key not in set(resources).union(fields.ResourceClass.STANDARD):"},{"line_number":137,"context_line":"            LOG.warning(\"Received an invalid ResourceClass \u0027%(key)s\u0027 in \""},{"line_number":138,"context_line":"                    \"extra_specs.\", {\"key\": std_key})"},{"line_number":139,"context_line":"            continue"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_6d094294","line":136,"updated":"2017-10-26 02:50:20.000000000","message":"reasonable and good change.","commit_id":"7e5c3fd3bea9eb82a7276c97b4613b6c5cbba186"}]}