)]}'
{"nova/privsep/utils.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"22963af5ec3e98d1c05208e35851d5033e7448e5","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    if not hasattr(os, \u0027O_DIRECT\u0027):"},{"line_number":38,"context_line":"        LOG.debug(\"This python runtime does not support direct I/O\")"},{"line_number":39,"context_line":"        return False"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    file_name \u003d \"%s.%s\" % (\".directio.test\","},{"line_number":42,"context_line":"                           nova_utils.generate_random_string())"},{"line_number":43,"context_line":"    testfile \u003d os.path.join(dirpath, file_name)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_305fff10","line":40,"updated":"2018-12-07 19:10:07.000000000","message":"nit: It would be nice to write the NOTE why here uses random string as the commit message.","commit_id":"26521718bdba3bccbf6270e26b76754c26304658"}],"nova/tests/functional/test_servers.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"bc32637310b75bed1732549a10c8886ede83704d","unresolved":false,"context_lines":[{"line_number":634,"context_line":"        reservation_id \u003d response[\u0027reservation_id\u0027]"},{"line_number":635,"context_line":"        self.assertNotIn(reservation_id, [\u0027\u0027, None])"},{"line_number":636,"context_line":"        # Assert that the reservation_id itself has the expected format"},{"line_number":637,"context_line":"        self.assertRegexpMatches(reservation_id, \u0027r-[0-9a-zA-Z]{8}\u0027)"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":"        # Create 1 more server, which should not return a reservation_id"},{"line_number":640,"context_line":"        server \u003d self._build_minimal_create_server_request()"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_d854ffc8","line":637,"range":{"start_line":637,"start_character":13,"end_line":637,"end_character":32},"updated":"2018-10-23 04:10:21.000000000","message":"assertRegex should be used instead of assertRegexpMatches because assertRegexpMatches is deprecated in python 3.\n\nSee https://docs.python.org/3.6/library/unittest.html#deprecated-aliases and https://review.openstack.org/#/c/611608/ .","commit_id":"05fcc2b1dbb5074151ddaac738488e0cf4ec1750"}]}
