)]}'
{"api-ref/source/parameters.yaml":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5d88f8c86049c7557d77c554a3781a729c3ddcec","unresolved":false,"context_lines":[{"line_number":2370,"context_line":"  min_version: 2.54"},{"line_number":2371,"context_line":"  description: |"},{"line_number":2372,"context_line":"    A free form description of the flavor. Limited to 65535 characters"},{"line_number":2373,"context_line":"    in length."},{"line_number":2374,"context_line":"flavor_description_resp:"},{"line_number":2375,"context_line":"  description: |"},{"line_number":2376,"context_line":"    The description of the flavor."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f485f77_57037c0e","line":2373,"updated":"2017-11-09 11:28:14.000000000","message":"I think both flavor_description and flavor_description_required should have the same description.","commit_id":"276d63646155433f773216d20cf2a13cd39a0334"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"321474a55c0cddccc7afd5c8fd3a92014c96ec0c","unresolved":false,"context_lines":[{"line_number":2370,"context_line":"  min_version: 2.54"},{"line_number":2371,"context_line":"  description: |"},{"line_number":2372,"context_line":"    A free form description of the flavor. Limited to 65535 characters"},{"line_number":2373,"context_line":"    in length."},{"line_number":2374,"context_line":"flavor_description_resp:"},{"line_number":2375,"context_line":"  description: |"},{"line_number":2376,"context_line":"    The description of the flavor."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f485f77_34779ed7","line":2373,"in_reply_to":"1f485f77_0ccca033","updated":"2017-11-13 16:46:05.000000000","message":"\u003e I think this is used in the PUT request as well. Anyhow it is fixed\n \u003e now.\n\nGreat point, you\u0027re exactly correct. :)\n\nhttps://review.openstack.org/#/c/515213/9/api-ref/source/flavors.inc@230","commit_id":"276d63646155433f773216d20cf2a13cd39a0334"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"49f067f37918f67fe9f5be23da3c246a58662f09","unresolved":false,"context_lines":[{"line_number":2370,"context_line":"  min_version: 2.54"},{"line_number":2371,"context_line":"  description: |"},{"line_number":2372,"context_line":"    A free form description of the flavor. Limited to 65535 characters"},{"line_number":2373,"context_line":"    in length."},{"line_number":2374,"context_line":"flavor_description_resp:"},{"line_number":2375,"context_line":"  description: |"},{"line_number":2376,"context_line":"    The description of the flavor."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f485f77_0ccca033","line":2373,"in_reply_to":"1f485f77_2a04fb16","updated":"2017-11-13 13:36:22.000000000","message":"I think this is used in the PUT request as well. Anyhow it is fixed now.","commit_id":"276d63646155433f773216d20cf2a13cd39a0334"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8969fd7322d964bb3106397fb77008f48725dc06","unresolved":false,"context_lines":[{"line_number":2370,"context_line":"  min_version: 2.54"},{"line_number":2371,"context_line":"  description: |"},{"line_number":2372,"context_line":"    A free form description of the flavor. Limited to 65535 characters"},{"line_number":2373,"context_line":"    in length."},{"line_number":2374,"context_line":"flavor_description_resp:"},{"line_number":2375,"context_line":"  description: |"},{"line_number":2376,"context_line":"    The description of the flavor."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"1f485f77_2a04fb16","line":2373,"in_reply_to":"1f485f77_57037c0e","updated":"2017-11-10 23:50:43.000000000","message":"I don\u0027t have \"Only printable characters are allowed.\" in this one since this is returned int the response, and I figured the printable characters restriction only mattered for the request parameter description, but thinking about that the length restriction wouldn\u0027t matter for the response either probably, so I can change these to be the same.","commit_id":"276d63646155433f773216d20cf2a13cd39a0334"}],"nova/api/openstack/compute/flavor_rxtx.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"ee8637994f1d1ce38ce936bca3e985de25f864c2","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @wsgi.extends(action\u003d\u0027update\u0027)"},{"line_number":46,"context_line":"    def update(self, req, id, body, resp_obj):"},{"line_number":47,"context_line":"        return self._show(req, resp_obj)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @wsgi.extends"},{"line_number":50,"context_line":"    def detail(self, req, resp_obj):"}],"source_content_type":"text/x-python","patch_set":13,"id":"1f485f77_46eb47db","line":47,"updated":"2017-11-15 20:49:01.000000000","message":"nit: do we actually need this? If we don\u0027t extend it it just means we don\u0027t show rxtx in the flavor update.","commit_id":"d542e61c72d72dcb43e19665e19776b11a695c9c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5e63705924a69fbf0215111d8ca71bb045bbe346","unresolved":false,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @wsgi.extends(action\u003d\u0027update\u0027)"},{"line_number":46,"context_line":"    def update(self, req, id, body, resp_obj):"},{"line_number":47,"context_line":"        return self._show(req, resp_obj)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    @wsgi.extends"},{"line_number":50,"context_line":"    def detail(self, req, resp_obj):"}],"source_content_type":"text/x-python","patch_set":13,"id":"1f485f77_468d87d1","line":47,"in_reply_to":"1f485f77_46eb47db","updated":"2017-11-15 21:00:28.000000000","message":"The samples fail because they expect rxtx_factor in the PUT response, yeah, and that\u0027s how this gets in there.\n\ngmann is working on collapsing all of this code so this eventually goes away.","commit_id":"d542e61c72d72dcb43e19665e19776b11a695c9c"}],"nova/api/openstack/compute/schemas/flavor_manage.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5d88f8c86049c7557d77c554a3781a729c3ddcec","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    name_with_leading_trailing_spaces)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"# 2.54 adds an optional description field with a max length of 65535 since the"},{"line_number":71,"context_line":"# backing database column is a TEXT column which is 64KiB."},{"line_number":72,"context_line":"flavor_description \u003d {"},{"line_number":73,"context_line":"    \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027], \u0027minLength\u0027: 0, \u0027maxLength\u0027: 65535,"},{"line_number":74,"context_line":"    \u0027pattern\u0027: parameter_types.valid_description_regex,"}],"source_content_type":"text/x-python","patch_set":9,"id":"1f485f77_173f44d7","line":71,"range":{"start_line":70,"start_character":0,"end_line":71,"end_character":58},"updated":"2017-11-09 11:28:14.000000000","message":"First I thought that we have problem with wide unicode chars here but then I saw that the regex only allows the first 65535 unicode charachters.","commit_id":"276d63646155433f773216d20cf2a13cd39a0334"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8969fd7322d964bb3106397fb77008f48725dc06","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    name_with_leading_trailing_spaces)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"# 2.54 adds an optional description field with a max length of 65535 since the"},{"line_number":71,"context_line":"# backing database column is a TEXT column which is 64KiB."},{"line_number":72,"context_line":"flavor_description \u003d {"},{"line_number":73,"context_line":"    \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027], \u0027minLength\u0027: 0, \u0027maxLength\u0027: 65535,"},{"line_number":74,"context_line":"    \u0027pattern\u0027: parameter_types.valid_description_regex,"}],"source_content_type":"text/x-python","patch_set":9,"id":"1f485f77_0dff1902","line":71,"range":{"start_line":70,"start_character":0,"end_line":71,"end_character":58},"in_reply_to":"1f485f77_173f44d7","updated":"2017-11-10 23:50:43.000000000","message":"Yeah, this is similar to how we handle user_data validation too.","commit_id":"276d63646155433f773216d20cf2a13cd39a0334"}],"nova/api/openstack/compute/views/flavors.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"039aeb51a55e8a1bb08c807d7c5ca7b4c22a788c","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    _collection_name \u003d \"flavors\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    # NOTE(mriedem): We don\u0027t return the flavor.description in the basic"},{"line_number":27,"context_line":"    # GET /flavors response regardless of microversion."},{"line_number":28,"context_line":"    def basic(self, request, flavor, include_description\u003dFalse):"},{"line_number":29,"context_line":"        return {"},{"line_number":30,"context_line":"            \"flavor\": {"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_b71b0771","line":27,"range":{"start_line":26,"start_character":4,"end_line":27,"end_character":55},"updated":"2017-10-25 23:38:38.000000000","message":"Is this really what we want? I didn\u0027t consider the GET /flavors API during the spec review.","commit_id":"9399bbbe73291bcf6a6b63fa4a038feac8e811d4"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"514707854110a3a797d77892cd5bc507eea40eb8","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    _collection_name \u003d \"flavors\""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    # NOTE(mriedem): We don\u0027t return the flavor.description in the basic"},{"line_number":27,"context_line":"    # GET /flavors response regardless of microversion."},{"line_number":28,"context_line":"    def basic(self, request, flavor, include_description\u003dFalse):"},{"line_number":29,"context_line":"        return {"},{"line_number":30,"context_line":"            \"flavor\": {"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_aa26b9b9","line":27,"range":{"start_line":26,"start_character":4,"end_line":27,"end_character":55},"updated":"2017-10-28 23:43:26.000000000","message":"I talked to some people and decided to add this, amended the spec too:\n\nhttps://review.openstack.org/#/c/516033/","commit_id":"8fd4434fa1031650938bf5851a23727a9352c0da"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"5d88f8c86049c7557d77c554a3781a729c3ddcec","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        return flavor_dict"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def show(self, request, flavor, include_description\u003dFalse):"},{"line_number":43,"context_line":"        flavor_dict \u003d {"},{"line_number":44,"context_line":"            \"flavor\": {"},{"line_number":45,"context_line":"                \"id\": flavor[\"flavorid\"],"}],"source_content_type":"text/x-python","patch_set":9,"id":"1f485f77_f2add6ea","line":42,"updated":"2017-11-09 11:28:14.000000000","message":"Some of the builder methods decides automatically to include the description field or not (e.g. index, details), but show need to take it as a parameter. Is there any specific reason why show is different? It would be nice to make it consistent.","commit_id":"276d63646155433f773216d20cf2a13cd39a0334"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"49f067f37918f67fe9f5be23da3c246a58662f09","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        return flavor_dict"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def show(self, request, flavor, include_description\u003dFalse):"},{"line_number":43,"context_line":"        flavor_dict \u003d {"},{"line_number":44,"context_line":"            \"flavor\": {"},{"line_number":45,"context_line":"                \"id\": flavor[\"flavorid\"],"}],"source_content_type":"text/x-python","patch_set":9,"id":"1f485f77_acb10c92","line":42,"in_reply_to":"1f485f77_6d0fad2e","updated":"2017-11-13 13:36:22.000000000","message":"Thanks for the explanation. I was just curious. It is OK as is.","commit_id":"276d63646155433f773216d20cf2a13cd39a0334"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8969fd7322d964bb3106397fb77008f48725dc06","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        return flavor_dict"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def show(self, request, flavor, include_description\u003dFalse):"},{"line_number":43,"context_line":"        flavor_dict \u003d {"},{"line_number":44,"context_line":"            \"flavor\": {"},{"line_number":45,"context_line":"                \"id\": flavor[\"flavorid\"],"}],"source_content_type":"text/x-python","patch_set":9,"id":"1f485f77_6d0fad2e","line":42,"in_reply_to":"1f485f77_f2add6ea","updated":"2017-11-10 23:50:43.000000000","message":"index() and detail() are for listing type methods, and eventually call basic() or show(), so just didn\u0027t do the request microversion check in the API handlers for index() and detail(), but for what\u0027s calling basic() and show(), the callers are already doing the version check so they can pass the flag in.\n\nI could change index() and detail() to pass everything through, but then it clutters up the API code that calls those view builder methods. I don\u0027t have a very strong opinion either way.","commit_id":"276d63646155433f773216d20cf2a13cd39a0334"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"ee8637994f1d1ce38ce936bca3e985de25f864c2","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        include_description \u003d api_version_request.is_supported("},{"line_number":68,"context_line":"            request, FLAVOR_DESCRIPTION_MICROVERSION)"},{"line_number":69,"context_line":"        return self._list_view(self.basic, request, flavors, coll_name,"},{"line_number":70,"context_line":"                               include_description\u003dinclude_description)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def detail(self, request, flavors):"},{"line_number":73,"context_line":"        \"\"\"Return the \u0027detail\u0027 view of flavors.\"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"1f485f77_06bf8fb0","line":70,"updated":"2017-11-15 20:49:01.000000000","message":"nit: my preference would have been flattening out this level of logic so it\u0027s not so nested. But this works.","commit_id":"d542e61c72d72dcb43e19665e19776b11a695c9c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5e63705924a69fbf0215111d8ca71bb045bbe346","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        include_description \u003d api_version_request.is_supported("},{"line_number":68,"context_line":"            request, FLAVOR_DESCRIPTION_MICROVERSION)"},{"line_number":69,"context_line":"        return self._list_view(self.basic, request, flavors, coll_name,"},{"line_number":70,"context_line":"                               include_description\u003dinclude_description)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def detail(self, request, flavors):"},{"line_number":73,"context_line":"        \"\"\"Return the \u0027detail\u0027 view of flavors.\"\"\""}],"source_content_type":"text/x-python","patch_set":13,"id":"1f485f77_66a9a322","line":70,"in_reply_to":"1f485f77_06bf8fb0","updated":"2017-11-15 21:00:28.000000000","message":"I know it\u0027s not great, but it\u0027s cheap and easy, and how we handle a similar thing with the servers view builder.","commit_id":"d542e61c72d72dcb43e19665e19776b11a695c9c"}],"nova/policies/flavor_access.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"5136d20eb6ca324a9715ee8cab951a437a02af43","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                \u0027method\u0027: \u0027POST\u0027,"},{"line_number":72,"context_line":"                \u0027path\u0027: \u0027/flavors\u0027"},{"line_number":73,"context_line":"            },"},{"line_number":74,"context_line":"            {"},{"line_number":75,"context_line":"                \u0027method\u0027: \u0027PUT\u0027,"},{"line_number":76,"context_line":"                \u0027path\u0027: \u0027/flavors/{flavor_id}\u0027"},{"line_number":77,"context_line":"            },"},{"line_number":78,"context_line":"        ]),"},{"line_number":79,"context_line":"]"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_cb8d77d4","line":77,"range":{"start_line":74,"start_character":0,"end_line":77,"end_character":14},"updated":"2017-10-29 15:09:54.000000000","message":"i think we can skip adding the policy here as we decided to deprecate other policy for extensions.\n\nthe below one is enough\nhttps://review.openstack.org/#/c/515213/3/nova/policies/flavor_manage.py","commit_id":"8fd4434fa1031650938bf5851a23727a9352c0da"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d015f2ad763e20a59f666ba1925f35ecabc6883b","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                \u0027method\u0027: \u0027POST\u0027,"},{"line_number":72,"context_line":"                \u0027path\u0027: \u0027/flavors\u0027"},{"line_number":73,"context_line":"            },"},{"line_number":74,"context_line":"            {"},{"line_number":75,"context_line":"                \u0027method\u0027: \u0027PUT\u0027,"},{"line_number":76,"context_line":"                \u0027path\u0027: \u0027/flavors/{flavor_id}\u0027"},{"line_number":77,"context_line":"            },"},{"line_number":78,"context_line":"        ]),"},{"line_number":79,"context_line":"]"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_7d84f7b1","line":77,"range":{"start_line":74,"start_character":0,"end_line":77,"end_character":14},"in_reply_to":"3f4b6375_1d7863f6","updated":"2017-10-30 13:11:13.000000000","message":"Oh actually this is just a description, not a new rule, so I\u0027ll leave this until the extension policies are removed.","commit_id":"8fd4434fa1031650938bf5851a23727a9352c0da"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"2d99e55a223c4830fdc3fccf0a48bd83f847fb43","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                \u0027method\u0027: \u0027POST\u0027,"},{"line_number":72,"context_line":"                \u0027path\u0027: \u0027/flavors\u0027"},{"line_number":73,"context_line":"            },"},{"line_number":74,"context_line":"            {"},{"line_number":75,"context_line":"                \u0027method\u0027: \u0027PUT\u0027,"},{"line_number":76,"context_line":"                \u0027path\u0027: \u0027/flavors/{flavor_id}\u0027"},{"line_number":77,"context_line":"            },"},{"line_number":78,"context_line":"        ]),"},{"line_number":79,"context_line":"]"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_108ef32d","line":77,"range":{"start_line":74,"start_character":0,"end_line":77,"end_character":14},"in_reply_to":"3f4b6375_7d84f7b1","updated":"2017-10-31 02:09:07.000000000","message":"you mean you want to have same policy control in PUT response also like GET/POST API ?\n\nbecause this will add a policy control on PUT to add \u0027os-flavor-access:is_public\u0027 in PUT response. \n\nanyways, i ll push policy deprecation patch soon once it is done on oslo side. https://review.openstack.org/#/c/509909/","commit_id":"8fd4434fa1031650938bf5851a23727a9352c0da"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"37c0d2cba3585fc0b263dcac4fbf1d196c2340d3","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                \u0027method\u0027: \u0027POST\u0027,"},{"line_number":72,"context_line":"                \u0027path\u0027: \u0027/flavors\u0027"},{"line_number":73,"context_line":"            },"},{"line_number":74,"context_line":"            {"},{"line_number":75,"context_line":"                \u0027method\u0027: \u0027PUT\u0027,"},{"line_number":76,"context_line":"                \u0027path\u0027: \u0027/flavors/{flavor_id}\u0027"},{"line_number":77,"context_line":"            },"},{"line_number":78,"context_line":"        ]),"},{"line_number":79,"context_line":"]"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_1d7863f6","line":77,"range":{"start_line":74,"start_character":0,"end_line":77,"end_character":14},"in_reply_to":"3f4b6375_cb8d77d4","updated":"2017-10-30 13:03:26.000000000","message":"I\u0027ll remove this.","commit_id":"8fd4434fa1031650938bf5851a23727a9352c0da"}],"nova/tests/unit/api/openstack/compute/test_flavors.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e4c527fefd875a76b1248723e6f9f4b10a46086b","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        minDisk filters can be combined"},{"line_number":471,"context_line":"        \"\"\""},{"line_number":472,"context_line":"        req \u003d self._build_request(\u0027/flavors/detail\u0027"},{"line_number":473,"context_line":"                                      \u0027?minRam\u003d256\u0026minDisk\u003d20\u0027)"},{"line_number":474,"context_line":"        flavor \u003d self.controller.detail(req)"},{"line_number":475,"context_line":"        expected \u003d {"},{"line_number":476,"context_line":"            \"flavors\": ["}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_83533539","line":473,"updated":"2017-10-25 21:27:32.000000000","message":"alignment","commit_id":"73bed623253130e515a20096f9b3288cf63d0ec5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e4c527fefd875a76b1248723e6f9f4b10a46086b","unresolved":false,"context_lines":[{"line_number":501,"context_line":"        self._set_expected_body(expected[\u0027flavors\u0027][0], fakes.FLAVORS[\u00272\u0027])"},{"line_number":502,"context_line":"        self.assertEqual(expected, flavor)"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"    # TODO(mriedem): Add a test for updating a flavor which will fail in 2.1."},{"line_number":505,"context_line":""},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"class FlavorsTestV2_54(FlavorsTestV21):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_233a41e6","line":504,"range":{"start_line":504,"start_character":4,"end_line":504,"end_character":77},"updated":"2017-10-25 21:27:32.000000000","message":"This goes in test_flavor_manage.","commit_id":"73bed623253130e515a20096f9b3288cf63d0ec5"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e4c527fefd875a76b1248723e6f9f4b10a46086b","unresolved":false,"context_lines":[{"line_number":506,"context_line":""},{"line_number":507,"context_line":"class FlavorsTestV2_54(FlavorsTestV21):"},{"line_number":508,"context_line":"    \"\"\"Run the same tests as we would for v2.1 but with a description in"},{"line_number":509,"context_line":"    GET, POST and PUT methods."},{"line_number":510,"context_line":"    \"\"\""},{"line_number":511,"context_line":"    microversion \u003d \u00272.54\u0027"},{"line_number":512,"context_line":"    expect_description \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_a32d11a9","line":509,"range":{"start_line":509,"start_character":9,"end_line":509,"end_character":21},"updated":"2017-10-25 21:27:32.000000000","message":"These are test_flavor_manage.","commit_id":"73bed623253130e515a20096f9b3288cf63d0ec5"}],"nova/tests/unit/api/openstack/compute/test_serversV21.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"fec82496ab696a9dbdf5281805ac74e98b6bd3f9","unresolved":false,"context_lines":[{"line_number":2166,"context_line":"        super(ServersControllerRebuildTestV255, self).setUp()"},{"line_number":2167,"context_line":"        fakes.stub_out_key_pair_funcs(self)"},{"line_number":2168,"context_line":"        self.req.api_version_request \u003d \\"},{"line_number":2169,"context_line":"            api_version_request.APIVersionRequest(\u00272.55\u0027)"},{"line_number":2170,"context_line":""},{"line_number":2171,"context_line":"    def _test_set_key_name_rebuild(self, set_key_name\u003dTrue):"},{"line_number":2172,"context_line":"        key_name \u003d \"key\""}],"source_content_type":"text/x-python","patch_set":12,"id":"1f485f77_95f190d0","line":2169,"updated":"2017-11-14 16:03:57.000000000","message":"I think this is should be kept at 2.54 as that was the version implemented key change during rebuild","commit_id":"6c5e73ad3ad6df5d02e89df3b3f72c9b2c2477e7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d5574a6377ccf91272160eb967854f51f20ec40","unresolved":false,"context_lines":[{"line_number":2166,"context_line":"        super(ServersControllerRebuildTestV255, self).setUp()"},{"line_number":2167,"context_line":"        fakes.stub_out_key_pair_funcs(self)"},{"line_number":2168,"context_line":"        self.req.api_version_request \u003d \\"},{"line_number":2169,"context_line":"            api_version_request.APIVersionRequest(\u00272.55\u0027)"},{"line_number":2170,"context_line":""},{"line_number":2171,"context_line":"    def _test_set_key_name_rebuild(self, set_key_name\u003dTrue):"},{"line_number":2172,"context_line":"        key_name \u003d \"key\""}],"source_content_type":"text/x-python","patch_set":12,"id":"1f485f77_43936250","line":2169,"in_reply_to":"1f485f77_95f190d0","updated":"2017-11-14 17:14:12.000000000","message":"Ah yes, I figured this would happen, I got distracted with the replacements.","commit_id":"6c5e73ad3ad6df5d02e89df3b3f72c9b2c2477e7"}],"releasenotes/notes/flavor-description-02f8b8626da71a25.yaml":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"e4c527fefd875a76b1248723e6f9f4b10a46086b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Microveresion 2.54 adds a ``description`` field to the flavor resource in"},{"line_number":5,"context_line":"    the following APIs:"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"    * ``GET /flavors/detail``"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f4b6375_43209dac","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":17},"updated":"2017-10-25 21:27:32.000000000","message":"Microversion","commit_id":"73bed623253130e515a20096f9b3288cf63d0ec5"}]}