)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"973d6266be29122efc22d0818e40577b05667635","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"GET flavor API accept query param to filter the"},{"line_number":10,"context_line":"flavors."},{"line_number":11,"context_line":"This commit adds json schema to validating the valid"},{"line_number":12,"context_line":"query parameters."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"There is no change in API behaviour and additionalProperty"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ff82abbf_82bf04cf","line":11,"range":{"start_line":11,"start_character":32,"end_line":11,"end_character":52},"updated":"2017-11-22 16:25:08.000000000","message":"validate the","commit_id":"fc627a929c55e9247a162339c997ea8d64eb63fa"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"973d6266be29122efc22d0818e40577b05667635","unresolved":false,"context_lines":[{"line_number":11,"context_line":"This commit adds json schema to validating the valid"},{"line_number":12,"context_line":"query parameters."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"There is no change in API behaviour and additionalProperty"},{"line_number":15,"context_line":"is kept True for backward compatibility."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Partially implements blueprint json-schema-validation-for-query-param"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ff82abbf_42b9fce6","line":14,"range":{"start_line":14,"start_character":40,"end_line":14,"end_character":58},"updated":"2017-11-22 16:25:08.000000000","message":"additionalProperties","commit_id":"fc627a929c55e9247a162339c997ea8d64eb63fa"}],"nova/api/openstack/compute/flavors.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"53bfe29857e06ab37e2a4662accf7f861a61b13d","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        if is_public is None:"},{"line_number":73,"context_line":"            # preserve default value of showing only public flavors"},{"line_number":74,"context_line":"            return True"},{"line_number":75,"context_line":"        elif utils.is_none_string(is_public):"},{"line_number":76,"context_line":"            return None"},{"line_number":77,"context_line":"        else:"},{"line_number":78,"context_line":"            try:"},{"line_number":79,"context_line":"                return strutils.bool_from_string(is_public, strict\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff82abbf_951e0fb9","line":76,"range":{"start_line":75,"start_character":8,"end_line":76,"end_character":23},"updated":"2017-11-27 15:01:57.000000000","message":"This is a strange case, because eventually it\u0027s just ignored in the DB query in nova.objects.Flavor._flavor_get_all_from_db. It was added with change 645c2d3a06bbf8b0854ebcc539ad33dd706866c5 but should have probably been a bug fix in novaclient rather than the API.","commit_id":"82c4005f437c4a35884c312151a3a20b5fcd2cea"}],"nova/api/openstack/compute/schemas/flavors.py":[{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"674d295b2b98c4abb83ef95fbd63b359dac6617f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":18,"context_line":"    \u0027properties\u0027: {"},{"line_number":19,"context_line":"        \u0027limit\u0027: parameter_types.multi_params("},{"line_number":20,"context_line":"             parameter_types.non_negative_integer),"},{"line_number":21,"context_line":"        \u0027marker\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":22,"context_line":"        \u0027is_public\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":23,"context_line":"        \u0027minRam\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f485f77_69890125","line":20,"range":{"start_line":20,"start_character":29,"end_line":20,"end_character":49},"updated":"2017-11-09 09:03:55.000000000","message":"The minRam/minDisk/is_public is multi_params({\u0027type\u0027: \u0027string\u0027}) for backward compatibility, but the special schema of limit is a bit confusing.","commit_id":"fc627a929c55e9247a162339c997ea8d64eb63fa"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"793bc80794bd7f6d1dd3dad4b2dc690805662d08","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":18,"context_line":"    \u0027properties\u0027: {"},{"line_number":19,"context_line":"        \u0027limit\u0027: parameter_types.multi_params("},{"line_number":20,"context_line":"             parameter_types.non_negative_integer),"},{"line_number":21,"context_line":"        \u0027marker\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":22,"context_line":"        \u0027is_public\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":23,"context_line":"        \u0027minRam\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_4b735fb2","line":20,"range":{"start_line":20,"start_character":29,"end_line":20,"end_character":49},"in_reply_to":"1f485f77_379965c3","updated":"2017-11-22 13:45:46.000000000","message":"OK, got it.","commit_id":"fc627a929c55e9247a162339c997ea8d64eb63fa"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3c6aafcf38363646c1cad98472b893b7ab95f0aa","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":18,"context_line":"    \u0027properties\u0027: {"},{"line_number":19,"context_line":"        \u0027limit\u0027: parameter_types.multi_params("},{"line_number":20,"context_line":"             parameter_types.non_negative_integer),"},{"line_number":21,"context_line":"        \u0027marker\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":22,"context_line":"        \u0027is_public\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":23,"context_line":"        \u0027minRam\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f485f77_379965c3","line":20,"range":{"start_line":20,"start_character":29,"end_line":20,"end_character":49},"in_reply_to":"1f485f77_69890125","updated":"2017-11-17 07:19:57.000000000","message":"yea because we have same validation in python code for limit filter - https://github.com/openstack/nova/blob/master/nova/api/openstack/common.py#L189","commit_id":"fc627a929c55e9247a162339c997ea8d64eb63fa"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"674d295b2b98c4abb83ef95fbd63b359dac6617f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    \u0027properties\u0027: {"},{"line_number":19,"context_line":"        \u0027limit\u0027: parameter_types.multi_params("},{"line_number":20,"context_line":"             parameter_types.non_negative_integer),"},{"line_number":21,"context_line":"        \u0027marker\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":22,"context_line":"        \u0027is_public\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":23,"context_line":"        \u0027minRam\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":24,"context_line":"        \u0027minDisk\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":25,"context_line":"        \u0027sort_key\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":26,"context_line":"        \u0027sort_dir\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027})"},{"line_number":27,"context_line":"    },"},{"line_number":28,"context_line":"    # NOTE(gmann): This is kept True to keep backward compatibility."},{"line_number":29,"context_line":"    # As of now Schema validation stripped out the additional parameters and"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f485f77_a9ab7973","line":26,"range":{"start_line":21,"start_character":0,"end_line":26,"end_character":68},"updated":"2017-11-09 09:03:55.000000000","message":"try parameter_types.common_query_param?\n\nI notice that the note on common_query_param: We don\u0027t check actual values of queries on params which are defined as the following common_param.","commit_id":"fc627a929c55e9247a162339c997ea8d64eb63fa"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"3c6aafcf38363646c1cad98472b893b7ab95f0aa","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    \u0027properties\u0027: {"},{"line_number":19,"context_line":"        \u0027limit\u0027: parameter_types.multi_params("},{"line_number":20,"context_line":"             parameter_types.non_negative_integer),"},{"line_number":21,"context_line":"        \u0027marker\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":22,"context_line":"        \u0027is_public\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":23,"context_line":"        \u0027minRam\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":24,"context_line":"        \u0027minDisk\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":25,"context_line":"        \u0027sort_key\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":26,"context_line":"        \u0027sort_dir\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027})"},{"line_number":27,"context_line":"    },"},{"line_number":28,"context_line":"    # NOTE(gmann): This is kept True to keep backward compatibility."},{"line_number":29,"context_line":"    # As of now Schema validation stripped out the additional parameters and"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f485f77_dcdeb6d8","line":26,"range":{"start_line":21,"start_character":0,"end_line":26,"end_character":68},"in_reply_to":"1f485f77_a9ab7973","updated":"2017-11-17 07:19:57.000000000","message":"yea, i used it directly as it is more explicit and easy to read the schema. I am not big fan of wrapper things :).","commit_id":"fc627a929c55e9247a162339c997ea8d64eb63fa"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"793bc80794bd7f6d1dd3dad4b2dc690805662d08","unresolved":false,"context_lines":[{"line_number":18,"context_line":"    \u0027properties\u0027: {"},{"line_number":19,"context_line":"        \u0027limit\u0027: parameter_types.multi_params("},{"line_number":20,"context_line":"             parameter_types.non_negative_integer),"},{"line_number":21,"context_line":"        \u0027marker\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":22,"context_line":"        \u0027is_public\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":23,"context_line":"        \u0027minRam\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":24,"context_line":"        \u0027minDisk\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":25,"context_line":"        \u0027sort_key\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":26,"context_line":"        \u0027sort_dir\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027})"},{"line_number":27,"context_line":"    },"},{"line_number":28,"context_line":"    # NOTE(gmann): This is kept True to keep backward compatibility."},{"line_number":29,"context_line":"    # As of now Schema validation stripped out the additional parameters and"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_ab91cb9b","line":26,"range":{"start_line":21,"start_character":0,"end_line":26,"end_character":68},"in_reply_to":"1f485f77_dcdeb6d8","updated":"2017-11-22 13:45:46.000000000","message":"Yea, I know your all means, It\u0027s okay to me. : )","commit_id":"fc627a929c55e9247a162339c997ea8d64eb63fa"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"dfa034e02a8e916f14caef47ce1c6b9496471bf7","unresolved":false,"context_lines":[{"line_number":20,"context_line":"             parameter_types.non_negative_integer),"},{"line_number":21,"context_line":"        \u0027marker\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":22,"context_line":"        \u0027is_public\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":23,"context_line":"        \u0027minRam\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":24,"context_line":"        \u0027minDisk\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":25,"context_line":"        \u0027sort_key\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":26,"context_line":"        \u0027sort_dir\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027})"},{"line_number":27,"context_line":"    },"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff82abbf_0e68b7b6","line":24,"range":{"start_line":23,"start_character":8,"end_line":24,"end_character":68},"updated":"2017-11-27 07:12:12.000000000","message":"These are defined as integer in API reference.\nNegative integer can be specified currently.\nSo they are defined as \u0027string\u0027 in this file for backward compatibility...","commit_id":"82c4005f437c4a35884c312151a3a20b5fcd2cea"}]}