)]}'
{"nova/conductor/manager.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a67f6095863c97c34b83160fc361e21064e0e0ba","unresolved":false,"context_lines":[{"line_number":532,"context_line":"            flavor \u003d objects.Flavor.get_by_id(context, flavor[\u0027id\u0027])"},{"line_number":533,"context_line":"            filter_properties \u003d dict(filter_properties, instance_type\u003dflavor)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"        # Older computes will not send a request_spec during reschedules, nor"},{"line_number":536,"context_line":"        # will the API send the request_spec if using cells v1, so we need"},{"line_number":537,"context_line":"        # to check and build our own if one is not provided."},{"line_number":538,"context_line":"        if request_spec is None:"},{"line_number":539,"context_line":"            request_spec \u003d scheduler_utils.build_request_spec("},{"line_number":540,"context_line":"                context, image, instances)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f485f77_d8d66ff2","line":537,"range":{"start_line":535,"start_character":7,"end_line":537,"end_character":60},"updated":"2017-11-10 02:41:47.000000000","message":"When can we remove this? Based on the rest of the file, it\u0027s when we bump to 2.0 :) In any case, can you note this in a TODO","commit_id":"951f213e51e9e9f66f8e0f2c1d4f6724323edbb0"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5339af92851c8ffa39d2edfaa95008a4067ab6bb","unresolved":false,"context_lines":[{"line_number":532,"context_line":"            flavor \u003d objects.Flavor.get_by_id(context, flavor[\u0027id\u0027])"},{"line_number":533,"context_line":"            filter_properties \u003d dict(filter_properties, instance_type\u003dflavor)"},{"line_number":534,"context_line":""},{"line_number":535,"context_line":"        # Older computes will not send a request_spec during reschedules, nor"},{"line_number":536,"context_line":"        # will the API send the request_spec if using cells v1, so we need"},{"line_number":537,"context_line":"        # to check and build our own if one is not provided."},{"line_number":538,"context_line":"        if request_spec is None:"},{"line_number":539,"context_line":"            request_spec \u003d scheduler_utils.build_request_spec("},{"line_number":540,"context_line":"                context, image, instances)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f485f77_01048214","line":537,"range":{"start_line":535,"start_character":7,"end_line":537,"end_character":60},"in_reply_to":"1f485f77_d8d66ff2","updated":"2017-11-11 18:41:07.000000000","message":"Well, as of this change so Queens computes would be sending the parameter, so once we no longer support rolling upgrade from Pike computes, so at least Rocky, and when we drop cells v1, which should be Rocky.","commit_id":"951f213e51e9e9f66f8e0f2c1d4f6724323edbb0"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"02b59dc3d23fec2ba89152f71936ffcce50571ff","unresolved":false,"context_lines":[{"line_number":537,"context_line":"        # will the API send the request_spec if using cells v1, so we need"},{"line_number":538,"context_line":"        # to check and build our own if one is not provided."},{"line_number":539,"context_line":"        if request_spec is None:"},{"line_number":540,"context_line":"            request_spec \u003d scheduler_utils.build_request_spec("},{"line_number":541,"context_line":"                image, instances)"},{"line_number":542,"context_line":"        else:"},{"line_number":543,"context_line":"            # TODO(mriedem): This is annoying but to populate the local"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_d7c5d08f","line":540,"range":{"start_line":540,"start_character":43,"end_line":540,"end_character":61},"updated":"2017-11-22 15:55:25.000000000","message":"might be good to rename this method to get_request_spec_dict() or something like that to reduce confusion that what is returned here is a RequestSpec object (which it isn\u0027t...)","commit_id":"d04c9ed2239c9aaf38e5bd9ef57b6ed16a4cebcc"}],"nova/tests/unit/conductor/test_conductor.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"05eacf84cc29fa3788c91a8a06cddc3dab3820de","unresolved":false,"context_lines":[{"line_number":918,"context_line":"        filter_properties \u003d fake_spec.to_legacy_filter_properties_dict()"},{"line_number":919,"context_line":"        request_spec \u003d fake_spec.to_legacy_request_spec_dict()"},{"line_number":920,"context_line":""},{"line_number":921,"context_line":"        host \u003d {\u0027host\u0027: \u0027host1\u0027, \u0027nodename\u0027: \u0027node1\u0027, \u0027limits\u0027: {}}"},{"line_number":922,"context_line":""},{"line_number":923,"context_line":"        # unshelve_instance() is a cast, we need to wait for it to complete"},{"line_number":924,"context_line":"        self.useFixture(cast_as_call.CastAsCall(self))"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf8cb3f7_28e3b635","line":921,"range":{"start_line":921,"start_character":64,"end_line":921,"end_character":66},"updated":"2017-12-21 13:16:56.000000000","message":"latent mistake I gather?","commit_id":"eb889886e2b82a9009a219e4ada0beb641a6fd6d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"616373c64be609c8eb49be596d5618eba77fcb5a","unresolved":false,"context_lines":[{"line_number":918,"context_line":"        filter_properties \u003d fake_spec.to_legacy_filter_properties_dict()"},{"line_number":919,"context_line":"        request_spec \u003d fake_spec.to_legacy_request_spec_dict()"},{"line_number":920,"context_line":""},{"line_number":921,"context_line":"        host \u003d {\u0027host\u0027: \u0027host1\u0027, \u0027nodename\u0027: \u0027node1\u0027, \u0027limits\u0027: {}}"},{"line_number":922,"context_line":""},{"line_number":923,"context_line":"        # unshelve_instance() is a cast, we need to wait for it to complete"},{"line_number":924,"context_line":"        self.useFixture(cast_as_call.CastAsCall(self))"}],"source_content_type":"text/x-python","patch_set":5,"id":"bf8cb3f7_e52650b8","line":921,"range":{"start_line":921,"start_character":64,"end_line":921,"end_character":66},"in_reply_to":"bf8cb3f7_28e3b635","updated":"2017-12-21 17:00:21.000000000","message":"No, the limits returned from the scheduler are a dict, not a list. I had updated a bunch of these in the earlier patch set before Ed had updated a bunch of the same tests for the alternate hosts series. I\u0027m not sure why in this case this test wasn\u0027t updated for alternate hosts to use a Selection object. Probably because _schedule_instances is mocked.","commit_id":"eb889886e2b82a9009a219e4ada0beb641a6fd6d"}]}