)]}'
{"nova/tests/unit/virt/vmwareapi/test_driver_api.py":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"b449985bb7d933e23f7a501823d0a0eea0707988","unresolved":false,"context_lines":[{"line_number":2357,"context_line":"        service \u003d self._create_service(disabled\u003dFalse, host\u003d\u0027fake-mini\u0027)"},{"line_number":2358,"context_line":"        mock_service.return_value \u003d service"},{"line_number":2359,"context_line":""},{"line_number":2360,"context_line":"        fake_stats \u003d {\u0027cpu\u0027: {\u0027vcpus\u0027: 4},"},{"line_number":2361,"context_line":"                      \u0027mem\u0027: {\u0027total\u0027: \u00278194\u0027, \u0027free\u0027: \u00272048\u0027}}"},{"line_number":2362,"context_line":"        with test.nested("},{"line_number":2363,"context_line":"            mock.patch.object(vm_util, \u0027get_stats_from_cluster\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_602d6445","line":2360,"updated":"2017-10-30 18:43:15.000000000","message":"the restructuring of this data structure (to nest vcpus) for a commit that primarily announces itself as a memory related change is a bit confusing","commit_id":"a883b176ad2a2c38be48f06f74206c47444179ff"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"8d7b6622b0a39bae005711b0ecb552089e3672bf","unresolved":false,"context_lines":[{"line_number":2357,"context_line":"        service \u003d self._create_service(disabled\u003dFalse, host\u003d\u0027fake-mini\u0027)"},{"line_number":2358,"context_line":"        mock_service.return_value \u003d service"},{"line_number":2359,"context_line":""},{"line_number":2360,"context_line":"        fake_stats \u003d {\u0027cpu\u0027: {\u0027vcpus\u0027: 4},"},{"line_number":2361,"context_line":"                      \u0027mem\u0027: {\u0027total\u0027: \u00278194\u0027, \u0027free\u0027: \u00272048\u0027}}"},{"line_number":2362,"context_line":"        with test.nested("},{"line_number":2363,"context_line":"            mock.patch.object(vm_util, \u0027get_stats_from_cluster\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_75b192e1","line":2360,"in_reply_to":"3f4b6375_602d6445","updated":"2017-10-31 08:00:50.000000000","message":"OK, I will split this patch in two:\n1. fix the memory stats\n2. expose max_vcpu_per_host and max_mem_per_host","commit_id":"a883b176ad2a2c38be48f06f74206c47444179ff"}],"nova/virt/vmwareapi/vm_util.py":[{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"af21392ddfe23b2f5c395801624a6be85db81f3d","unresolved":false,"context_lines":[{"line_number":1196,"context_line":"    stats \u003d {\u0027cpu\u0027: {\u0027vcpus\u0027: vcpus,"},{"line_number":1197,"context_line":"                     \u0027max_vcpus_per_host\u0027: max_vcpus_per_host},"},{"line_number":1198,"context_line":"             \u0027mem\u0027: {\u0027total\u0027: total_mem_mb,"},{"line_number":1199,"context_line":"                     \u0027free\u0027: total_mem_mb - used_mem_mb,"},{"line_number":1200,"context_line":"                     \u0027max_mem_mb_per_host\u0027: max_mem_mb_per_host}}"},{"line_number":1201,"context_line":"    return stats"},{"line_number":1202,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_8a29cf9c","line":1199,"updated":"2017-10-27 17:02:31.000000000","message":"do we need \"free\" anymore?","commit_id":"a883b176ad2a2c38be48f06f74206c47444179ff"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"c62b098f4f77d5d47f59bda2d28934594b04883e","unresolved":false,"context_lines":[{"line_number":1196,"context_line":"    stats \u003d {\u0027cpu\u0027: {\u0027vcpus\u0027: vcpus,"},{"line_number":1197,"context_line":"                     \u0027max_vcpus_per_host\u0027: max_vcpus_per_host},"},{"line_number":1198,"context_line":"             \u0027mem\u0027: {\u0027total\u0027: total_mem_mb,"},{"line_number":1199,"context_line":"                     \u0027free\u0027: total_mem_mb - used_mem_mb,"},{"line_number":1200,"context_line":"                     \u0027max_mem_mb_per_host\u0027: max_mem_mb_per_host}}"},{"line_number":1201,"context_line":"    return stats"},{"line_number":1202,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_03b7e1da","line":1199,"in_reply_to":"3f4b6375_633c55bf","updated":"2017-10-30 15:34:11.000000000","message":"sure, if you have to make another patch.","commit_id":"a883b176ad2a2c38be48f06f74206c47444179ff"},{"author":{"_account_id":9172,"name":"Radoslav Gerganov","email":"rgerganov@vmware.com","username":"rgerganov"},"change_message_id":"578ca0be644737c20a200591a6109a0b7760716c","unresolved":false,"context_lines":[{"line_number":1196,"context_line":"    stats \u003d {\u0027cpu\u0027: {\u0027vcpus\u0027: vcpus,"},{"line_number":1197,"context_line":"                     \u0027max_vcpus_per_host\u0027: max_vcpus_per_host},"},{"line_number":1198,"context_line":"             \u0027mem\u0027: {\u0027total\u0027: total_mem_mb,"},{"line_number":1199,"context_line":"                     \u0027free\u0027: total_mem_mb - used_mem_mb,"},{"line_number":1200,"context_line":"                     \u0027max_mem_mb_per_host\u0027: max_mem_mb_per_host}}"},{"line_number":1201,"context_line":"    return stats"},{"line_number":1202,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_633c55bf","line":1199,"in_reply_to":"3f4b6375_8a29cf9c","updated":"2017-10-30 15:21:18.000000000","message":"I think no. Do you want me to remove it?","commit_id":"a883b176ad2a2c38be48f06f74206c47444179ff"}]}