)]}'
{"nova/conf/notifications.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0e512862bb5b0df3029b244b93850fbd7083ca0d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        choices\u003d(None, \u0027vm_state\u0027, \u0027vm_and_task_state\u0027),"},{"line_number":33,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":34,"context_line":"        help\u003d\"\"\""},{"line_number":35,"context_line":"If set, send compute.instance.update notifications on instance state"},{"line_number":36,"context_line":"changes."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Please refer to https://wiki.openstack.org/wiki/SystemUsageData for"},{"line_number":39,"context_line":"additional information on notifications."}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_0a5298de","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":8},"updated":"2017-11-07 08:41:40.000000000","message":"Doesn\u0027t this already happen regardless of this config option? It\u0027s just that the old/new state values are the same:\n\nhttps://github.com/openstack/nova/blob/9961a91b0d54e856fcaf590f234e46ff90395904/nova/notifications/base.py#L122\n\nhttps://github.com/openstack/nova/blob/9961a91b0d54e856fcaf590f234e46ff90395904/nova/notifications/base.py#L187-L194\n\nSo it seems this description is a bit off.","commit_id":"4488f09fb6d1dbf2cbc2244a788a181a53c7caa1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c9875618e32bb28a923369c6e9fca45f63374e78","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        choices\u003d(None, \u0027vm_state\u0027, \u0027vm_and_task_state\u0027),"},{"line_number":33,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":34,"context_line":"        help\u003d\"\"\""},{"line_number":35,"context_line":"If set, send compute.instance.update notifications on instance state"},{"line_number":36,"context_line":"changes."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Please refer to https://wiki.openstack.org/wiki/SystemUsageData for"},{"line_number":39,"context_line":"additional information on notifications."}],"source_content_type":"text/x-python","patch_set":3,"id":"1f485f77_4bdfd0d5","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":8},"in_reply_to":"1f485f77_874ca642","updated":"2017-11-15 20:19:42.000000000","message":"Ah yes I missed the obvious part.","commit_id":"4488f09fb6d1dbf2cbc2244a788a181a53c7caa1"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3e1d57ef2d2a4fe2203e345171c5cb84b3b5e4f6","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        choices\u003d(None, \u0027vm_state\u0027, \u0027vm_and_task_state\u0027),"},{"line_number":33,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":34,"context_line":"        help\u003d\"\"\""},{"line_number":35,"context_line":"If set, send compute.instance.update notifications on instance state"},{"line_number":36,"context_line":"changes."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Please refer to https://wiki.openstack.org/wiki/SystemUsageData for"},{"line_number":39,"context_line":"additional information on notifications."}],"source_content_type":"text/x-python","patch_set":3,"id":"1f485f77_874ca642","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":8},"in_reply_to":"3f4b6375_0a5298de","updated":"2017-11-15 15:30:28.000000000","message":"If notify_on_state_change \u003d\u003d None then we return early and don\u0027t send any instance.update notification\n\nhttps://github.com/openstack/nova/blob/9961a91b0d54e856fcaf590f234e46ff90395904/nova/notifications/base.py#L90\nhttps://github.com/openstack/nova/blob/9961a91b0d54e856fcaf590f234e46ff90395904/nova/notifications/base.py#L142\n\nIf it is other than None then you are right the emitted notification only differs in the value of the old/new state fields.","commit_id":"4488f09fb6d1dbf2cbc2244a788a181a53c7caa1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0e512862bb5b0df3029b244b93850fbd7083ca0d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"If set, send compute.instance.update notifications on instance state"},{"line_number":36,"context_line":"changes."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Please refer to https://wiki.openstack.org/wiki/SystemUsageData for"},{"line_number":39,"context_line":"additional information on notifications."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_0a33b8f7","line":38,"range":{"start_line":38,"start_character":16,"end_line":38,"end_character":63},"updated":"2017-11-07 08:41:40.000000000","message":"Do you want to update this too or do it in a follow up? Was thinking it would be good to point at the nova docs on notifications:\n\nhttps://docs.openstack.org/nova/latest/reference/notifications.html","commit_id":"4488f09fb6d1dbf2cbc2244a788a181a53c7caa1"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3e1d57ef2d2a4fe2203e345171c5cb84b3b5e4f6","unresolved":false,"context_lines":[{"line_number":35,"context_line":"If set, send compute.instance.update notifications on instance state"},{"line_number":36,"context_line":"changes."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Please refer to https://wiki.openstack.org/wiki/SystemUsageData for"},{"line_number":39,"context_line":"additional information on notifications."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Possible values:"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f485f77_c725fe5d","line":38,"range":{"start_line":38,"start_character":16,"end_line":38,"end_character":63},"in_reply_to":"3f4b6375_0a33b8f7","updated":"2017-11-15 15:30:28.000000000","message":"It make sense to update it now.\nDone.","commit_id":"4488f09fb6d1dbf2cbc2244a788a181a53c7caa1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0e512862bb5b0df3029b244b93850fbd7083ca0d","unresolved":false,"context_lines":[{"line_number":41,"context_line":"Possible values:"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* None - no notifications"},{"line_number":44,"context_line":"* \"vm_state\" - notifications are sent with VM state information"},{"line_number":45,"context_line":"* \"vm_and_task_state\" - notifications are sent with VM and task state"},{"line_number":46,"context_line":"  information"},{"line_number":47,"context_line":"\"\"\"),"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":3,"id":"3f4b6375_8a57a8ca","line":46,"range":{"start_line":44,"start_character":2,"end_line":46,"end_character":13},"updated":"2017-11-07 08:41:40.000000000","message":"As above, the notification is sent regardless, the only difference this option makes is if we send the old_vm_state and old_task_state from the old instance, otherwise they are the same as the \u0027new\u0027 instance after the update, right?\n\nThis actually seems like a really useless config option, I don\u0027t know why we don\u0027t just always send the old/new information since we already have it and it shows the state transitions.","commit_id":"4488f09fb6d1dbf2cbc2244a788a181a53c7caa1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c9875618e32bb28a923369c6e9fca45f63374e78","unresolved":false,"context_lines":[{"line_number":41,"context_line":"Possible values:"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* None - no notifications"},{"line_number":44,"context_line":"* \"vm_state\" - notifications are sent with VM state information"},{"line_number":45,"context_line":"* \"vm_and_task_state\" - notifications are sent with VM and task state"},{"line_number":46,"context_line":"  information"},{"line_number":47,"context_line":"\"\"\"),"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":3,"id":"1f485f77_2b97f4ee","line":46,"range":{"start_line":44,"start_character":2,"end_line":46,"end_character":13},"in_reply_to":"1f485f77_87fa66ba","updated":"2017-11-15 20:19:42.000000000","message":"Sure. We could poll the ops list first to see if anyone uses vm_state explicitly instead of vm_and_task_state and if so, why since you get the same fields, just wrong data.\n\nBTW, deprecating the option could be weird. What we really want is to make it a BoolOpt, but that gets tricky. Maybe we could deprecate the usage of \"vm_state\" as a choice? And then eventually change it to a BoolOpt? I\u0027m not sure how easy the transition is - changing types always confuses me.","commit_id":"4488f09fb6d1dbf2cbc2244a788a181a53c7caa1"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3e1d57ef2d2a4fe2203e345171c5cb84b3b5e4f6","unresolved":false,"context_lines":[{"line_number":41,"context_line":"Possible values:"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"* None - no notifications"},{"line_number":44,"context_line":"* \"vm_state\" - notifications are sent with VM state information"},{"line_number":45,"context_line":"* \"vm_and_task_state\" - notifications are sent with VM and task state"},{"line_number":46,"context_line":"  information"},{"line_number":47,"context_line":"\"\"\"),"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":3,"id":"1f485f77_87fa66ba","line":46,"range":{"start_line":44,"start_character":2,"end_line":46,"end_character":13},"in_reply_to":"3f4b6375_8a57a8ca","updated":"2017-11-15 15:30:28.000000000","message":"I agree that this seems useless and unnecessary complicated. I can propose a separate patch that deprecates this config option if we agree to remove this.","commit_id":"4488f09fb6d1dbf2cbc2244a788a181a53c7caa1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dd41597bb482d2a0688e37bf6cf41d242318f929","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        choices\u003d(None, \u0027vm_state\u0027, \u0027vm_and_task_state\u0027),"},{"line_number":33,"context_line":"        deprecated_group\u003d\u0027DEFAULT\u0027,"},{"line_number":34,"context_line":"        help\u003d\"\"\""},{"line_number":35,"context_line":"If set to a not None value, send compute.instance.update notifications on"},{"line_number":36,"context_line":"instance state changes."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"Please refer to"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f485f77_0b6af8ec","line":35,"range":{"start_line":35,"start_character":6,"end_line":35,"end_character":26},"updated":"2017-11-15 20:21:59.000000000","message":"This might make it more confusing, and it\u0027s my fault for bringing it up.","commit_id":"1294f76a9fc4f5f32f629c51e1bd32f7cb83e040"}]}