)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"27c29efa2afa634c240cebfb5ed9635c6359fd26","unresolved":false,"context_lines":[{"line_number":3627,"context_line":""},{"line_number":3628,"context_line":"            network_info \u003d self.network_api.get_instance_nw_info(context,"},{"line_number":3629,"context_line":"                                                                 instance)"},{"line_number":3630,"context_line":"            # TODO(mriedem): Get BDMs here and pass them to the driver."},{"line_number":3631,"context_line":"            self.driver.confirm_migration(context, migration, instance,"},{"line_number":3632,"context_line":"                                          network_info)"},{"line_number":3633,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_a7d472ea","line":3630,"updated":"2017-10-31 18:21:28.000000000","message":"This is here because eventually the resize.confirm.start/end notifications will be converted to versioned notifications and they will take a BlockDeviceMappingList if it\u0027s in scope, so we can avoid looking up BDMs twice by getting them once here and passing BDMs into the notification and driver code. That will be a later change. Also, this fix has to be backported so we don\u0027t want to change the driver method signature in this change.","commit_id":"f02afc6569bd930114a4b56413dbd6becc5e7e75"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"660d0cc65cedca5916099e83baebaddab9bec1f8","unresolved":false,"context_lines":[{"line_number":3627,"context_line":""},{"line_number":3628,"context_line":"            network_info \u003d self.network_api.get_instance_nw_info(context,"},{"line_number":3629,"context_line":"                                                                 instance)"},{"line_number":3630,"context_line":"            # TODO(mriedem): Get BDMs here and pass them to the driver."},{"line_number":3631,"context_line":"            self.driver.confirm_migration(context, migration, instance,"},{"line_number":3632,"context_line":"                                          network_info)"},{"line_number":3633,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_2c52693c","line":3630,"in_reply_to":"3f4b6375_a7d472ea","updated":"2017-11-02 15:04:39.000000000","message":"All of that could have gone into the TODO, you know :)","commit_id":"f02afc6569bd930114a4b56413dbd6becc5e7e75"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"c9c5d07ea365e6a3305d132e5f0e1edd7748a41f","unresolved":false,"context_lines":[{"line_number":1149,"context_line":""},{"line_number":1150,"context_line":"        # NOTE(mjozefcz):"},{"line_number":1151,"context_line":"        # self.image_backend.image for some backends recreates instance"},{"line_number":1152,"context_line":"        # directory and image disk.info - remove it here if exists"},{"line_number":1153,"context_line":"        # Do not remove inst_base for volume-backed instances since that"},{"line_number":1154,"context_line":"        # could potentially remove the files on the destination host"},{"line_number":1155,"context_line":"        # if using shared storage."}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_5378b529","line":1152,"range":{"start_line":1152,"start_character":60,"end_line":1152,"end_character":66},"updated":"2017-11-02 01:35:16.000000000","message":"nit: need \".\" at the end of this line to avoid a small confusion.","commit_id":"f02afc6569bd930114a4b56413dbd6becc5e7e75"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"c9c5d07ea365e6a3305d132e5f0e1edd7748a41f","unresolved":false,"context_lines":[{"line_number":1152,"context_line":"        # directory and image disk.info - remove it here if exists"},{"line_number":1153,"context_line":"        # Do not remove inst_base for volume-backed instances since that"},{"line_number":1154,"context_line":"        # could potentially remove the files on the destination host"},{"line_number":1155,"context_line":"        # if using shared storage."},{"line_number":1156,"context_line":"        if (os.path.exists(inst_base) and not root_disk.exists() and"},{"line_number":1157,"context_line":"                not compute_utils.is_volume_backed_instance("},{"line_number":1158,"context_line":"                    context, instance)):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_d3914548","line":1155,"updated":"2017-11-02 01:35:16.000000000","message":"nice description :)","commit_id":"f02afc6569bd930114a4b56413dbd6becc5e7e75"}]}