)]}'
{"nova/conductor/tasks/migrate.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"bbf85914fe88e58e3422ee82e6b9f1f7e7c03f95","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        LOG.error(\u0027Unable to find existing allocations for instance on \u0027"},{"line_number":51,"context_line":"                  \u0027source compute node: %s\u0027, source_cn.uuid,"},{"line_number":52,"context_line":"                  instance\u003dinstance)"},{"line_number":53,"context_line":"        # A generic error like this will just error out the migration"},{"line_number":54,"context_line":"        # and do any rollback required"},{"line_number":55,"context_line":"        raise exception.ConsumerAllocationNotFound("},{"line_number":56,"context_line":"            consumer_id\u003dinstance.uuid, provider_uuid\u003dsource_cn.uuid)"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_bbb44081","line":54,"range":{"start_line":53,"start_character":8,"end_line":54,"end_character":38},"updated":"2017-11-28 18:54:38.000000000","message":"The changed error doesn\u0027t seem a generic error..\nI think we need to remove here for avoiding confusions in the future.","commit_id":"2f53a9af5d4f27dc42dc6d2bd7f9b0e7aef6907a"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3d721b7bd6bc0ec13ce066c858044cdf1b1b4961","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        LOG.error(\u0027Unable to find existing allocations for instance on \u0027"},{"line_number":51,"context_line":"                  \u0027source compute node: %s\u0027, source_cn.uuid,"},{"line_number":52,"context_line":"                  instance\u003dinstance)"},{"line_number":53,"context_line":"        # A generic error like this will just error out the migration"},{"line_number":54,"context_line":"        # and do any rollback required"},{"line_number":55,"context_line":"        raise exception.ConsumerAllocationNotFound("},{"line_number":56,"context_line":"            consumer_id\u003dinstance.uuid, provider_uuid\u003dsource_cn.uuid)"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_fbe2c5d4","line":54,"range":{"start_line":53,"start_character":8,"end_line":54,"end_character":38},"in_reply_to":"ff82abbf_bbb44081","updated":"2017-11-28 20:26:04.000000000","message":"The old one _was_ generic. I just picked it so I had something to catch in the callers for this. I\u0027m not sure I see the problem here.","commit_id":"2f53a9af5d4f27dc42dc6d2bd7f9b0e7aef6907a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"205887082d225269f727218265738fb2f17e8741","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        LOG.error(\u0027Unable to find existing allocations for instance on \u0027"},{"line_number":51,"context_line":"                  \u0027source compute node: %s\u0027, source_cn.uuid,"},{"line_number":52,"context_line":"                  instance\u003dinstance)"},{"line_number":53,"context_line":"        # A generic error like this will just error out the migration"},{"line_number":54,"context_line":"        # and do any rollback required"},{"line_number":55,"context_line":"        raise exception.ConsumerAllocationNotFound("},{"line_number":56,"context_line":"            consumer_id\u003dinstance.uuid, provider_uuid\u003dsource_cn.uuid)"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_d700d404","line":54,"range":{"start_line":53,"start_character":8,"end_line":54,"end_character":38},"in_reply_to":"ff82abbf_fbe2c5d4","updated":"2017-11-29 19:59:16.000000000","message":"Ken\u0027ichi is just asking that the comment be removed I think. If we were raising something truly generic, it would just be NovaException, but I\u0027m raising a specific failure for this case, which will eventually be a 500 out of the API. The original intent with raising here is to trigger the rollback code below, but it also goes back to the REST API since we\u0027re in an RPC call.","commit_id":"2f53a9af5d4f27dc42dc6d2bd7f9b0e7aef6907a"}]}