)]}'
{"nova/api/metadata/password.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"e0e46bbf1a3e261c89e6d10bf399d21f7bb2e5aa","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        instance.system_metadata.update(convert_password(ctxt, req.body))"},{"line_number":78,"context_line":"        instance.save()"},{"line_number":79,"context_line":"    else:"},{"line_number":80,"context_line":"        msg \u003d _(\"GET and POST only are supported.\")"},{"line_number":81,"context_line":"        raise exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_3432c0f3","line":80,"range":{"start_line":80,"start_character":17,"end_line":80,"end_character":48},"updated":"2017-11-02 02:46:31.000000000","message":"Better say \u0027Only GET and POST are supported\u0027 ?","commit_id":"58b2eab3681889fcd7d583d5ce38701d9f179c61"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"9ef4447e9005a1d9861c3536cb15e99f20a3644a","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        instance.system_metadata.update(convert_password(ctxt, req.body))"},{"line_number":78,"context_line":"        instance.save()"},{"line_number":79,"context_line":"    else:"},{"line_number":80,"context_line":"        msg \u003d _(\"GET and POST only are supported.\")"},{"line_number":81,"context_line":"        raise exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_95cddc86","line":80,"range":{"start_line":80,"start_character":17,"end_line":80,"end_character":48},"in_reply_to":"3f4b6375_3432c0f3","updated":"2017-11-14 21:04:29.000000000","message":"ok, will update.","commit_id":"58b2eab3681889fcd7d583d5ce38701d9f179c61"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"e0e46bbf1a3e261c89e6d10bf399d21f7bb2e5aa","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        instance.save()"},{"line_number":79,"context_line":"    else:"},{"line_number":80,"context_line":"        msg \u003d _(\"GET and POST only are supported.\")"},{"line_number":81,"context_line":"        raise exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_1416a44a","line":81,"range":{"start_line":81,"start_character":18,"end_line":81,"end_character":32},"updated":"2017-11-02 02:46:31.000000000","message":"seems 405 is reasonable here but our API guide says following so without microversion we can\u0027t change it, so LGTM\n\n 96   - the list of status codes allowed for a particular request\n 97\n 98     Example: an API previously could return 200, 400, 403, 404 and the\n 99     change would make the API now also be allowed to return 409.","commit_id":"58b2eab3681889fcd7d583d5ce38701d9f179c61"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"9ef4447e9005a1d9861c3536cb15e99f20a3644a","unresolved":false,"context_lines":[{"line_number":78,"context_line":"        instance.save()"},{"line_number":79,"context_line":"    else:"},{"line_number":80,"context_line":"        msg \u003d _(\"GET and POST only are supported.\")"},{"line_number":81,"context_line":"        raise exc.HTTPBadRequest(explanation\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_b5d0d820","line":81,"range":{"start_line":81,"start_character":18,"end_line":81,"end_character":32},"in_reply_to":"3f4b6375_1416a44a","updated":"2017-11-14 21:04:29.000000000","message":"Yeah, you are right. and I don\u0027t think it is worth to do that with a new microversion bump.","commit_id":"58b2eab3681889fcd7d583d5ce38701d9f179c61"}]}
