)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"480847dc69dac1ce0f456aa6d475b19d5085090f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Makes HTTP Location Header return as utf-8 as opposed to unicode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ensures that the HTTP location header is always utf-8 and not unicode"},{"line_number":10,"context_line":"as required by RFC 5897 which covers HTTP headers"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1235220"},{"line_number":13,"context_line":"Change-Id: I3080c44c88e319436c59e00cd55055f525c8978b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"da9df570_de2ddbff","line":10,"updated":"2014-09-25 21:03:16.000000000","message":"RFC 5897 is http://tools.ietf.org/html/rfc5897, which is \"Identification of Communications Services \nin the Session Initiation Protocol (SIP)\". I think you meant RFC 5987 :)","commit_id":"2eda348149a6b63c5c1b158f33287b32e4872678"}],"nova/api/openstack/compute/contrib/admin_actions.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"480847dc69dac1ce0f456aa6d475b19d5085090f","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        if rotation \u003e 0:"},{"line_number":307,"context_line":"            image_id \u003d str(image[\u0027id\u0027])"},{"line_number":308,"context_line":"            image_ref \u003d os.path.join(req.application_url, \u0027images\u0027, image_id)"},{"line_number":309,"context_line":"            resp.headers[\u0027Location\u0027] \u003d image_ref.encode(\u0027utf-8\u0027)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"        return resp"},{"line_number":312,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da9df570_fe329f5d","line":309,"updated":"2014-09-25 21:03:16.000000000","message":"I would think that the appropriate place to handle the encoding of header lines would be the underlying Response object, not individually on all the header set lines. So, this really should be handled in webob.Response, IMO.","commit_id":"2eda348149a6b63c5c1b158f33287b32e4872678"}],"nova/tests/api/openstack/compute/contrib/test_admin_actions.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"0ca4c03808edce20edf4e417e63b11904b5fc6a0","unresolved":false,"context_lines":[{"line_number":310,"context_line":"    def test_create_backup_location_utf8(self):"},{"line_number":311,"context_line":"        res \u003d self._test_create_backup_with_metadata()"},{"line_number":312,"context_line":"        # Will raise an exception if not utf-8"},{"line_number":313,"context_line":"        res.headers[\u0027Location\u0027].decode(\u0027utf-8\u0027)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    def test_create_backup_no_name(self):"},{"line_number":316,"context_line":"        # Name is required for backups."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2F2Zw%3D","line":313,"updated":"2013-10-27 14:54:06.000000000","message":"it doesn\u0027t looks like an valid test. The url are ascii. Try this: \u0027http://aaa/\u0027.decode(\u0027utf-8\u0027) , it won\u0027t raise exception.","commit_id":"a9aeefb250b7c00fd664ee16ea47bcac18d287d6"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"114076fc4cf47e27b644fe41c6448874ef573f85","unresolved":false,"context_lines":[{"line_number":310,"context_line":"    def test_create_backup_location_utf8(self):"},{"line_number":311,"context_line":"        res \u003d self._test_create_backup_with_metadata()"},{"line_number":312,"context_line":"        # Will raise an exception if not utf-8"},{"line_number":313,"context_line":"        res.headers[\u0027Location\u0027].decode(\u0027utf-8\u0027)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    def test_create_backup_no_name(self):"},{"line_number":316,"context_line":"        # Name is required for backups."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2F19g%3D","line":313,"in_reply_to":"AAAATn%2F%2F2Zw%3D","updated":"2013-10-28 02:07:44.000000000","message":"oops, I mean should try this: u\u0027abc\u0027.decode(\u0027utf-8\u0027) it won\u0027t raise exception. Maybe we also need assert the res.headers[\u0027Location\u0027] isn\u0027t unicode.","commit_id":"a9aeefb250b7c00fd664ee16ea47bcac18d287d6"}]}