)]}'
{"nova/tests/fixtures.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"77bfe33e7848544f3e8e7feb95169ebcf7e447e2","unresolved":false,"context_lines":[{"line_number":905,"context_line":"        try:"},{"line_number":906,"context_line":"            self._poison_libvirt_driver()"},{"line_number":907,"context_line":"        except ImportError:"},{"line_number":908,"context_line":"            # The libvirt driver uses modules that are not available"},{"line_number":909,"context_line":"            # on Windows."},{"line_number":910,"context_line":"            pass"},{"line_number":911,"context_line":""},{"line_number":912,"context_line":"    def _poison_libvirt_driver(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_ffeb4dd9","line":909,"range":{"start_line":908,"start_character":0,"end_line":909,"end_character":25},"updated":"2017-11-30 22:01:22.000000000","message":"This fixture is a common part of testing, and this additional code is just for Windows. However this workaround(catching ImportError) is too generic. I think the workaround can make potential issues disappear in long-term.\n\nHow about switching the behavior on TestCase side instead?\nTBH, I am still not sure what is actual error you want to fix.\nIt is better to submit launchpad report to share that and include the report number in the commit message.","commit_id":"2fef5cd814baabf46cd2387c348cf71405b6ed9b"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"2b384658433ef233e984c4fe2dd4728ebe827bc7","unresolved":false,"context_lines":[{"line_number":905,"context_line":"        try:"},{"line_number":906,"context_line":"            self._poison_libvirt_driver()"},{"line_number":907,"context_line":"        except ImportError:"},{"line_number":908,"context_line":"            # The libvirt driver uses modules that are not available"},{"line_number":909,"context_line":"            # on Windows."},{"line_number":910,"context_line":"            pass"},{"line_number":911,"context_line":""},{"line_number":912,"context_line":"    def _poison_libvirt_driver(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_56af8de2","line":909,"range":{"start_line":908,"start_character":0,"end_line":909,"end_character":25},"in_reply_to":"ff82abbf_ffeb4dd9","updated":"2017-12-05 11:27:43.000000000","message":"The issue is that nova.virt.libvirt is not importable on Windows: http://paste.openstack.org/raw/628147/ The culprit seems to be the \u0027pwd\u0027 module, which is not available on Windows.\n\nWe know that at the moment, running all the Nova unit tests on Windows may not be possible (similar import errors are highly likely to occur), but we\u0027d like to at least be able to run the Hyper-V driver unit tests on Windows.\n\nI don\u0027t think we can do anything at the TestCase level, besides skipping this fixture, but I wouldn\u0027t do that as it may be helpful on Windows as well.\n\nIMO catching this import error isn\u0027t that bad. Even if it passes here, if there\u0027s something preventing that module from being imported, the according unit tests should fail. If really needed, we may add a platform check here.\n\nThe alternative would be to add platform checks at the libvirt module level but I don\u0027t think that the libvirt driver maintainers would be too happy about that.\n\nI do agree that this could use a bug report though.","commit_id":"2fef5cd814baabf46cd2387c348cf71405b6ed9b"}]}