)]}'
{"nova/api/openstack/compute/migrations.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c0493f5b871465fb528c59073b8ffce2153e6947","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        return objects"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    @wsgi.Controller.api_version(\"2.1\")"},{"line_number":73,"context_line":"    @extensions.expected_errors(())"},{"line_number":74,"context_line":"    @validation.query_schema(schema_migrations.list_query_schema_v20)"},{"line_number":75,"context_line":"    def index(self, req):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f485f77_61b62d41","line":72,"updated":"2017-11-15 21:27:10.000000000","message":"Why is this needed?","commit_id":"dee916db79d5070415a649b5a05fbcd0949a9ec9"}],"nova/api/openstack/compute/schemas/migrations.py":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"fde3907bb50a7fe4fd532347bc1e96a8462c769d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"# under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import copy"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from nova.api.validation import parameter_types"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_e393d25b","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":11},"updated":"2017-11-09 07:02:19.000000000","message":"should be removed.","commit_id":"30120382beefa3d0fa1ed03f6e14aecc414f630a"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"1a3b3e5b45b8db35b6ea826d5b7d73a77cb368ab","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        \u0027status\u0027: parameter_types.single_param({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":28,"context_line":"        \u0027migration_type\u0027: parameter_types.single_param({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":29,"context_line":"    },"},{"line_number":30,"context_line":"    \u0027additionalProperties\u0027: False"},{"line_number":31,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_839ade6b","line":30,"range":{"start_line":30,"start_character":5,"end_line":30,"end_character":33},"updated":"2017-11-09 07:03:44.000000000","message":"should be true for backward compatibility ?","commit_id":"30120382beefa3d0fa1ed03f6e14aecc414f630a"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"7e007102be546d7e53658c8e18654b3d357aa267","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        \u0027status\u0027: parameter_types.single_param({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":28,"context_line":"        \u0027migration_type\u0027: parameter_types.single_param({\u0027type\u0027: \u0027string\u0027}),"},{"line_number":29,"context_line":"    },"},{"line_number":30,"context_line":"    \u0027additionalProperties\u0027: False"},{"line_number":31,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_43f4e65b","line":30,"range":{"start_line":30,"start_character":5,"end_line":30,"end_character":33},"in_reply_to":"1f485f77_839ade6b","updated":"2017-11-09 07:22:07.000000000","message":"Yes, sure, so I change it to True, and also, change all prop schema to parameter_types.common_query_param.","commit_id":"30120382beefa3d0fa1ed03f6e14aecc414f630a"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"44d9a434ba964d2ec9161978cb6937fcb55c6f41","unresolved":false,"context_lines":[{"line_number":17,"context_line":"list_query_schema_v20 \u003d {"},{"line_number":18,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":19,"context_line":"    \u0027properties\u0027: {"},{"line_number":20,"context_line":"        \u0027cell_name\u0027: parameter_types.common_query_param,"},{"line_number":21,"context_line":"        \u0027hidden\u0027: parameter_types.common_query_param,"},{"line_number":22,"context_line":"        \u0027host\u0027: parameter_types.common_query_param,"},{"line_number":23,"context_line":"        \u0027instance_uuid\u0027: parameter_types.common_query_param,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f485f77_ae94698c","line":20,"range":{"start_line":20,"start_character":8,"end_line":20,"end_character":56},"updated":"2017-11-13 08:51:48.000000000","message":"just a question\nI didn\u0027t find this in the db layer filter, where we added it?","commit_id":"d04b880687e36444f1eb2111dea046f2dfe8ea49"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"c77c43295923c603f1f17118a2cf83ccd6f7cc3a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"list_query_schema_v20 \u003d {"},{"line_number":18,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":19,"context_line":"    \u0027properties\u0027: {"},{"line_number":20,"context_line":"        \u0027cell_name\u0027: parameter_types.common_query_param,"},{"line_number":21,"context_line":"        \u0027hidden\u0027: parameter_types.common_query_param,"},{"line_number":22,"context_line":"        \u0027host\u0027: parameter_types.common_query_param,"},{"line_number":23,"context_line":"        \u0027instance_uuid\u0027: parameter_types.common_query_param,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f485f77_22cc0d34","line":20,"range":{"start_line":20,"start_character":8,"end_line":20,"end_character":56},"in_reply_to":"1f485f77_0ee7fde6","updated":"2017-11-13 09:43:09.000000000","message":"ok, I didn\u0027t see it in https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L4893\nand other places....","commit_id":"d04b880687e36444f1eb2111dea046f2dfe8ea49"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"4b3281aaed902807790ea6cee1d4b12e0d243f7b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"list_query_schema_v20 \u003d {"},{"line_number":18,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":19,"context_line":"    \u0027properties\u0027: {"},{"line_number":20,"context_line":"        \u0027cell_name\u0027: parameter_types.common_query_param,"},{"line_number":21,"context_line":"        \u0027hidden\u0027: parameter_types.common_query_param,"},{"line_number":22,"context_line":"        \u0027host\u0027: parameter_types.common_query_param,"},{"line_number":23,"context_line":"        \u0027instance_uuid\u0027: parameter_types.common_query_param,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1f485f77_0ee7fde6","line":20,"range":{"start_line":20,"start_character":8,"end_line":20,"end_character":56},"in_reply_to":"1f485f77_ae94698c","updated":"2017-11-13 09:11:36.000000000","message":"The cell_name was added in blueprint list-resizes-through-admin-api. https://review.openstack.org/#/c/30232/\n\nand some addition info, it was already deprecated by nova cli:\nhttps://bugs.launchpad.net/python-novaclient/+bug/1668743\nhttps://review.openstack.org/#/c/439141/\nAPI should support cell_name until it is deprecated.","commit_id":"d04b880687e36444f1eb2111dea046f2dfe8ea49"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c0493f5b871465fb528c59073b8ffce2153e6947","unresolved":false,"context_lines":[{"line_number":17,"context_line":"list_query_schema_v20 \u003d {"},{"line_number":18,"context_line":"    \u0027type\u0027: \u0027object\u0027,"},{"line_number":19,"context_line":"    \u0027properties\u0027: {"},{"line_number":20,"context_line":"        \u0027cell_name\u0027: parameter_types.common_query_param,"},{"line_number":21,"context_line":"        \u0027hidden\u0027: parameter_types.common_query_param,"},{"line_number":22,"context_line":"        \u0027host\u0027: parameter_types.common_query_param,"},{"line_number":23,"context_line":"        \u0027instance_uuid\u0027: parameter_types.common_query_param,"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f485f77_81db697a","line":20,"updated":"2017-11-15 21:27:10.000000000","message":"So novaclient can send this today, but it\u0027s totally ignored in the migration_get_all_by_filters DB API method. We could just omit this and it will not break anything because additionalProperties\u003dTrue below. Is this listed here just to be complete? If we leave it, I think we should leave a comment that it\u0027s not used in the code and it should be removed in a future microversion (along with making additionalProperties\u003dFalse).","commit_id":"dee916db79d5070415a649b5a05fbcd0949a9ec9"}],"nova/tests/unit/api/openstack/compute/test_migrations.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c0493f5b871465fb528c59073b8ffce2153e6947","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                   \u0027source_compute\u0027: \u0027host1\u0027, \u0027hidden\u0027: \u00270\u0027,"},{"line_number":174,"context_line":"                   \u0027migration_type\u0027: \u0027resize\u0027}"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        unknow_filter \u003d {\u0027unknow\u0027: \u0027unknow\u0027}"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        self.req.GET.update(filters)"},{"line_number":179,"context_line":"        self.req.GET.update(unknow_filter)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f485f77_61bd0d01","line":176,"range":{"start_line":176,"start_character":8,"end_line":176,"end_character":14},"updated":"2017-11-15 21:27:10.000000000","message":"unknown","commit_id":"dee916db79d5070415a649b5a05fbcd0949a9ec9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"083f2b4ca2997b5bc87d36a44717b094520fef95","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                   \u0027source_compute\u0027: \u0027host1\u0027, \u0027hidden\u0027: \u00270\u0027,"},{"line_number":174,"context_line":"                   \u0027migration_type\u0027: \u0027resize\u0027}"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        unknow_filter \u003d {\u0027unknow\u0027: \u0027unknow\u0027}"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        self.req.GET.update(filters)"},{"line_number":179,"context_line":"        self.req.GET.update(unknow_filter)"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f485f77_a196654b","line":176,"range":{"start_line":176,"start_character":8,"end_line":176,"end_character":14},"in_reply_to":"1f485f77_61bd0d01","updated":"2017-11-15 21:28:54.000000000","message":"Actually, if you removed cell_name from the explicit schema, then this could just test cell_name still working.","commit_id":"dee916db79d5070415a649b5a05fbcd0949a9ec9"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c0493f5b871465fb528c59073b8ffce2153e6947","unresolved":false,"context_lines":[{"line_number":185,"context_line":"        ):"},{"line_number":186,"context_line":"            response \u003d self.controller.index(self.req)"},{"line_number":187,"context_line":"            self.assertEqual(migrations_in_progress, response)"},{"line_number":188,"context_line":"            # Only with the filters, and the unknow filter is stripped"},{"line_number":189,"context_line":"            mock_get_migrations.assert_called_once_with(self.context, filters)"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    def test_index_query_allow_negative_int_as_string(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1f485f77_013e598b","line":188,"range":{"start_line":188,"start_character":45,"end_line":188,"end_character":51},"updated":"2017-11-15 21:27:10.000000000","message":"unknown","commit_id":"dee916db79d5070415a649b5a05fbcd0949a9ec9"}]}