)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"530d695bb638b9e46e6f6f4f416f3a17c6991e13","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ilya Shakhat \u003cshakhat@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-12-20 17:47:51 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Initialize osprofiler in uWSGI application"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds missing initialization of OSProfiler when"},{"line_number":10,"context_line":"Nova API is running as uWSGI application."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf8cb3f7_ba53a1e2","line":7,"updated":"2017-12-20 16:51:29.000000000","message":"it\u0027s not the uwsgi application, it\u0027s the WSGI application. Any WSGI server can use it.","commit_id":"5f236156f58eb848b08243e886b0e99f24e52c5b"},{"author":{"_account_id":5950,"name":"Ilya Shakhat","email":"shakhat@gmail.com","username":"shakhat"},"change_message_id":"ac62b96b7ad3ce2894cae258d13ddfd214a287f1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ilya Shakhat \u003cshakhat@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-12-20 17:47:51 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Initialize osprofiler in uWSGI application"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds missing initialization of OSProfiler when"},{"line_number":10,"context_line":"Nova API is running as uWSGI application."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf8cb3f7_9c8248c8","line":7,"in_reply_to":"bf8cb3f7_ba53a1e2","updated":"2017-12-21 10:28:17.000000000","message":"Right! Fixed.","commit_id":"5f236156f58eb848b08243e886b0e99f24e52c5b"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"530d695bb638b9e46e6f6f4f416f3a17c6991e13","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Initialize osprofiler in uWSGI application"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds missing initialization of OSProfiler when"},{"line_number":10,"context_line":"Nova API is running as uWSGI application."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I779b144cfdfbe4a9a572990bad9720113402ac7f"},{"line_number":13,"context_line":"Related-Bug: #1731864"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf8cb3f7_da50e5d7","line":10,"updated":"2017-12-20 16:51:29.000000000","message":"s/uWSGI/WSGI/","commit_id":"5f236156f58eb848b08243e886b0e99f24e52c5b"},{"author":{"_account_id":5950,"name":"Ilya Shakhat","email":"shakhat@gmail.com","username":"shakhat"},"change_message_id":"ac62b96b7ad3ce2894cae258d13ddfd214a287f1","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Initialize osprofiler in uWSGI application"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds missing initialization of OSProfiler when"},{"line_number":10,"context_line":"Nova API is running as uWSGI application."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I779b144cfdfbe4a9a572990bad9720113402ac7f"},{"line_number":13,"context_line":"Related-Bug: #1731864"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bf8cb3f7_5c6cc035","line":10,"in_reply_to":"bf8cb3f7_da50e5d7","updated":"2017-12-21 10:28:17.000000000","message":"Done","commit_id":"5f236156f58eb848b08243e886b0e99f24e52c5b"}],"nova/api/openstack/wsgi_app.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"e28330d441fd01af15e9f7b9126a5d056c103188","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    except exception.ServiceTooOld as exc:"},{"line_number":83,"context_line":"        return error_application(exc, name)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    service.setup_profiler(name)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    conf \u003d conf_files[0]"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_6aa7d9bd","line":85,"updated":"2017-12-20 02:49:47.000000000","message":"service.setup_profiler(name, CONF.host) would be better","commit_id":"908f2ba37a85f7dd29466046092e3f78541d5796"},{"author":{"_account_id":5950,"name":"Ilya Shakhat","email":"shakhat@gmail.com","username":"shakhat"},"change_message_id":"c6abc35cd05aaea7fe36d9db585c664cf8bc3462","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    except exception.ServiceTooOld as exc:"},{"line_number":83,"context_line":"        return error_application(exc, name)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    service.setup_profiler(name)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    conf \u003d conf_files[0]"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf8cb3f7_fadb697a","line":85,"in_reply_to":"df87a7cf_6aa7d9bd","updated":"2017-12-20 16:48:44.000000000","message":"done","commit_id":"908f2ba37a85f7dd29466046092e3f78541d5796"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"02fd341fa1eb413417e530c12136b111c96cae3f","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    except exception.ServiceTooOld as exc:"},{"line_number":83,"context_line":"        return error_application(exc, name)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    service.setup_profiler(name, CONF.host)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    conf \u003d conf_files[0]"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9f91af0f_3a96fa94","line":85,"range":{"start_line":85,"start_character":27,"end_line":85,"end_character":31},"updated":"2018-01-09 16:35:56.000000000","message":"This argument in the setup_profiler method is called \"binary\" but in the case of the wsgiservice it only ever passed the name, which is \u0027osapi_compute\u0027 or \u0027metadata\u0027, but with the non-wsgi services like nova-conductor and nova-compute, the profiler name would be the binary, which is prefixed with \"nova-\". So I guess this is at least consistent with the wsgiservice profiler names that were used before, even though it seems the wsgiservice was using the wrong argument (name vs binary).\n\nhttps://github.com/openstack/nova/blob/master/nova/cmd/api_os_compute.py#L49\n\nhttps://github.com/openstack/nova/blob/master/nova/service.py#L326","commit_id":"0b4608bf0b40d50834bd5ab2e50096ec6c284822"}],"nova/service.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d95d9862607c28283e57d59d4967c65c0cd356b6","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        service.save()"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"def setup_profiler(binary, host\u003d\u00270.0.0.0\u0027):"},{"line_number":88,"context_line":"    if osprofiler and CONF.profiler.enabled:"},{"line_number":89,"context_line":"        osprofiler.initializer.init_from_conf("},{"line_number":90,"context_line":"            conf\u003dCONF,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_2aaeba80","line":87,"range":{"start_line":87,"start_character":27,"end_line":87,"end_character":41},"updated":"2017-12-19 18:07:51.000000000","message":"Is this intentional?","commit_id":"908f2ba37a85f7dd29466046092e3f78541d5796"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"e28330d441fd01af15e9f7b9126a5d056c103188","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        service.save()"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"def setup_profiler(binary, host\u003d\u00270.0.0.0\u0027):"},{"line_number":88,"context_line":"    if osprofiler and CONF.profiler.enabled:"},{"line_number":89,"context_line":"        osprofiler.initializer.init_from_conf("},{"line_number":90,"context_line":"            conf\u003dCONF,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_ea9a096d","line":87,"range":{"start_line":87,"start_character":27,"end_line":87,"end_character":41},"in_reply_to":"df87a7cf_2aaeba80","updated":"2017-12-20 02:49:47.000000000","message":"I think that\u0027s just a mistake. We can keep it as is, and call service.setup_profiler(name, CONF.host).","commit_id":"908f2ba37a85f7dd29466046092e3f78541d5796"},{"author":{"_account_id":5950,"name":"Ilya Shakhat","email":"shakhat@gmail.com","username":"shakhat"},"change_message_id":"c6abc35cd05aaea7fe36d9db585c664cf8bc3462","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        service.save()"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"def setup_profiler(binary, host\u003d\u00270.0.0.0\u0027):"},{"line_number":88,"context_line":"    if osprofiler and CONF.profiler.enabled:"},{"line_number":89,"context_line":"        osprofiler.initializer.init_from_conf("},{"line_number":90,"context_line":"            conf\u003dCONF,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf8cb3f7_bae5e13a","line":87,"range":{"start_line":87,"start_character":27,"end_line":87,"end_character":41},"in_reply_to":"df87a7cf_ea9a096d","updated":"2017-12-20 16:48:44.000000000","message":"right, change is not needed","commit_id":"908f2ba37a85f7dd29466046092e3f78541d5796"}]}