)]}'
{"nova/api/openstack/compute/migrations.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ee0a84497c08f91bb34ce88398442098809beb79","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            if \u0027memory_total\u0027 in obj:"},{"line_number":55,"context_line":"                for key in detail_keys:"},{"line_number":56,"context_line":"                    del obj[key]"},{"line_number":57,"context_line":"            # NOTE(Shaohe Feng) above version 2.23, add migration_type for all"},{"line_number":58,"context_line":"            # kinds of migration, but we only add links just for in-progress"},{"line_number":59,"context_line":"            # live-migration."},{"line_number":60,"context_line":"            if add_link and obj[\u0027migration_type\u0027] \u003d\u003d \"live-migration\" and ("},{"line_number":61,"context_line":"                    obj[\"status\"] in live_migration_in_progress):"},{"line_number":62,"context_line":"                obj[\"links\"] \u003d self._view_builder._get_links("},{"line_number":63,"context_line":"                    req, obj[\"id\"],"},{"line_number":64,"context_line":"                    self._collection_name % obj[\u0027instance_uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_c12a812a","side":"PARENT","line":61,"range":{"start_line":57,"start_character":12,"end_line":61,"end_character":65},"updated":"2017-11-15 21:24:03.000000000","message":"Well, to be clear, we filter on in-progress migrations if it\u0027 a live-migration and the microversion is \u003e\u003d 2.23. But otherwise we don\u0027t filter on status.\n\nYou know, come to think of it, 2.23 actually sort of broke the API here because if I\u0027m a user doing GET /os-migrations?status\u003derror\u0026migration_type\u003dlive-migration at 2.1, this would return them, but at microversion \u003e\u003d 2.23 it wouldn\u0027t, which is annoying. I\u0027ve really never liked the 2.23 microversion and what it did here at all.","commit_id":"6535abdaaa73d92ebe9101626cc3f5b11117a194"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dbf8a49f61d8d855b4bb96d5b69168a87d8b6373","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            if \u0027memory_total\u0027 in obj:"},{"line_number":55,"context_line":"                for key in detail_keys:"},{"line_number":56,"context_line":"                    del obj[key]"},{"line_number":57,"context_line":"            # NOTE(Shaohe Feng) above version 2.23, add migration_type for all"},{"line_number":58,"context_line":"            # kinds of migration, but we only add links just for in-progress"},{"line_number":59,"context_line":"            # live-migration."},{"line_number":60,"context_line":"            if add_link and obj[\u0027migration_type\u0027] \u003d\u003d \"live-migration\" and ("},{"line_number":61,"context_line":"                    obj[\"status\"] in live_migration_in_progress):"},{"line_number":62,"context_line":"                obj[\"links\"] \u003d self._view_builder._get_links("},{"line_number":63,"context_line":"                    req, obj[\"id\"],"},{"line_number":64,"context_line":"                    self._collection_name % obj[\u0027instance_uuid\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_21bef5d4","side":"PARENT","line":61,"range":{"start_line":57,"start_character":12,"end_line":61,"end_character":65},"in_reply_to":"1f485f77_c12a812a","updated":"2017-11-15 21:25:44.000000000","message":"\u003e You know, come to think of it, 2.23 actually sort of broke the API here because if I\u0027m a user doing GET /os-migrations?status\u003derror\u0026migration_type\u003dlive-migration at 2.1, this would return them, but at microversion \u003e\u003d 2.23 it wouldn\u0027t, which is annoying. I\u0027ve really never liked the 2.23 microversion and what it did here at all.\n\nNevermind, that\u0027s incorrect, \u003e\u003d2.23 here just means the links are returned for in-progress live migrations.","commit_id":"6535abdaaa73d92ebe9101626cc3f5b11117a194"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"ef998f8fd5f166a49e3f7848bd8671b68445026f","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @extensions.expected_errors(())"},{"line_number":71,"context_line":"    def index(self, req):"},{"line_number":72,"context_line":"        \"\"\"Return all migrations using the query parameters as filters.\"\"\""},{"line_number":73,"context_line":"        context \u003d req.environ[\u0027nova.context\u0027]"},{"line_number":74,"context_line":"        context.can(migrations_policies.POLICY_ROOT % \u0027index\u0027)"},{"line_number":75,"context_line":"        migrations \u003d self.compute_api.get_migrations(context, req.GET)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_e961c3aa","line":72,"updated":"2017-11-16 19:02:51.000000000","message":"I was wondering we need to fix api-ref[1], but current api-ref is good enough(\"List Migrations\") for users without this internal things.\n\n[1]: https://developer.openstack.org/api-ref/compute/#list-migrations","commit_id":"ba1fb2c2635f2c6428de150b1223a42c13cffd42"}]}