)]}'
{"nova/scheduler/filter_scheduler.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c4180845a6c287774b8225b9b52d5fef0ef4d0cc","unresolved":false,"context_lines":[{"line_number":224,"context_line":"            # the next instance."},{"line_number":225,"context_line":"            self._consume_selected_host(claimed_host, spec_obj)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        # Check if we were able to fufill the request. If not, this call will"},{"line_number":228,"context_line":"        # raise a NoValidHost exception."},{"line_number":229,"context_line":"        self._ensure_sufficient_hosts(claimed_hosts, num_instances,"},{"line_number":230,"context_line":"                claimed_instance_uuids)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_eeb445d3","line":227,"range":{"start_line":227,"start_character":35,"end_line":227,"end_character":41},"updated":"2017-11-16 00:36:53.000000000","message":"fulfill","commit_id":"ceb9c8dd45779a92a73cf4b99e080d6c4b82f379"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"5e09a7978e95a9a6c856d3e744723693d8b006a7","unresolved":false,"context_lines":[{"line_number":224,"context_line":"            # the next instance."},{"line_number":225,"context_line":"            self._consume_selected_host(claimed_host, spec_obj)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        # Check if we were able to fufill the request. If not, this call will"},{"line_number":228,"context_line":"        # raise a NoValidHost exception."},{"line_number":229,"context_line":"        self._ensure_sufficient_hosts(claimed_hosts, num_instances,"},{"line_number":230,"context_line":"                claimed_instance_uuids)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_f104141a","line":227,"range":{"start_line":227,"start_character":35,"end_line":227,"end_character":41},"in_reply_to":"1f485f77_eeb445d3","updated":"2017-11-16 13:48:53.000000000","message":"Done","commit_id":"ceb9c8dd45779a92a73cf4b99e080d6c4b82f379"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c4180845a6c287774b8225b9b52d5fef0ef4d0cc","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        not, log this failure, remove allocations for any claimed instances,"},{"line_number":242,"context_line":"        and raise a NoValidHost exception."},{"line_number":243,"context_line":"        \"\"\""},{"line_number":244,"context_line":"        if len(hosts) \u003d\u003d required_count:"},{"line_number":245,"context_line":"            # We have enough hosts."},{"line_number":246,"context_line":"            return"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_cecd0967","line":244,"range":{"start_line":244,"start_character":22,"end_line":244,"end_character":24},"updated":"2017-11-16 00:36:53.000000000","message":"Can we use the same \u003c logic as before from select_destinations()?","commit_id":"ceb9c8dd45779a92a73cf4b99e080d6c4b82f379"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"5e09a7978e95a9a6c856d3e744723693d8b006a7","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        not, log this failure, remove allocations for any claimed instances,"},{"line_number":242,"context_line":"        and raise a NoValidHost exception."},{"line_number":243,"context_line":"        \"\"\""},{"line_number":244,"context_line":"        if len(hosts) \u003d\u003d required_count:"},{"line_number":245,"context_line":"            # We have enough hosts."},{"line_number":246,"context_line":"            return"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_ec32fbf1","line":244,"range":{"start_line":244,"start_character":22,"end_line":244,"end_character":24},"in_reply_to":"1f485f77_cecd0967","updated":"2017-11-16 13:48:53.000000000","message":"I think it\u0027s cleaner here to return early if we know we have selected enough hosts. Otherwise, the entire method will be indented inside the \u0027if\u0027 block.","commit_id":"ceb9c8dd45779a92a73cf4b99e080d6c4b82f379"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a19f79a84390c0cbb35de52a3c195f57cfc446ae","unresolved":false,"context_lines":[{"line_number":241,"context_line":"        not, log this failure, remove allocations for any claimed instances,"},{"line_number":242,"context_line":"        and raise a NoValidHost exception."},{"line_number":243,"context_line":"        \"\"\""},{"line_number":244,"context_line":"        if len(hosts) \u003d\u003d required_count:"},{"line_number":245,"context_line":"            # We have enough hosts."},{"line_number":246,"context_line":"            return"},{"line_number":247,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_23df013b","line":244,"range":{"start_line":244,"start_character":22,"end_line":244,"end_character":24},"in_reply_to":"1f485f77_ec32fbf1","updated":"2017-11-16 14:59:20.000000000","message":"OK I guess to maintain the same logic that we had with \u003c then we\u0027d do \u003e\u003d. I don\u0027t know that we can have \u003e\u003d hosts to instances though.","commit_id":"ceb9c8dd45779a92a73cf4b99e080d6c4b82f379"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c4180845a6c287774b8225b9b52d5fef0ef4d0cc","unresolved":false,"context_lines":[{"line_number":314,"context_line":"        alloc_req \u003d alloc_reqs[0]"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        return self.placement_client.claim_resources(instance_uuid,"},{"line_number":317,"context_line":"                alloc_req, project_id, user_id)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def _legacy_find_hosts(self, num_instances, spec_obj, hosts,"},{"line_number":320,"context_line":"            num_to_return, include_alternates):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_4edfd90c","line":317,"updated":"2017-11-16 00:36:53.000000000","message":"This doesn\u0027t need to change.","commit_id":"ceb9c8dd45779a92a73cf4b99e080d6c4b82f379"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"5e09a7978e95a9a6c856d3e744723693d8b006a7","unresolved":false,"context_lines":[{"line_number":314,"context_line":"        alloc_req \u003d alloc_reqs[0]"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        return self.placement_client.claim_resources(instance_uuid,"},{"line_number":317,"context_line":"                alloc_req, project_id, user_id)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def _legacy_find_hosts(self, num_instances, spec_obj, hosts,"},{"line_number":320,"context_line":"            num_to_return, include_alternates):"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_8c538717","line":317,"in_reply_to":"1f485f77_4edfd90c","updated":"2017-11-16 13:48:53.000000000","message":"Done","commit_id":"ceb9c8dd45779a92a73cf4b99e080d6c4b82f379"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"5e09a7978e95a9a6c856d3e744723693d8b006a7","unresolved":false,"context_lines":[{"line_number":342,"context_line":"            selected_hosts.append(selected_host)"},{"line_number":343,"context_line":"            self._consume_selected_host(selected_host, spec_obj)"},{"line_number":344,"context_line":""},{"line_number":345,"context_line":"        # Check if we were able to fufill the request. If not, this call will"},{"line_number":346,"context_line":"        # raise a NoValidHost exception."},{"line_number":347,"context_line":"        self._ensure_sufficient_hosts(selected_hosts, num_instances)"},{"line_number":348,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_0c3f97b4","line":345,"range":{"start_line":345,"start_character":35,"end_line":345,"end_character":41},"updated":"2017-11-16 13:48:53.000000000","message":"Heh, you missed this mis-spelling! :)","commit_id":"ceb9c8dd45779a92a73cf4b99e080d6c4b82f379"}],"nova/tests/unit/scheduler/test_filter_scheduler.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"462483e2454e6e82207796f41205180e5d76ae2d","unresolved":false,"context_lines":[{"line_number":612,"context_line":""},{"line_number":613,"context_line":"        host_state \u003d mock.Mock(spec\u003dhost_manager.HostState, host\u003d\"fake_host\","},{"line_number":614,"context_line":"                uuid\u003duuids.cn1, cell_uuid\u003duuids.cell, nodename\u003d\"fake_node\","},{"line_number":615,"context_line":"                limits\u003d{}, updated\u003d\"Not None\")"},{"line_number":616,"context_line":"        all_host_states \u003d [host_state]"},{"line_number":617,"context_line":"        mock_get_all_states.return_value \u003d all_host_states"},{"line_number":618,"context_line":"        mock_get_hosts.side_effect \u003d [all_host_states, []]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f485f77_366a9dec","line":615,"range":{"start_line":615,"start_character":27,"end_line":615,"end_character":45},"updated":"2017-11-16 15:38:57.000000000","message":"You should probably assert that the host_state.updated value was set to None.","commit_id":"70a2467ba646703aa3d41fd139f79fae8e5ad462"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"acdc3705ec861d16c9e88c3ebcb2939accc43497","unresolved":false,"context_lines":[{"line_number":612,"context_line":""},{"line_number":613,"context_line":"        host_state \u003d mock.Mock(spec\u003dhost_manager.HostState, host\u003d\"fake_host\","},{"line_number":614,"context_line":"                uuid\u003duuids.cn1, cell_uuid\u003duuids.cell, nodename\u003d\"fake_node\","},{"line_number":615,"context_line":"                limits\u003d{}, updated\u003d\"Not None\")"},{"line_number":616,"context_line":"        all_host_states \u003d [host_state]"},{"line_number":617,"context_line":"        mock_get_all_states.return_value \u003d all_host_states"},{"line_number":618,"context_line":"        mock_get_hosts.side_effect \u003d [all_host_states, []]"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f485f77_56375900","line":615,"range":{"start_line":615,"start_character":27,"end_line":615,"end_character":45},"in_reply_to":"1f485f77_366a9dec","updated":"2017-11-16 15:42:45.000000000","message":"Done","commit_id":"70a2467ba646703aa3d41fd139f79fae8e5ad462"}]}