)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"27c379d65359551ef937bd9186abbc1fd369364f","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5a7d4faa26833481528845ccd4b8aff51c747bf7"},{"line_number":13,"context_line":"Closes-Bug: #1240383"},{"line_number":14,"context_line":"Signed-off-by: Yongli He \u003cyongli.he@intel.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATH%2F%2FZiE%3D","line":14,"updated":"2013-10-16 17:25:57.000000000","message":"We don\u0027t do SoBs, please remove.","commit_id":"ab18c3a0eff41f8cc6b1e0435d35c69c7c3b3746"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"e477d7486cff03ecaa4ef8b8a91d80fb3cd86aa5","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5a7d4faa26833481528845ccd4b8aff51c747bf7"},{"line_number":13,"context_line":"Closes-Bug: #1240383"},{"line_number":14,"context_line":"Signed-off-by: Yongli He \u003cyongli.he@intel.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2F7ss%3D","line":14,"in_reply_to":"AAAATH%2F%2FZiE%3D","updated":"2013-10-25 01:01:42.000000000","message":"Done","commit_id":"ab18c3a0eff41f8cc6b1e0435d35c69c7c3b3746"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"e38f92b93f8c2e96515da35b5d0b776ee792bf81","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5a7d4faa26833481528845ccd4b8aff51c747bf7"},{"line_number":13,"context_line":"Closes-Bug: #1240383"},{"line_number":14,"context_line":"Signed-off-by: Yongli He \u003cyongli.he@intel.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATH%2F%2FX1Q%3D","line":14,"in_reply_to":"AAAATH%2F%2FZiE%3D","updated":"2013-10-17 02:17:14.000000000","message":"do you mean i need remove \tSigned-off-by?","commit_id":"ab18c3a0eff41f8cc6b1e0435d35c69c7c3b3746"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"11968b4c7937d4df92a6d855b53375c2ebd2d876","unresolved":false,"context_lines":[{"line_number":7,"context_line":"pci passthrough: store json in extra info key value pair"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"unicode object support need know the exactly type of the value store"},{"line_number":10,"context_line":"in the objects, so store anything unkown as a json string."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5a7d4faa26833481528845ccd4b8aff51c747bf7"},{"line_number":13,"context_line":"Closes-Bug: #1240383"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATX%2F%2F77k%3D","line":10,"updated":"2013-10-23 23:57:18.000000000","message":"I think this paragraph needs a re-write. Its not very clear to me what its saying.\n\nPerhaps something like:\n\n\"Store PCI device extra info as json instead of strings, so that Unicode is handled correctly.\"","commit_id":"b5bbfaa76776f0bcf2db4534aa80680342c6dc2e"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"a31499d42416757249a559806cab3cad12a30d6c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"pci passthrough: store json in extra info key value pair"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"unicode object support need know the exactly type of the value store"},{"line_number":10,"context_line":"in the objects, so store anything unkown as a json string."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5a7d4faa26833481528845ccd4b8aff51c747bf7"},{"line_number":13,"context_line":"Closes-Bug: #1240383"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATn%2F%2F7tA%3D","line":10,"in_reply_to":"AAAATX%2F%2F77k%3D","updated":"2013-10-25 01:00:53.000000000","message":"Done","commit_id":"b5bbfaa76776f0bcf2db4534aa80680342c6dc2e"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"3027573c18e7881467dfdb390c27ff4bf37099c3","unresolved":false,"context_lines":[{"line_number":7,"context_line":"pci passthrough: store json in extra info key value pair"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"unicode object support need know the exactly type of the value store"},{"line_number":10,"context_line":"in the objects, so store anything unkown as a json string."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I5a7d4faa26833481528845ccd4b8aff51c747bf7"},{"line_number":13,"context_line":"Closes-Bug: #1240383"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAATX%2F%2F728%3D","line":10,"in_reply_to":"AAAATX%2F%2F77k%3D","updated":"2013-10-24 00:21:37.000000000","message":"i think the point is: the unicode solution don\u0027t allow unkonw data type, but we need this. so this is not for Unicode handled correctly(cause it\u0027s already json before this), this is for the unkonw type, convert any unkonw type to the json, so we know the type is string. , what do you think?","commit_id":"b5bbfaa76776f0bcf2db4534aa80680342c6dc2e"}],"nova/objects/pci_device.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"27c379d65359551ef937bd9186abbc1fd369364f","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            else:"},{"line_number":132,"context_line":"                # Note (yjiang5) extra_info.update does not update"},{"line_number":133,"context_line":"                # obj_what_changed, set it explicitely"},{"line_number":134,"context_line":"                v \u003d jsonutils.dumps(v)"},{"line_number":135,"context_line":"                extra_info \u003d self.extra_info"},{"line_number":136,"context_line":"                extra_info.update({k: v})"},{"line_number":137,"context_line":"                self.extra_info \u003d extra_info"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FZhg%3D","line":134,"updated":"2013-10-16 17:25:57.000000000","message":"This should be handled in the field spec now, I think.","commit_id":"ab18c3a0eff41f8cc6b1e0435d35c69c7c3b3746"},{"author":{"_account_id":7543,"name":"Yongli He","email":"yongli.he@intel.com","username":"yongli.he"},"change_message_id":"e477d7486cff03ecaa4ef8b8a91d80fb3cd86aa5","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            else:"},{"line_number":132,"context_line":"                # Note (yjiang5) extra_info.update does not update"},{"line_number":133,"context_line":"                # obj_what_changed, set it explicitely"},{"line_number":134,"context_line":"                v \u003d jsonutils.dumps(v)"},{"line_number":135,"context_line":"                extra_info \u003d self.extra_info"},{"line_number":136,"context_line":"                extra_info.update({k: v})"},{"line_number":137,"context_line":"                self.extra_info \u003d extra_info"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2F7sw%3D","line":134,"in_reply_to":"AAAATH%2F%2FZhg%3D","updated":"2013-10-25 01:01:42.000000000","message":"Done","commit_id":"ab18c3a0eff41f8cc6b1e0435d35c69c7c3b3746"}]}
