)]}'
{"nova/api/openstack/wsgi.py":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"198c130389ac6851c24a6928ae97d94dbca6c748","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    \u0027update\u0027,"},{"line_number":75,"context_line":"]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"_SANITIZE_KEYS \u003d [\u0027adminPass\u0027, \u0027admin_password\u0027]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"_SANITIZE_PATTERNS \u003d ["},{"line_number":80,"context_line":"    re.compile(r\u0027(adminPass\\s*[\u003d]\\s*[\\\"\\\u0027]).*?([\\\"\\\u0027])\u0027, re.DOTALL),"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2F1cE%3D","line":77,"updated":"2013-10-28 08:57:41.000000000","message":"I think we still need keep \u0027admin_pass\u0027 that used by v2 api","commit_id":"91bee73c42efacb9ba4a4f1e5169787c212ff640"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"c64c5581e1ccd8604e5c1ef7799334fa451ef364","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    \u0027update\u0027,"},{"line_number":75,"context_line":"]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"_SANITIZE_KEYS \u003d [\u0027adminPass\u0027, \u0027admin_password\u0027]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"_SANITIZE_PATTERNS \u003d ["},{"line_number":80,"context_line":"    re.compile(r\u0027(adminPass\\s*[\u003d]\\s*[\\\"\\\u0027]).*?([\\\"\\\u0027])\u0027, re.DOTALL),"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2FosQ%3D","line":77,"in_reply_to":"AAAATn%2F%2F06M%3D","updated":"2013-10-31 04:53:10.000000000","message":"yes, you are right. apologize for rely late.","commit_id":"91bee73c42efacb9ba4a4f1e5169787c212ff640"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d41420b9a3dc3e019bfc215dd95d13c9b9df92fe","unresolved":false,"context_lines":[{"line_number":74,"context_line":"    \u0027update\u0027,"},{"line_number":75,"context_line":"]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"_SANITIZE_KEYS \u003d [\u0027adminPass\u0027, \u0027admin_password\u0027]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"_SANITIZE_PATTERNS \u003d ["},{"line_number":80,"context_line":"    re.compile(r\u0027(adminPass\\s*[\u003d]\\s*[\\\"\\\u0027]).*?([\\\"\\\u0027])\u0027, re.DOTALL),"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2F06M%3D","line":77,"in_reply_to":"AAAATn%2F%2F1cE%3D","updated":"2013-10-28 11:54:45.000000000","message":"I feel v2 api does not use \"admin_pass\" like the following:\n\n- \"create a server\" API: adminPass\n- \"rebuild a server\" API: adminPass\n- \"evacuate a server\" API: adminPass\n- \"rescue a server\" API: adminPass","commit_id":"91bee73c42efacb9ba4a4f1e5169787c212ff640"}],"nova/tests/api/openstack/compute/plugins/v3/test_server_actions.py":[{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"bcb40d773a3163ecdce46bb53972c0f05ce43b20","unresolved":false,"context_lines":[{"line_number":443,"context_line":""},{"line_number":444,"context_line":"        body \u003d {"},{"line_number":445,"context_line":"            \"rebuild\": {"},{"line_number":446,"context_line":"                \"imageRef\": self._image_href,"},{"line_number":447,"context_line":"                \"adminPass\": \"asdf\","},{"line_number":448,"context_line":"            },"},{"line_number":449,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FOKE%3D","line":446,"updated":"2013-10-21 06:35:03.000000000","message":"image_ref","commit_id":"5c0dc6c765b240a1afc9f600396f893338944822"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"bcb40d773a3163ecdce46bb53972c0f05ce43b20","unresolved":false,"context_lines":[{"line_number":444,"context_line":"        body \u003d {"},{"line_number":445,"context_line":"            \"rebuild\": {"},{"line_number":446,"context_line":"                \"imageRef\": self._image_href,"},{"line_number":447,"context_line":"                \"adminPass\": \"asdf\","},{"line_number":448,"context_line":"            },"},{"line_number":449,"context_line":"        }"},{"line_number":450,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FOKA%3D","line":447,"updated":"2013-10-21 06:35:03.000000000","message":"admin_password","commit_id":"5c0dc6c765b240a1afc9f600396f893338944822"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"bcb40d773a3163ecdce46bb53972c0f05ce43b20","unresolved":false,"context_lines":[{"line_number":449,"context_line":"        }"},{"line_number":450,"context_line":""},{"line_number":451,"context_line":"        req \u003d fakes.HTTPRequest.blank(self.url)"},{"line_number":452,"context_line":"        body \u003d self.controller._action_rebuild(req, FAKE_UUID, body).obj"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"        self.assertEqual(body[\u0027server\u0027][\u0027image\u0027][\u0027id\u0027], \u00272\u0027)"},{"line_number":455,"context_line":"        self.assertEqual(body[\u0027server\u0027][\u0027adminPass\u0027], \u0027asdf\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FOJY%3D","line":452,"updated":"2013-10-21 06:35:03.000000000","message":"It should raise exc.HTTPBadRequest here. but not and the test pass. Can you check it and explain it?\n\nhttps://review.openstack.org/#/c/52087/3/nova/api/openstack/compute/plugins/v3/servers.py: line 131","commit_id":"5c0dc6c765b240a1afc9f600396f893338944822"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"bcb40d773a3163ecdce46bb53972c0f05ce43b20","unresolved":false,"context_lines":[{"line_number":452,"context_line":"        body \u003d self.controller._action_rebuild(req, FAKE_UUID, body).obj"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"        self.assertEqual(body[\u0027server\u0027][\u0027image\u0027][\u0027id\u0027], \u00272\u0027)"},{"line_number":455,"context_line":"        self.assertEqual(body[\u0027server\u0027][\u0027adminPass\u0027], \u0027asdf\u0027)"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"    def test_rebuild_admin_password_pass_disabled(self):"},{"line_number":458,"context_line":"        # run with enable_instance_password disabled to verify adminPass"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FOJ8%3D","line":455,"updated":"2013-10-21 06:35:03.000000000","message":"admin_password","commit_id":"5c0dc6c765b240a1afc9f600396f893338944822"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"bcb40d773a3163ecdce46bb53972c0f05ce43b20","unresolved":false,"context_lines":[{"line_number":465,"context_line":""},{"line_number":466,"context_line":"        body \u003d {"},{"line_number":467,"context_line":"            \"rebuild\": {"},{"line_number":468,"context_line":"                \"imageRef\": self._image_href,"},{"line_number":469,"context_line":"                \"adminPass\": \"asdf\","},{"line_number":470,"context_line":"            },"},{"line_number":471,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FOJM%3D","line":468,"updated":"2013-10-21 06:35:03.000000000","message":"ditto","commit_id":"5c0dc6c765b240a1afc9f600396f893338944822"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"bcb40d773a3163ecdce46bb53972c0f05ce43b20","unresolved":false,"context_lines":[{"line_number":473,"context_line":"        req \u003d fakes.HTTPRequest.blank(self.url)"},{"line_number":474,"context_line":"        body \u003d self.controller._action_rebuild(req, FAKE_UUID, body).obj"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"        self.assertEqual(body[\u0027server\u0027][\u0027image\u0027][\u0027id\u0027], \u00272\u0027)"},{"line_number":477,"context_line":"        self.assertNotIn(\u0027adminPass\u0027, body[\u0027server\u0027])"},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"    def test_rebuild_server_not_found(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FOJI%3D","line":476,"updated":"2013-10-21 06:35:03.000000000","message":"ditto","commit_id":"5c0dc6c765b240a1afc9f600396f893338944822"},{"author":{"_account_id":5586,"name":"Ivan-Zhu","email":"zhubo198511@gmail.com","username":"ivan-zhu"},"change_message_id":"bcb40d773a3163ecdce46bb53972c0f05ce43b20","unresolved":false,"context_lines":[{"line_number":482,"context_line":"        self.stubs.Set(db, \u0027instance_get_by_uuid\u0027, server_not_found)"},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"        body \u003d {"},{"line_number":485,"context_line":"            \"rebuild\": {"},{"line_number":486,"context_line":"                \"imageRef\": self._image_href,"},{"line_number":487,"context_line":"            },"},{"line_number":488,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FOJE%3D","line":485,"updated":"2013-10-21 06:35:03.000000000","message":"ditto","commit_id":"5c0dc6c765b240a1afc9f600396f893338944822"}]}