)]}'
{"nova/tests/functional/test_servers.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"0c4cf0d547f5c2fa264500f913b9f382d7ad16ab","unresolved":false,"context_lines":[{"line_number":1133,"context_line":"        admin_api \u003d self.api_fixture.admin_api"},{"line_number":1134,"context_line":"        admin_api.microversion \u003d \u00272.53\u0027"},{"line_number":1135,"context_line":""},{"line_number":1136,"context_line":"        # TODO(mriedem): Consider using GET /os-hypervisors/{hypervisor_id}"},{"line_number":1137,"context_line":"        # so that we can check usage values without the Placement API, because"},{"line_number":1138,"context_line":"        # this might need to get backported to branches that don\u0027t use"},{"line_number":1139,"context_line":"        # Placement."},{"line_number":1140,"context_line":"        def _get_provider_uuid_by_host(host):"},{"line_number":1141,"context_line":"            resp \u003d admin_api.api_get("},{"line_number":1142,"context_line":"                \u0027os-hypervisors?hypervisor_hostname_pattern\u003d%s\u0027 % host).body"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f485f77_2e134268","line":1139,"range":{"start_line":1136,"start_character":8,"end_line":1139,"end_character":20},"updated":"2017-11-17 19:17:25.000000000","message":"This doesn\u0027t work because the *_used values in the hypervisor API response are getting those values from the compute node which gets its values from the resource tracker, and since we don\u0027t perform a resource claim for rebuild, the values on the compute node never \u0027double\u0027 like the allocations and usages in Placement do, so we\u0027re stuck with this for Queens and Pike anyway (not a problem before Pike because we weren\u0027t creating allocations in the scheduler before Pike).","commit_id":"26945be3b3c19986bd2d2046add96d83b6e4a9f3"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"cf465b351bdc82c77e21ca4d4befb95a68ce5537","unresolved":false,"context_lines":[{"line_number":1191,"context_line":""},{"line_number":1192,"context_line":"        rebuild_image_ref \u003d ("},{"line_number":1193,"context_line":"            nova.tests.unit.image.fake.AUTO_DISK_CONFIG_ENABLED_IMAGE_UUID)"},{"line_number":1194,"context_line":"        # Now rebuild the server with that updated image."},{"line_number":1195,"context_line":"        rebuild_req_body \u003d {"},{"line_number":1196,"context_line":"            \u0027rebuild\u0027: {"},{"line_number":1197,"context_line":"                \u0027imageRef\u0027: rebuild_image_ref"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f485f77_f07e24e2","line":1194,"range":{"start_line":1194,"start_character":33,"end_line":1194,"end_character":57},"updated":"2017-11-17 21:29:43.000000000","message":"This doesn\u0027t make sense here, copy/paste issue.","commit_id":"65c82da3049fdedb31fbc469427990b793bc0ace"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8215138b9c34707df621ee2a0b5dd24b4eeb7f51","unresolved":false,"context_lines":[{"line_number":1179,"context_line":"            self.assertEqual(old_flavor[\u0027disk\u0027] + new_flavor[\u0027disk\u0027],"},{"line_number":1180,"context_line":"                             allocation[\u0027DISK_GB\u0027])"},{"line_number":1181,"context_line":""},{"line_number":1182,"context_line":"        nodename \u003d self.compute.manager._get_nodename(None)"},{"line_number":1183,"context_line":"        rp_uuid \u003d _get_provider_uuid_by_host(nodename)"},{"line_number":1184,"context_line":"        # make sure we start with no usage on the compute node"},{"line_number":1185,"context_line":"        rp_usages \u003d _get_provider_usages(rp_uuid)"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff82abbf_5c0c2b40","line":1182,"updated":"2017-11-27 19:51:24.000000000","message":"This won\u0027t work in Pike because the _get_nodename method didn\u0027t exist. We could probably just as easily do a GET /os-hypervisors and pull the uuid from the id in the response for the single compute.","commit_id":"bfbdad9f7dadb7951bc3e3d75005a432b2e7ace6"}]}