)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"364b0d04d26f8e4e4fca28fe5a23f0b81dbf10da","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"sec group APIs accept query param to filter the"},{"line_number":10,"context_line":"quota."},{"line_number":11,"context_line":"This commit adds json schema to validating the valid"},{"line_number":12,"context_line":"query parameters."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"There is no change in API behaviour and additionalProperty"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff82abbf_225ab8f2","line":11,"range":{"start_line":11,"start_character":32,"end_line":11,"end_character":52},"updated":"2017-11-22 16:20:37.000000000","message":"validate the","commit_id":"ca261d926265510904b7bb6c99f8c233896df040"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f151ec5ef52c73dd5d6daded5ebd36f4bf71d2ed","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"sec group APIs accept query param to filter the"},{"line_number":10,"context_line":"quota."},{"line_number":11,"context_line":"This commit adds json schema to validating the valid"},{"line_number":12,"context_line":"query parameters."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"There is no change in API behaviour and additionalProperty"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff82abbf_e6a8288d","line":11,"range":{"start_line":11,"start_character":32,"end_line":11,"end_character":52},"in_reply_to":"ff82abbf_225ab8f2","updated":"2017-11-25 01:08:47.000000000","message":"thank. done","commit_id":"ca261d926265510904b7bb6c99f8c233896df040"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"364b0d04d26f8e4e4fca28fe5a23f0b81dbf10da","unresolved":false,"context_lines":[{"line_number":11,"context_line":"This commit adds json schema to validating the valid"},{"line_number":12,"context_line":"query parameters."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"There is no change in API behaviour and additionalProperty"},{"line_number":15,"context_line":"is kept True for backward compatibility."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Partially implements blueprint json-schema-validation-for-query-param"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff82abbf_425d7ce7","line":14,"range":{"start_line":14,"start_character":40,"end_line":14,"end_character":58},"updated":"2017-11-22 16:20:37.000000000","message":"additionalProperties","commit_id":"ca261d926265510904b7bb6c99f8c233896df040"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f151ec5ef52c73dd5d6daded5ebd36f4bf71d2ed","unresolved":false,"context_lines":[{"line_number":11,"context_line":"This commit adds json schema to validating the valid"},{"line_number":12,"context_line":"query parameters."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"There is no change in API behaviour and additionalProperty"},{"line_number":15,"context_line":"is kept True for backward compatibility."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Partially implements blueprint json-schema-validation-for-query-param"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ff82abbf_06ae6c97","line":14,"range":{"start_line":14,"start_character":40,"end_line":14,"end_character":58},"in_reply_to":"ff82abbf_425d7ce7","updated":"2017-11-25 01:08:47.000000000","message":"you caught me. i was lazy to mention the exact name :)\ndone","commit_id":"ca261d926265510904b7bb6c99f8c233896df040"}],"nova/api/openstack/compute/schemas/security_groups.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4ecdb415c261e91080b6a52328e5edc5fa21aefd","unresolved":false,"context_lines":[{"line_number":44,"context_line":"             parameter_types.non_negative_integer),"},{"line_number":45,"context_line":"        \u0027offset\u0027: parameter_types.multi_params("},{"line_number":46,"context_line":"             parameter_types.non_negative_integer),"},{"line_number":47,"context_line":"        \u0027all_tenants\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027})"},{"line_number":48,"context_line":"    },"},{"line_number":49,"context_line":"    # NOTE(gmann): This is kept True to keep backward compatibility."},{"line_number":50,"context_line":"    # As of now Schema validation stripped out the additional parameters and"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_ed17c750","line":47,"updated":"2017-11-23 15:28:43.000000000","message":"I don\u0027t see the all_tenants in the API doc [1] as a possible parameter. Is it just a doc bug?\n\n[1] https://developer.openstack.org/api-ref/compute/#list-security-groups","commit_id":"ca261d926265510904b7bb6c99f8c233896df040"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"83dc4c85866cf6cf72e5a95c6d4bb3eaaef887e4","unresolved":false,"context_lines":[{"line_number":44,"context_line":"             parameter_types.non_negative_integer),"},{"line_number":45,"context_line":"        \u0027offset\u0027: parameter_types.multi_params("},{"line_number":46,"context_line":"             parameter_types.non_negative_integer),"},{"line_number":47,"context_line":"        \u0027all_tenants\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027})"},{"line_number":48,"context_line":"    },"},{"line_number":49,"context_line":"    # NOTE(gmann): This is kept True to keep backward compatibility."},{"line_number":50,"context_line":"    # As of now Schema validation stripped out the additional parameters and"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_86eefcb1","line":47,"in_reply_to":"ff82abbf_46a8f48b","updated":"2017-11-25 01:46:04.000000000","message":"doc fix -https://review.openstack.org/#/c/522910/1","commit_id":"ca261d926265510904b7bb6c99f8c233896df040"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f151ec5ef52c73dd5d6daded5ebd36f4bf71d2ed","unresolved":false,"context_lines":[{"line_number":44,"context_line":"             parameter_types.non_negative_integer),"},{"line_number":45,"context_line":"        \u0027offset\u0027: parameter_types.multi_params("},{"line_number":46,"context_line":"             parameter_types.non_negative_integer),"},{"line_number":47,"context_line":"        \u0027all_tenants\u0027: parameter_types.multi_params({\u0027type\u0027: \u0027string\u0027})"},{"line_number":48,"context_line":"    },"},{"line_number":49,"context_line":"    # NOTE(gmann): This is kept True to keep backward compatibility."},{"line_number":50,"context_line":"    # As of now Schema validation stripped out the additional parameters and"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_46a8f48b","line":47,"in_reply_to":"ff82abbf_ed17c750","updated":"2017-11-25 01:08:47.000000000","message":"doc missing the things, thanks ll fix that.\n\n\u0027all_tenant\u0027 is hidden in lower layer in code too\n- https://github.com/openstack/nova/blob/e9104dbaef9bbccc6b19811125d439fdf9558428/nova/network/security_group/neutron_driver.py#L178\n- https://github.com/openstack/nova/blob/e9104dbaef9bbccc6b19811125d439fdf9558428/nova/compute/api.py#L5096","commit_id":"ca261d926265510904b7bb6c99f8c233896df040"}],"nova/tests/unit/api/openstack/compute/test_security_groups.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"7edc27883e8c40417a002dfd4549d1724fcbb8bd","unresolved":false,"context_lines":[{"line_number":660,"context_line":""},{"line_number":661,"context_line":"    def _test_list_with_invalid_filter("},{"line_number":662,"context_line":"        self, url, expected_exception\u003dexception.ValidationError):"},{"line_number":663,"context_line":"        prefix \u003d \u0027/fake/os-security-groups\u0027"},{"line_number":664,"context_line":"        req \u003d fakes.HTTPRequest.blank(prefix + url)"},{"line_number":665,"context_line":"        self.assertRaises(expected_exception,"},{"line_number":666,"context_line":"                          self.controller.index, req)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_7c83d957","line":663,"range":{"start_line":663,"start_character":19,"end_line":663,"end_character":23},"updated":"2017-11-20 08:28:36.000000000","message":"guess we need use real uuid or uuidsentinel now","commit_id":"8c1cbf1fc7bd3275c245c6046dca16e0e922d8f9"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ffbb39df8906d6c5015dafe5f43cee33bb49c3d6","unresolved":false,"context_lines":[{"line_number":660,"context_line":""},{"line_number":661,"context_line":"    def _test_list_with_invalid_filter("},{"line_number":662,"context_line":"        self, url, expected_exception\u003dexception.ValidationError):"},{"line_number":663,"context_line":"        prefix \u003d \u0027/fake/os-security-groups\u0027"},{"line_number":664,"context_line":"        req \u003d fakes.HTTPRequest.blank(prefix + url)"},{"line_number":665,"context_line":"        self.assertRaises(expected_exception,"},{"line_number":666,"context_line":"                          self.controller.index, req)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_3cff9168","line":663,"range":{"start_line":663,"start_character":19,"end_line":663,"end_character":23},"in_reply_to":"ff82abbf_7c83d957","updated":"2017-11-20 08:44:15.000000000","message":"Done","commit_id":"8c1cbf1fc7bd3275c245c6046dca16e0e922d8f9"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"7edc27883e8c40417a002dfd4549d1724fcbb8bd","unresolved":false,"context_lines":[{"line_number":694,"context_line":""},{"line_number":695,"context_line":"        for param, value in params.items():"},{"line_number":696,"context_line":"            req \u003d fakes.HTTPRequest.blank("},{"line_number":697,"context_line":"                \u0027/fake/os-security-groups\u0027 + \u0027?%s\u003d%s\u0026%s\u003d%s\u0027 %"},{"line_number":698,"context_line":"                (param, value, param, value))"},{"line_number":699,"context_line":"            self.controller.index(req)"},{"line_number":700,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_bc908197","line":697,"range":{"start_line":697,"start_character":18,"end_line":697,"end_character":22},"updated":"2017-11-20 08:28:36.000000000","message":"ditto","commit_id":"8c1cbf1fc7bd3275c245c6046dca16e0e922d8f9"}]}