)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"27ad571f53553d970a968401dc21ae58208fc612","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Disable compute when libvirt is unavailable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Disabling nova-compute on libvirt connectivty exceptions."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"In addition, allowing update_available_resource, periodict task,"},{"line_number":12,"context_line":"to disable and re-enable the service, when libvirt is connected again."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATH%2F%2FQFk%3D","line":9,"updated":"2013-10-19 07:41:13.000000000","message":"I think that this should be done in 2 stages. The first is the driver support for disabling the compute node. This should in fact be a blue print. The second part should be the libvirt support.","commit_id":"62b232af573f89ae036b1058669b8783ed6bc996"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d0be031a0351e48941c09836881f93bf7bc37ee9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Disable compute when libvirt is unavailable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Disabling nova-compute on libvirt connectivty exceptions."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"In addition, allowing update_available_resource, periodict task,"},{"line_number":12,"context_line":"to disable and re-enable the service, when libvirt is connected again."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATH%2F%2FQfs%3D","line":9,"updated":"2013-10-18 22:50:01.000000000","message":"I think this line is redundant, although perhaps better than the one above. I think you can choose one and be fine :)","commit_id":"62b232af573f89ae036b1058669b8783ed6bc996"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"6fbe60904f3a6b91e3e92ebcf8f03a42d9a4c37e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Disable compute when libvirt is unavailable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Disabling nova-compute on libvirt connectivty exceptions."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"In addition, allowing update_available_resource, periodict task,"},{"line_number":12,"context_line":"to disable and re-enable the service, when libvirt is connected again."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATH%2F%2FMr0%3D","line":9,"in_reply_to":"AAAATH%2F%2FQFk%3D","updated":"2013-10-21 20:41:30.000000000","message":"Hi, Driver support was already there. line 781 in nova/virt/driver.py\n    def set_host_enabled(self, host, enabled):\n\nxenapi and vmwareapi are already using it.","commit_id":"62b232af573f89ae036b1058669b8783ed6bc996"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"6fbe60904f3a6b91e3e92ebcf8f03a42d9a4c37e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Disable compute when libvirt is unavailable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Disabling nova-compute on libvirt connectivty exceptions."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"In addition, allowing update_available_resource, periodict task,"},{"line_number":12,"context_line":"to disable and re-enable the service, when libvirt is connected again."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATH%2F%2FMt4%3D","line":9,"in_reply_to":"AAAATH%2F%2FQfs%3D","updated":"2013-10-21 20:41:30.000000000","message":"Done","commit_id":"62b232af573f89ae036b1058669b8783ed6bc996"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d0be031a0351e48941c09836881f93bf7bc37ee9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Disabling nova-compute on libvirt connectivty exceptions."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"In addition, allowing update_available_resource, periodict task,"},{"line_number":12,"context_line":"to disable and re-enable the service, when libvirt is connected again."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"It is being done according to the success or failure"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATH%2F%2FQfk%3D","line":11,"updated":"2013-10-18 22:50:01.000000000","message":"\"periodic\" is misspelled.","commit_id":"62b232af573f89ae036b1058669b8783ed6bc996"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"27ad571f53553d970a968401dc21ae58208fc612","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Disabling nova-compute on libvirt connectivty exceptions."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"In addition, allowing update_available_resource, periodict task,"},{"line_number":12,"context_line":"to disable and re-enable the service, when libvirt is connected again."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"It is being done according to the success or failure"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATH%2F%2FQFg%3D","line":11,"updated":"2013-10-19 07:41:13.000000000","message":"At the moment if the periodic support would report 0 resources available when libvirt is unavailable would also solve the issue. I guess that you could argue that this is a matter of timing.","commit_id":"62b232af573f89ae036b1058669b8783ed6bc996"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"6fbe60904f3a6b91e3e92ebcf8f03a42d9a4c37e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Disabling nova-compute on libvirt connectivty exceptions."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"In addition, allowing update_available_resource, periodict task,"},{"line_number":12,"context_line":"to disable and re-enable the service, when libvirt is connected again."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"It is being done according to the success or failure"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATH%2F%2FMt0%3D","line":11,"in_reply_to":"AAAATH%2F%2FQfk%3D","updated":"2013-10-21 20:41:30.000000000","message":"Done","commit_id":"62b232af573f89ae036b1058669b8783ed6bc996"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d0be031a0351e48941c09836881f93bf7bc37ee9","unresolved":false,"context_lines":[{"line_number":16,"context_line":"method."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This is in order to avoid migrations or new instances to be scheduled"},{"line_number":19,"context_line":"on, a disconnected from libvirt, compute node."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Fixes bug #1240670"},{"line_number":22,"context_line":"Change-Id: Ib8d67838ceb73c5b1cdc9498c17b335e9e5bb6f3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATH%2F%2FQfY%3D","line":19,"updated":"2013-10-18 22:50:01.000000000","message":"I think both of the commas on this line should be removed.","commit_id":"62b232af573f89ae036b1058669b8783ed6bc996"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"6fbe60904f3a6b91e3e92ebcf8f03a42d9a4c37e","unresolved":false,"context_lines":[{"line_number":16,"context_line":"method."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This is in order to avoid migrations or new instances to be scheduled"},{"line_number":19,"context_line":"on, a disconnected from libvirt, compute node."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Fixes bug #1240670"},{"line_number":22,"context_line":"Change-Id: Ib8d67838ceb73c5b1cdc9498c17b335e9e5bb6f3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATH%2F%2FMtw%3D","line":19,"in_reply_to":"AAAATH%2F%2FQfY%3D","updated":"2013-10-21 20:41:30.000000000","message":"Done","commit_id":"62b232af573f89ae036b1058669b8783ed6bc996"},{"author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"change_message_id":"a71832701d633fb4797ad00c6d2349686189c86b","unresolved":false,"context_lines":[{"line_number":18,"context_line":"This is in order to avoid migrations or new instances to be scheduled"},{"line_number":19,"context_line":"on, a disconnected from libvirt, compute node."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Fixes bug #1240670"},{"line_number":22,"context_line":"Change-Id: Ib8d67838ceb73c5b1cdc9498c17b335e9e5bb6f3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATH%2F%2FQRg%3D","line":21,"updated":"2013-10-19 02:35:37.000000000","message":"The correct syntax is Closes-bug: #","commit_id":"62b232af573f89ae036b1058669b8783ed6bc996"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"6fbe60904f3a6b91e3e92ebcf8f03a42d9a4c37e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"This is in order to avoid migrations or new instances to be scheduled"},{"line_number":19,"context_line":"on, a disconnected from libvirt, compute node."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Fixes bug #1240670"},{"line_number":22,"context_line":"Change-Id: Ib8d67838ceb73c5b1cdc9498c17b335e9e5bb6f3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATH%2F%2FMto%3D","line":21,"in_reply_to":"AAAATH%2F%2FQRg%3D","updated":"2013-10-21 20:41:30.000000000","message":"Done","commit_id":"62b232af573f89ae036b1058669b8783ed6bc996"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"0171b0c9c95e68673e157d3ad75ca5c7a4f8a2cc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Vladik Romanovsky \u003cvladik.romanovsky@enovance.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-10-23 11:35:46 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Disable nova-compute on libvirt connectivty exceptions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The service will be disabled and re-enabled according to the success"},{"line_number":10,"context_line":"or failure of establishing a connection to the libvirt service."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAATX%2F%2F9hY%3D","line":7,"updated":"2013-10-23 16:15:48.000000000","message":"missing \u0027i\u0027 in \u0027connectivity\u0027","commit_id":"2cae1623e4f67b3f65a90af8eea593e9833d7483"}],"nova/compute/manager.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d0be031a0351e48941c09836881f93bf7bc37ee9","unresolved":false,"context_lines":[{"line_number":4855,"context_line":"    def _update_service_status(self, context, error\u003dNone):"},{"line_number":4856,"context_line":"        status \u003d {True: \u0027Enabled\u0027,"},{"line_number":4857,"context_line":"                  False: \u0027Disabled\u0027}"},{"line_number":4858,"context_line":"        service_ref \u003d self.conductor_api.service_get_by_compute_host("},{"line_number":4859,"context_line":"            context, self.host)"},{"line_number":4860,"context_line":"        enable_host \u003d not bool(error)"},{"line_number":4861,"context_line":"        if service_ref[\u0027disabled\u0027] \u003d\u003d enable_host:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FQfM%3D","line":4858,"updated":"2013-10-18 22:50:01.000000000","message":"Please use objects here:\n\n service \u003d service_obj.Service.get_by_compute_host()","commit_id":"62b232af573f89ae036b1058669b8783ed6bc996"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"6fbe60904f3a6b91e3e92ebcf8f03a42d9a4c37e","unresolved":false,"context_lines":[{"line_number":4855,"context_line":"    def _update_service_status(self, context, error\u003dNone):"},{"line_number":4856,"context_line":"        status \u003d {True: \u0027Enabled\u0027,"},{"line_number":4857,"context_line":"                  False: \u0027Disabled\u0027}"},{"line_number":4858,"context_line":"        service_ref \u003d self.conductor_api.service_get_by_compute_host("},{"line_number":4859,"context_line":"            context, self.host)"},{"line_number":4860,"context_line":"        enable_host \u003d not bool(error)"},{"line_number":4861,"context_line":"        if service_ref[\u0027disabled\u0027] \u003d\u003d enable_host:"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FMcY%3D","line":4858,"in_reply_to":"AAAATH%2F%2FQfM%3D","updated":"2013-10-21 20:41:30.000000000","message":"Done","commit_id":"62b232af573f89ae036b1058669b8783ed6bc996"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"27ad571f53553d970a968401dc21ae58208fc612","unresolved":false,"context_lines":[{"line_number":4875,"context_line":"        hypervisor_error \u003d \u0027\u0027"},{"line_number":4876,"context_line":"        new_resource_tracker_dict \u003d {}"},{"line_number":4877,"context_line":"        try:"},{"line_number":4878,"context_line":"            nodenames \u003d set(self.driver.get_available_nodes())"},{"line_number":4879,"context_line":"        except Exception as ex:"},{"line_number":4880,"context_line":"            hypervisor_error \u003d ex"},{"line_number":4881,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FQFU%3D","line":4878,"updated":"2013-10-19 07:41:13.000000000","message":"why would the driver not return [] if there is a problem. What are the consequences of setting the service status.\nWhat if, in the example you use, libvirt is up, but there is some other error here, then the node may be set to disabled and never be set to enabled again.","commit_id":"62b232af573f89ae036b1058669b8783ed6bc996"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"6fbe60904f3a6b91e3e92ebcf8f03a42d9a4c37e","unresolved":false,"context_lines":[{"line_number":4875,"context_line":"        hypervisor_error \u003d \u0027\u0027"},{"line_number":4876,"context_line":"        new_resource_tracker_dict \u003d {}"},{"line_number":4877,"context_line":"        try:"},{"line_number":4878,"context_line":"            nodenames \u003d set(self.driver.get_available_nodes())"},{"line_number":4879,"context_line":"        except Exception as ex:"},{"line_number":4880,"context_line":"            hypervisor_error \u003d ex"},{"line_number":4881,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FM0g%3D","line":4878,"in_reply_to":"AAAATH%2F%2FQFU%3D","updated":"2013-10-21 20:41:30.000000000","message":"I think, that replying with [], will hide  the problem. \n\nNot disabling the service, but removing the resources will raise a lot of questions on the user side.\n\nExplicitly disabling the service will indicate a problem with the hypervisor.\nThis will also, explicitly disable scheduling on this host.\n\nIn addition, as I see it, if libvirt service is up, but cant report capabilities, it indicates of a problem, hence, there is no reason to enable the service in case, as well.","commit_id":"62b232af573f89ae036b1058669b8783ed6bc996"}],"nova/tests/compute/test_compute.py":[{"author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"change_message_id":"a71832701d633fb4797ad00c6d2349686189c86b","unresolved":false,"context_lines":[{"line_number":8179,"context_line":"                         self.compute_api.get_instance_bdms({}, instance))"},{"line_number":8180,"context_line":""},{"line_number":8181,"context_line":""},{"line_number":8182,"context_line":"class ComputeAPIHypervisorConnectionTestCase(test.TestCase):"},{"line_number":8183,"context_line":""},{"line_number":8184,"context_line":"    def setUp(self):"},{"line_number":8185,"context_line":"        super(ComputeAPIHypervisorConnectionTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FQRM%3D","line":8182,"updated":"2013-10-19 02:35:37.000000000","message":"NoDBTestCase","commit_id":"62b232af573f89ae036b1058669b8783ed6bc996"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"6fbe60904f3a6b91e3e92ebcf8f03a42d9a4c37e","unresolved":false,"context_lines":[{"line_number":8179,"context_line":"                         self.compute_api.get_instance_bdms({}, instance))"},{"line_number":8180,"context_line":""},{"line_number":8181,"context_line":""},{"line_number":8182,"context_line":"class ComputeAPIHypervisorConnectionTestCase(test.TestCase):"},{"line_number":8183,"context_line":""},{"line_number":8184,"context_line":"    def setUp(self):"},{"line_number":8185,"context_line":"        super(ComputeAPIHypervisorConnectionTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FL9o%3D","line":8182,"in_reply_to":"AAAATH%2F%2FQRM%3D","updated":"2013-10-21 20:41:30.000000000","message":"Done","commit_id":"62b232af573f89ae036b1058669b8783ed6bc996"}],"nova/virt/driver.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d0be031a0351e48941c09836881f93bf7bc37ee9","unresolved":false,"context_lines":[{"line_number":778,"context_line":"        \"\"\""},{"line_number":779,"context_line":"        raise NotImplementedError()"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"    def set_host_enabled(self, host, enabled, **kwargs):"},{"line_number":782,"context_line":"        \"\"\"Sets the specified host\u0027s ability to accept new instances.\"\"\""},{"line_number":783,"context_line":"        # TODO(Vek): Need to pass context in for access to auth_token"},{"line_number":784,"context_line":"        raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FQeg%3D","line":781,"updated":"2013-10-18 22:50:01.000000000","message":"Why?","commit_id":"62b232af573f89ae036b1058669b8783ed6bc996"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"6fbe60904f3a6b91e3e92ebcf8f03a42d9a4c37e","unresolved":false,"context_lines":[{"line_number":778,"context_line":"        \"\"\""},{"line_number":779,"context_line":"        raise NotImplementedError()"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"    def set_host_enabled(self, host, enabled, **kwargs):"},{"line_number":782,"context_line":"        \"\"\"Sets the specified host\u0027s ability to accept new instances.\"\"\""},{"line_number":783,"context_line":"        # TODO(Vek): Need to pass context in for access to auth_token"},{"line_number":784,"context_line":"        raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FMrg%3D","line":781,"in_reply_to":"AAAATH%2F%2FQeg%3D","updated":"2013-10-21 20:41:30.000000000","message":"Done","commit_id":"62b232af573f89ae036b1058669b8783ed6bc996"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d0be031a0351e48941c09836881f93bf7bc37ee9","unresolved":false,"context_lines":[{"line_number":2598,"context_line":"        status \u003d {\u0027disabled\u0027: bool(enabled),"},{"line_number":2599,"context_line":"                \u0027disabled_reason\u0027: enabled"},{"line_number":2600,"context_line":"                }"},{"line_number":2601,"context_line":"        admin_cnt \u003d nova_context.get_admin_context()"},{"line_number":2602,"context_line":"        service \u003d self._conductor_api.service_get_by_compute_host("},{"line_number":2603,"context_line":"            admin_cnt, CONF.host)"},{"line_number":2604,"context_line":"        self._conductor_api.service_update("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FQeo%3D","line":2601,"updated":"2013-10-18 22:50:01.000000000","message":"I think you should s/admin_cnt/ctx/","commit_id":"62b232af573f89ae036b1058669b8783ed6bc996"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"6fbe60904f3a6b91e3e92ebcf8f03a42d9a4c37e","unresolved":false,"context_lines":[{"line_number":2598,"context_line":"        status \u003d {\u0027disabled\u0027: bool(enabled),"},{"line_number":2599,"context_line":"                \u0027disabled_reason\u0027: enabled"},{"line_number":2600,"context_line":"                }"},{"line_number":2601,"context_line":"        admin_cnt \u003d nova_context.get_admin_context()"},{"line_number":2602,"context_line":"        service \u003d self._conductor_api.service_get_by_compute_host("},{"line_number":2603,"context_line":"            admin_cnt, CONF.host)"},{"line_number":2604,"context_line":"        self._conductor_api.service_update("}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FMzQ%3D","line":2601,"in_reply_to":"AAAATH%2F%2FQeo%3D","updated":"2013-10-21 20:41:30.000000000","message":"Done","commit_id":"62b232af573f89ae036b1058669b8783ed6bc996"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"d0be031a0351e48941c09836881f93bf7bc37ee9","unresolved":false,"context_lines":[{"line_number":2604,"context_line":"        self._conductor_api.service_update("},{"line_number":2605,"context_line":"                admin_cnt,"},{"line_number":2606,"context_line":"                service,"},{"line_number":2607,"context_line":"                status)"},{"line_number":2608,"context_line":""},{"line_number":2609,"context_line":"    def get_host_capabilities(self):"},{"line_number":2610,"context_line":"        \"\"\"Returns an instance of config.LibvirtConfigCaps representing"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FQek%3D","line":2607,"updated":"2013-10-18 22:50:01.000000000","message":"Please use objects here.\n\n service \u003d service_obj.Service.get_by_compute_host(ctx, CONF.host)\n service.status \u003d status\n service.save()","commit_id":"62b232af573f89ae036b1058669b8783ed6bc996"},{"author":{"_account_id":8802,"name":"Vladik Romanovsky","email":"vromanso@redhat.com","username":"vladikr"},"change_message_id":"6fbe60904f3a6b91e3e92ebcf8f03a42d9a4c37e","unresolved":false,"context_lines":[{"line_number":2604,"context_line":"        self._conductor_api.service_update("},{"line_number":2605,"context_line":"                admin_cnt,"},{"line_number":2606,"context_line":"                service,"},{"line_number":2607,"context_line":"                status)"},{"line_number":2608,"context_line":""},{"line_number":2609,"context_line":"    def get_host_capabilities(self):"},{"line_number":2610,"context_line":"        \"\"\"Returns an instance of config.LibvirtConfigCaps representing"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FMdM%3D","line":2607,"in_reply_to":"AAAATH%2F%2FQek%3D","updated":"2013-10-21 20:41:30.000000000","message":"Done.\nThanks, it\u0027s much better.","commit_id":"62b232af573f89ae036b1058669b8783ed6bc996"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"67fd6062166dce09a0795d0a636822a06aa183a3","unresolved":false,"context_lines":[{"line_number":2614,"context_line":"        try:"},{"line_number":2615,"context_line":"            service \u003d service_obj.Service.get_by_compute_host(ctx, CONF.host)"},{"line_number":2616,"context_line":""},{"line_number":2617,"context_line":"            if service[\u0027disabled\u0027] !\u003d disable_service:"},{"line_number":2618,"context_line":"                service.update(status)"},{"line_number":2619,"context_line":"                service.save()"},{"line_number":2620,"context_line":"                LOG.debug(_(\u0027Updating compute service status to: %s\u0027),"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2F9E4%3D","line":2617,"updated":"2013-10-24 17:03:51.000000000","message":"This should be:\n\n  service.disabled\n\ninstead of:\n\n  service[\u0027disabled\u0027]","commit_id":"622f46c61f755d36144ecac118f9a0b1234c794b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"67fd6062166dce09a0795d0a636822a06aa183a3","unresolved":false,"context_lines":[{"line_number":2615,"context_line":"            service \u003d service_obj.Service.get_by_compute_host(ctx, CONF.host)"},{"line_number":2616,"context_line":""},{"line_number":2617,"context_line":"            if service[\u0027disabled\u0027] !\u003d disable_service:"},{"line_number":2618,"context_line":"                service.update(status)"},{"line_number":2619,"context_line":"                service.save()"},{"line_number":2620,"context_line":"                LOG.debug(_(\u0027Updating compute service status to: %s\u0027),"},{"line_number":2621,"context_line":"                             status_name[disable_service])"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAATn%2F%2F9E0%3D","line":2618,"updated":"2013-10-24 17:03:51.000000000","message":"This is technically okay, but since the status is not used anywhere else, I\u0027d prefer just removing the dict above and setting these on the object itself:\n\n service.disabled \u003d disable_service\n service.disabled_reason \u003d disable_reason\n\nAs it is more clear what is getting changed here.","commit_id":"622f46c61f755d36144ecac118f9a0b1234c794b"}]}