)]}'
{"nova/compute/instance_list.py":[{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"caa091bb4a854e6ebebdd990b393029417eb6308","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    # handle this anywhere yet anyway."},{"line_number":218,"context_line":"    results \u003d context.scatter_gather_all_cells(ctx, do_query)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    res_values \u003d [v for v in results.values() if v not in ("},{"line_number":221,"context_line":"        context.did_not_respond_sentinel,"},{"line_number":222,"context_line":"        context.raised_exception_sentinel)]"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    # If a limit was provided, it was passed to the per-cell query routines."},{"line_number":225,"context_line":"    # That means we have NUM_CELLS * limit items across results. So, we"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_ff221fa4","line":222,"range":{"start_line":220,"start_character":0,"end_line":222,"end_character":43},"updated":"2017-11-23 02:30:44.000000000","message":"We just skip the exception to avoid the iterable error, same as the \n quota stuff:\n\nhttps://github.com/openstack/nova/blob/e9ce5c4c95edc869ab2cf82ca0733a2821c384ad/nova/quota.py#L1865","commit_id":"d5aafa2bbd3e2b5894302b0de17d3359900cdfbe"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"de1025f5a073122b5844224ccca5d5534a8c757e","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        return (InstanceWrapper(sort_ctx, inst) for inst in"},{"line_number":212,"context_line":"                itertools.chain(local_marker_prefix, main_query_result))"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    # FIXME(danms): If we raise or timeout on a cell we need to handle"},{"line_number":215,"context_line":"    # that here gracefully. The below routine will provide sentinels"},{"line_number":216,"context_line":"    # to indicate that, which will crash the merge below, but we don\u0027t"},{"line_number":217,"context_line":"    # handle this anywhere yet anyway."},{"line_number":218,"context_line":"    results \u003d context.scatter_gather_all_cells(ctx, do_query)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    res_values \u003d [v for v in results.values() if v not in ("}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_6db39e4e","line":217,"range":{"start_line":214,"start_character":0,"end_line":217,"end_character":38},"updated":"2017-11-24 15:15:58.000000000","message":"This should be removed now","commit_id":"f52f33b4cb7dc3a8ae375b0f3c5abb65cf3f5855"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"a347dcb9878558989455cecbf1c84ae36450a3a9","unresolved":false,"context_lines":[{"line_number":211,"context_line":"        return (InstanceWrapper(sort_ctx, inst) for inst in"},{"line_number":212,"context_line":"                itertools.chain(local_marker_prefix, main_query_result))"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"    # FIXME(danms): If we raise or timeout on a cell we need to handle"},{"line_number":215,"context_line":"    # that here gracefully. The below routine will provide sentinels"},{"line_number":216,"context_line":"    # to indicate that, which will crash the merge below, but we don\u0027t"},{"line_number":217,"context_line":"    # handle this anywhere yet anyway."},{"line_number":218,"context_line":"    results \u003d context.scatter_gather_all_cells(ctx, do_query)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    res_values \u003d [v for v in results.values() if v not in ("}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_5b0c46ec","line":217,"range":{"start_line":214,"start_character":0,"end_line":217,"end_character":38},"in_reply_to":"ff82abbf_6db39e4e","updated":"2017-11-27 02:52:54.000000000","message":"Done","commit_id":"f52f33b4cb7dc3a8ae375b0f3c5abb65cf3f5855"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"de1025f5a073122b5844224ccca5d5534a8c757e","unresolved":false,"context_lines":[{"line_number":215,"context_line":"    # that here gracefully. The below routine will provide sentinels"},{"line_number":216,"context_line":"    # to indicate that, which will crash the merge below, but we don\u0027t"},{"line_number":217,"context_line":"    # handle this anywhere yet anyway."},{"line_number":218,"context_line":"    results \u003d context.scatter_gather_all_cells(ctx, do_query)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    res_values \u003d [v for v in results.values() if v not in ("},{"line_number":221,"context_line":"        context.did_not_respond_sentinel,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_cdb3ca09","line":218,"range":{"start_line":218,"start_character":60,"end_line":218,"end_character":61},"updated":"2017-11-24 15:15:58.000000000","message":"Might as well convert to values here:\n\n  results \u003d ...(ctx, do_query).values()","commit_id":"f52f33b4cb7dc3a8ae375b0f3c5abb65cf3f5855"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"a347dcb9878558989455cecbf1c84ae36450a3a9","unresolved":false,"context_lines":[{"line_number":215,"context_line":"    # that here gracefully. The below routine will provide sentinels"},{"line_number":216,"context_line":"    # to indicate that, which will crash the merge below, but we don\u0027t"},{"line_number":217,"context_line":"    # handle this anywhere yet anyway."},{"line_number":218,"context_line":"    results \u003d context.scatter_gather_all_cells(ctx, do_query)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    res_values \u003d [v for v in results.values() if v not in ("},{"line_number":221,"context_line":"        context.did_not_respond_sentinel,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_7b6b4a84","line":218,"range":{"start_line":218,"start_character":60,"end_line":218,"end_character":61},"in_reply_to":"ff82abbf_cdb3ca09","updated":"2017-11-27 02:52:54.000000000","message":"OK. Thanks for review, I will update soon. : )","commit_id":"f52f33b4cb7dc3a8ae375b0f3c5abb65cf3f5855"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"de1025f5a073122b5844224ccca5d5534a8c757e","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    # handle this anywhere yet anyway."},{"line_number":218,"context_line":"    results \u003d context.scatter_gather_all_cells(ctx, do_query)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    res_values \u003d [v for v in results.values() if v not in ("},{"line_number":221,"context_line":"        context.did_not_respond_sentinel,"},{"line_number":222,"context_line":"        context.raised_exception_sentinel)]"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_8dd14226","line":220,"range":{"start_line":220,"start_character":4,"end_line":220,"end_character":14},"updated":"2017-11-24 15:15:58.000000000","message":"Just call this results","commit_id":"f52f33b4cb7dc3a8ae375b0f3c5abb65cf3f5855"},{"author":{"_account_id":20722,"name":"Yikun Jiang","email":"yikunkero@gmail.com","username":"yikunkero"},"change_message_id":"a347dcb9878558989455cecbf1c84ae36450a3a9","unresolved":false,"context_lines":[{"line_number":217,"context_line":"    # handle this anywhere yet anyway."},{"line_number":218,"context_line":"    results \u003d context.scatter_gather_all_cells(ctx, do_query)"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"    res_values \u003d [v for v in results.values() if v not in ("},{"line_number":221,"context_line":"        context.did_not_respond_sentinel,"},{"line_number":222,"context_line":"        context.raised_exception_sentinel)]"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_3b0702cd","line":220,"range":{"start_line":220,"start_character":4,"end_line":220,"end_character":14},"in_reply_to":"ff82abbf_8dd14226","updated":"2017-11-27 02:52:54.000000000","message":"Done","commit_id":"f52f33b4cb7dc3a8ae375b0f3c5abb65cf3f5855"}]}