)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"2654b16710dc9c39a5cc47462d244a27cb9c6f20","unresolved":false,"context_lines":[{"line_number":10,"context_line":"list the resources for all tenants/projects."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Checking of this query param in code is different in different APIs."},{"line_number":13,"context_line":"- GET /servers API checks the value of \u0027all_tenants\u0027 as bool as string."},{"line_number":14,"context_line":"- other APIs just checks the present of it in req,"},{"line_number":15,"context_line":"  like GET /os-server-groups, /os-fping"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"df87a7cf_37984273","line":13,"range":{"start_line":13,"start_character":26,"end_line":13,"end_character":71},"updated":"2017-12-11 08:01:30.000000000","message":"\u003e GET /servers API checks the value of \u0027all_tenants\u0027 as bool as string.\n\nIt is \u0027True\u0027 even if the value of \u0027all_tenants\u0027 is not specified.(only \u0027all_tenants\u0027 parameter is specified.)\n\nhttps://github.com/openstack/nova/blob/3cec0cb584ac82a5a57400b94d25f8ac73bb0950/nova/api/openstack/compute/servers.py#L265\nhttps://github.com/openstack/nova/blob/3cec0cb584ac82a5a57400b94d25f8ac73bb0950/nova/api/openstack/common.py#L530","commit_id":"dfda014f1e657fb438bef63d0bd1307cbc978c20"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"2654b16710dc9c39a5cc47462d244a27cb9c6f20","unresolved":false,"context_lines":[{"line_number":10,"context_line":"list the resources for all tenants/projects."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Checking of this query param in code is different in different APIs."},{"line_number":13,"context_line":"- GET /servers API checks the value of \u0027all_tenants\u0027 as bool as string."},{"line_number":14,"context_line":"- other APIs just checks the present of it in req,"},{"line_number":15,"context_line":"  like GET /os-server-groups, /os-fping"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"df87a7cf_77924a59","line":13,"range":{"start_line":13,"start_character":1,"end_line":13,"end_character":14},"updated":"2017-12-11 08:01:30.000000000","message":"GET /servers and GET /servers/detail","commit_id":"dfda014f1e657fb438bef63d0bd1307cbc978c20"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"205f857ef73357a6f6d614da9712c011ca6589f1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"list the resources for all tenants/projects."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Checking of this query param in code is different in different APIs."},{"line_number":13,"context_line":"- GET /servers API checks the value of \u0027all_tenants\u0027 as bool as string."},{"line_number":14,"context_line":"- other APIs just checks the present of it in req,"},{"line_number":15,"context_line":"  like GET /os-server-groups, /os-fping"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7f96bb07_1f405556","line":13,"range":{"start_line":13,"start_character":1,"end_line":13,"end_character":14},"in_reply_to":"df87a7cf_77924a59","updated":"2018-01-12 08:13:35.000000000","message":"thanks , done","commit_id":"dfda014f1e657fb438bef63d0bd1307cbc978c20"}],"api-ref/source/os-fping.inc":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"9b693f8999ee5cdcb78bdacb37369943b8b335ef","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"::"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  GET /os-fping?all_tenants\u003d1"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Specify the ``include`` and ``exclude`` query parameters to filter the results. For example:"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"ff82abbf_db493631","line":26,"range":{"start_line":26,"start_character":16,"end_line":26,"end_character":29},"updated":"2017-11-27 02:51:29.000000000","message":"this should be updated as well?","commit_id":"b37ba4d046c485f8c691c12cfe2f4db6df3a697d"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f4dc37fd93e6289836f6e07e3720617f7282e6ac","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"::"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"  GET /os-fping?all_tenants\u003d1"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Specify the ``include`` and ``exclude`` query parameters to filter the results. For example:"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"ff82abbf_17de716c","line":26,"range":{"start_line":26,"start_character":16,"end_line":26,"end_character":29},"in_reply_to":"ff82abbf_db493631","updated":"2017-11-28 05:18:42.000000000","message":"initially i thought to keep it with value but value here also convey that this API care about value and if they pass 0 or False then, all_tenants are considered as false which is not true.  \n\nI think adding a clear statement about \"API not care about value\" might be helpful.","commit_id":"b37ba4d046c485f8c691c12cfe2f4db6df3a697d"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"9b693f8999ee5cdcb78bdacb37369943b8b335ef","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"::"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  GET /os-fping?all_tenants\u003d1\u0026include\u003duuid1,uuid2\u0026exclude\u003duuid3,uuid4"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"Policy defaults enable only users with the administrative role or the"},{"line_number":35,"context_line":"owner of the server to perform this operation. Cloud providers can"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"ff82abbf_fb575ac9","line":32,"range":{"start_line":32,"start_character":27,"end_line":32,"end_character":28},"updated":"2017-11-27 02:51:29.000000000","message":"ditto","commit_id":"b37ba4d046c485f8c691c12cfe2f4db6df3a697d"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"25ebfcca9a861d6936760102b328f83927c4e832","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Runs the fping utility to ping instances and reports which instances are alive."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Specify the ``all_tenants`` query parameter to ping instances for all tenants. For example:"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"::"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":5,"id":"7f96bb07_c09eacb7","line":22,"updated":"2018-01-19 19:53:43.000000000","message":"This is not a strong opinion, just a kind of question.\n\nSince novaclient code, the client needs to pass some value always as all_tenants/projects due to current implementation of novaclient/utils.py:\n\n 455 def prepare_query_string(params):\n 456     \"\"\"Convert dict params to query string\"\"\"\n 457     # Transform the dict to a sequence of two-element tuples in fixed\n 458     # order, then the encoded string will be consistent in Python 2\u00263.\n 459     if not params:\n 460         return \u0027\u0027\n 461     params \u003d sorted(params.items(), key\u003dlambda x: x[0])\n 462     return \u0027?%s\u0027 % parse.urlencode(params) if params else \u0027\u0027\n\nIn addition, current tempest service client doesn\u0027t support the argument like\n\n 53     def list_server_groups(self):\n 54         \"\"\"List the server-groups.\"\"\"\n 55         resp, body \u003d self.get(\"os-server-groups\")\n 56         body \u003d json.loads(body)\n 57         schema \u003d self.get_schema(self.schema_versions_info)\n 58         self.validate_response(schema.list_server_groups, resp, body)\n 59         return rest_client.ResponseBody(resp, body)\n\nAnd as you know, tempest is using urllib.urlencode() for such arguments and the urlencode() requires key-value combinations(maps or tuples) to convert to key\u003dvalue sequence with \"\u0026\".\nSo I feel this examples seem uncommon.\nHow about just writing \"The value is not checked\" as current parameters.yaml without removing values?","commit_id":"859c3cf3c660158fbb92016cedbb6fa5c89916a9"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"17c0bb34d842e442117404b632a1817824b4493c","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Runs the fping utility to ping instances and reports which instances are alive."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Specify the ``all_tenants`` query parameter to ping instances for all tenants. For example:"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"::"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":5,"id":"7f96bb07_85498833","line":22,"in_reply_to":"7f96bb07_c09eacb7","updated":"2018-01-21 07:32:08.000000000","message":"Done","commit_id":"859c3cf3c660158fbb92016cedbb6fa5c89916a9"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"2654b16710dc9c39a5cc47462d244a27cb9c6f20","unresolved":false,"context_lines":[{"line_number":384,"context_line":"  type: string"},{"line_number":385,"context_line":"all_tenants_query:"},{"line_number":386,"context_line":"  description: |"},{"line_number":387,"context_line":"    Specify the ``all_tenants`` query parameter to list all instances"},{"line_number":388,"context_line":"    for all projects. By default this is only allowed by admin users."},{"line_number":389,"context_line":"  in: query"},{"line_number":390,"context_line":"  required: false"},{"line_number":391,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"df87a7cf_f7309a58","line":388,"range":{"start_line":387,"start_character":0,"end_line":388,"end_character":69},"updated":"2017-12-11 08:01:30.000000000","message":"IMO, Needs more description.\nA value of `all_tenants`` need not be specified. If it is specified, it must be \u0027boolean\u0027 (the following value).\n\nhttps://github.com/openstack/oslo.utils/blob/58fb709f58bd031c5114d9b6fe2e0926175b87b6/oslo_utils/strutils.py#L49-L50","commit_id":"dfda014f1e657fb438bef63d0bd1307cbc978c20"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"205f857ef73357a6f6d614da9712c011ca6589f1","unresolved":false,"context_lines":[{"line_number":384,"context_line":"  type: string"},{"line_number":385,"context_line":"all_tenants_query:"},{"line_number":386,"context_line":"  description: |"},{"line_number":387,"context_line":"    Specify the ``all_tenants`` query parameter to list all instances"},{"line_number":388,"context_line":"    for all projects. By default this is only allowed by admin users."},{"line_number":389,"context_line":"  in: query"},{"line_number":390,"context_line":"  required: false"},{"line_number":391,"context_line":"  type: string"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"7f96bb07_bf24c1c7","line":388,"range":{"start_line":387,"start_character":0,"end_line":388,"end_character":69},"in_reply_to":"df87a7cf_f7309a58","updated":"2018-01-12 08:13:35.000000000","message":"Done","commit_id":"dfda014f1e657fb438bef63d0bd1307cbc978c20"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"9c842f2c426aea54a1f4288857d4c0a29d42ec04","unresolved":false,"context_lines":[{"line_number":363,"context_line":"  description: |"},{"line_number":364,"context_line":"    Administrator only. Lists server groups for all projects. For example:"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"      ``GET /os-server-groups?all_projects\u003dTrue``"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    If you specify a tenant ID for a non-administrative user with this query parameter,"},{"line_number":369,"context_line":"    the call lists all server groups for the tenant, or project, rather than for"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7f96bb07_fc4249ab","side":"PARENT","line":366,"range":{"start_line":366,"start_character":42,"end_line":366,"end_character":47},"updated":"2018-01-22 18:57:30.000000000","message":"As I mentioned before, it is not necessary to remove this value.","commit_id":"6ee125ca81883719232362027d9879af523e763c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f78f8c8c694c018518537c6a57a41da8a42140eb","unresolved":false,"context_lines":[{"line_number":363,"context_line":"  description: |"},{"line_number":364,"context_line":"    Administrator only. Lists server groups for all projects. For example:"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"      ``GET /os-server-groups?all_projects\u003dTrue``"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    If you specify a tenant ID for a non-administrative user with this query parameter,"},{"line_number":369,"context_line":"    the call lists all server groups for the tenant, or project, rather than for"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7f96bb07_4c21404d","side":"PARENT","line":366,"range":{"start_line":366,"start_character":42,"end_line":366,"end_character":47},"in_reply_to":"7f96bb07_fc4249ab","updated":"2018-01-23 01:54:15.000000000","message":"Done","commit_id":"6ee125ca81883719232362027d9879af523e763c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"9c842f2c426aea54a1f4288857d4c0a29d42ec04","unresolved":false,"context_lines":[{"line_number":370,"context_line":"    all projects."},{"line_number":371,"context_line":"  in: query"},{"line_number":372,"context_line":"  required: false"},{"line_number":373,"context_line":"  type: boolean"},{"line_number":374,"context_line":"all_tenants:"},{"line_number":375,"context_line":"  description: |"},{"line_number":376,"context_line":"    Specify the ``all_tenants\u003d1`` query parameter to ping instances"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7f96bb07_7c1079a9","side":"PARENT","line":373,"range":{"start_line":373,"start_character":8,"end_line":373,"end_character":15},"updated":"2018-01-22 18:57:30.000000000","message":"ditto","commit_id":"6ee125ca81883719232362027d9879af523e763c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f78f8c8c694c018518537c6a57a41da8a42140eb","unresolved":false,"context_lines":[{"line_number":370,"context_line":"    all projects."},{"line_number":371,"context_line":"  in: query"},{"line_number":372,"context_line":"  required: false"},{"line_number":373,"context_line":"  type: boolean"},{"line_number":374,"context_line":"all_tenants:"},{"line_number":375,"context_line":"  description: |"},{"line_number":376,"context_line":"    Specify the ``all_tenants\u003d1`` query parameter to ping instances"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7f96bb07_ecd5ac1c","side":"PARENT","line":373,"range":{"start_line":373,"start_character":8,"end_line":373,"end_character":15},"in_reply_to":"7f96bb07_7c1079a9","updated":"2018-01-23 01:54:15.000000000","message":"actually that is not needed to be boolean as value is not checked. I made this string as query value is always string.","commit_id":"6ee125ca81883719232362027d9879af523e763c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"9c842f2c426aea54a1f4288857d4c0a29d42ec04","unresolved":false,"context_lines":[{"line_number":373,"context_line":"  type: boolean"},{"line_number":374,"context_line":"all_tenants:"},{"line_number":375,"context_line":"  description: |"},{"line_number":376,"context_line":"    Specify the ``all_tenants\u003d1`` query parameter to ping instances"},{"line_number":377,"context_line":"    for all tenants. By default this is only allowed by admin users."},{"line_number":378,"context_line":"  in: query"},{"line_number":379,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7f96bb07_7c85d9ce","side":"PARENT","line":376,"range":{"start_line":376,"start_character":29,"end_line":376,"end_character":31},"updated":"2018-01-22 18:57:30.000000000","message":"ditto","commit_id":"6ee125ca81883719232362027d9879af523e763c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f78f8c8c694c018518537c6a57a41da8a42140eb","unresolved":false,"context_lines":[{"line_number":373,"context_line":"  type: boolean"},{"line_number":374,"context_line":"all_tenants:"},{"line_number":375,"context_line":"  description: |"},{"line_number":376,"context_line":"    Specify the ``all_tenants\u003d1`` query parameter to ping instances"},{"line_number":377,"context_line":"    for all tenants. By default this is only allowed by admin users."},{"line_number":378,"context_line":"  in: query"},{"line_number":379,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7f96bb07_6ce19cfc","side":"PARENT","line":376,"range":{"start_line":376,"start_character":29,"end_line":376,"end_character":31},"in_reply_to":"7f96bb07_7c85d9ce","updated":"2018-01-23 01:54:15.000000000","message":"This is not example, i think description is ok without value otherwise it looks like it is mandatory to pass \u0027all_tenants\u003d1\u0027","commit_id":"6ee125ca81883719232362027d9879af523e763c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"9c842f2c426aea54a1f4288857d4c0a29d42ec04","unresolved":false,"context_lines":[{"line_number":377,"context_line":"    for all tenants. By default this is only allowed by admin users."},{"line_number":378,"context_line":"  in: query"},{"line_number":379,"context_line":"  required: false"},{"line_number":380,"context_line":"  type: integer"},{"line_number":381,"context_line":"all_tenants_query:"},{"line_number":382,"context_line":"  description: |"},{"line_number":383,"context_line":"    Specify the ``all_tenants\u003d1`` query parameter to list all instances"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7f96bb07_3c675154","side":"PARENT","line":380,"range":{"start_line":380,"start_character":8,"end_line":380,"end_character":15},"updated":"2018-01-22 18:57:30.000000000","message":"ditto","commit_id":"6ee125ca81883719232362027d9879af523e763c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f78f8c8c694c018518537c6a57a41da8a42140eb","unresolved":false,"context_lines":[{"line_number":377,"context_line":"    for all tenants. By default this is only allowed by admin users."},{"line_number":378,"context_line":"  in: query"},{"line_number":379,"context_line":"  required: false"},{"line_number":380,"context_line":"  type: integer"},{"line_number":381,"context_line":"all_tenants_query:"},{"line_number":382,"context_line":"  description: |"},{"line_number":383,"context_line":"    Specify the ``all_tenants\u003d1`` query parameter to list all instances"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7f96bb07_0cf018c9","side":"PARENT","line":380,"range":{"start_line":380,"start_character":8,"end_line":380,"end_character":15},"in_reply_to":"7f96bb07_3c675154","updated":"2018-01-23 01:54:15.000000000","message":"ditto","commit_id":"6ee125ca81883719232362027d9879af523e763c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"9c842f2c426aea54a1f4288857d4c0a29d42ec04","unresolved":false,"context_lines":[{"line_number":380,"context_line":"  type: integer"},{"line_number":381,"context_line":"all_tenants_query:"},{"line_number":382,"context_line":"  description: |"},{"line_number":383,"context_line":"    Specify the ``all_tenants\u003d1`` query parameter to list all instances"},{"line_number":384,"context_line":"    for all projects. By default this is only allowed by admin users."},{"line_number":385,"context_line":"  in: query"},{"line_number":386,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7f96bb07_fc70090b","side":"PARENT","line":383,"range":{"start_line":383,"start_character":29,"end_line":383,"end_character":31},"updated":"2018-01-22 18:57:30.000000000","message":"ditto","commit_id":"6ee125ca81883719232362027d9879af523e763c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f78f8c8c694c018518537c6a57a41da8a42140eb","unresolved":false,"context_lines":[{"line_number":380,"context_line":"  type: integer"},{"line_number":381,"context_line":"all_tenants_query:"},{"line_number":382,"context_line":"  description: |"},{"line_number":383,"context_line":"    Specify the ``all_tenants\u003d1`` query parameter to list all instances"},{"line_number":384,"context_line":"    for all projects. By default this is only allowed by admin users."},{"line_number":385,"context_line":"  in: query"},{"line_number":386,"context_line":"  required: false"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7f96bb07_cca0f0a8","side":"PARENT","line":383,"range":{"start_line":383,"start_character":29,"end_line":383,"end_character":31},"in_reply_to":"7f96bb07_fc70090b","updated":"2018-01-23 01:54:15.000000000","message":"ditto","commit_id":"6ee125ca81883719232362027d9879af523e763c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"9c842f2c426aea54a1f4288857d4c0a29d42ec04","unresolved":false,"context_lines":[{"line_number":384,"context_line":"    for all projects. By default this is only allowed by admin users."},{"line_number":385,"context_line":"  in: query"},{"line_number":386,"context_line":"  required: false"},{"line_number":387,"context_line":"  type: integer"},{"line_number":388,"context_line":"all_tenants_sec_grp_query:"},{"line_number":389,"context_line":"  description: |"},{"line_number":390,"context_line":"    Specify the ``all_tenants`` query parameter to list all security"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7f96bb07_bc64c14a","side":"PARENT","line":387,"range":{"start_line":387,"start_character":8,"end_line":387,"end_character":15},"updated":"2018-01-22 18:57:30.000000000","message":"ditto","commit_id":"6ee125ca81883719232362027d9879af523e763c"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"f78f8c8c694c018518537c6a57a41da8a42140eb","unresolved":false,"context_lines":[{"line_number":384,"context_line":"    for all projects. By default this is only allowed by admin users."},{"line_number":385,"context_line":"  in: query"},{"line_number":386,"context_line":"  required: false"},{"line_number":387,"context_line":"  type: integer"},{"line_number":388,"context_line":"all_tenants_sec_grp_query:"},{"line_number":389,"context_line":"  description: |"},{"line_number":390,"context_line":"    Specify the ``all_tenants`` query parameter to list all security"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"7f96bb07_6ccafc6e","side":"PARENT","line":387,"range":{"start_line":387,"start_character":8,"end_line":387,"end_character":15},"in_reply_to":"7f96bb07_bc64c14a","updated":"2018-01-23 01:54:15.000000000","message":"ditto","commit_id":"6ee125ca81883719232362027d9879af523e763c"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"f69040afd00254bd52961909386889bc255aac61","unresolved":false,"context_lines":[{"line_number":390,"context_line":"    By default this is only allowed by admin users."},{"line_number":391,"context_line":"  in: query"},{"line_number":392,"context_line":"  required: false"},{"line_number":393,"context_line":"  type: string"},{"line_number":394,"context_line":"all_tenants_sec_grp_query:"},{"line_number":395,"context_line":"  description: |"},{"line_number":396,"context_line":"    Specify the ``all_tenants`` query parameter to list all security"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_870e41e3","line":393,"updated":"2018-01-23 02:27:31.000000000","message":"Why do you change here to string even if the above change says\n\n If it is specified, it must be \u0027boolean\u0027.","commit_id":"bc8fdbead169eb37a019cbea128409d0149a22e3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"057d8418722ba459c591847587d6085f14ab5056","unresolved":false,"context_lines":[{"line_number":390,"context_line":"    By default this is only allowed by admin users."},{"line_number":391,"context_line":"  in: query"},{"line_number":392,"context_line":"  required: false"},{"line_number":393,"context_line":"  type: string"},{"line_number":394,"context_line":"all_tenants_sec_grp_query:"},{"line_number":395,"context_line":"  description: |"},{"line_number":396,"context_line":"    Specify the ``all_tenants`` query parameter to list all security"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_071b111b","line":393,"in_reply_to":"7f96bb07_870e41e3","updated":"2018-01-23 02:29:43.000000000","message":"sorry, this is valid case of boolean for server API. Done","commit_id":"bc8fdbead169eb37a019cbea128409d0149a22e3"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"5c1a7f47d807a7a8f6e159e6be7c727af501dc32","unresolved":false,"context_lines":[{"line_number":373,"context_line":"  in: query"},{"line_number":374,"context_line":"  required: false"},{"line_number":375,"context_line":"  type: string"},{"line_number":376,"context_line":"all_tenants:"},{"line_number":377,"context_line":"  description: |"},{"line_number":378,"context_line":"    Specify the ``all_tenants`` query parameter to ping instances"},{"line_number":379,"context_line":"    for all tenants. By default this is only allowed by admin users."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f93b717_aba027a7","line":376,"range":{"start_line":376,"start_character":0,"end_line":376,"end_character":11},"updated":"2018-01-25 01:32:53.000000000","message":"nit \u0026 out of scope: all_tenants should be renamed to all_tenants_ping or something because this also is for query and it seems easy to make confusions with the following all_tenants_query. But this point should be out of scope from this patch for keeping the scope simple.\n\nI am happy if seeing another patch to fix it.","commit_id":"6a75cb2ef9b423b03c0be7ddc74dc1a34cd5a4e3"}]}