)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"f9944b87e843ab35d29f49a01a1644672bfcd62f","unresolved":false,"context_lines":[{"line_number":11,"context_line":"scheduler by making calls to select_destinations(). Since the latter call"},{"line_number":12,"context_line":"basically returns the same result, and because live migration is the only"},{"line_number":13,"context_line":"task using select_hosts(), changing to select_destionations() means the"},{"line_number":14,"context_line":"scheduler would no longer need the select_hosts() call."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I984ccc2317184ba8f6b292c91717f52a81cf73d7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAATn%2F%2BiT0%3D","line":14,"updated":"2013-11-24 23:33:07.000000000","message":"Does this related to a bp or bug? It is better that we either file a bug or a bp to trace this.","commit_id":"6c7b61af152c4c0b9180d615f2f52806190b5435"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"c70ebaf422bd6fbb9d8e44d4e0f76ddbcd9a8b8a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"scheduler by making calls to select_destinations(). Since the latter call"},{"line_number":12,"context_line":"basically returns the same result, and because live migration is the only"},{"line_number":13,"context_line":"task using select_hosts(), changing to select_destionations() means the"},{"line_number":14,"context_line":"scheduler would no longer need the select_hosts() call."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I984ccc2317184ba8f6b292c91717f52a81cf73d7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"AAAATn%2F%2Bg6o%3D","line":14,"in_reply_to":"AAAATn%2F%2BiT0%3D","updated":"2013-11-25 09:39:17.000000000","message":"OK, so this is the second time this review get a -1 for not having a related blueprint.\n\nTo me, this is tiny refactoring that reuses existing code, paving the way for cleaning up some duplication of code and I don\u0027t think this change needs a blueprint. It seams Russel Bryant is of the same opinion, since the blueprint I created in response to the first negative review was later removed by him, see his comment in https://blueprints.launchpad.net/nova/+spec/deprecate-scheduler-select-hosts.","commit_id":"6c7b61af152c4c0b9180d615f2f52806190b5435"}],"nova/conductor/tasks/live_migrate.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"bf64e96106de834a7c8aef893d0002a0bb884db2","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        while host is None:"},{"line_number":161,"context_line":"            self._check_not_over_max_retries(attempted_hosts)"},{"line_number":162,"context_line":"            filter_properties \u003d {\u0027ignore_hosts\u0027: attempted_hosts}"},{"line_number":163,"context_line":"            host \u003d self.scheduler_rpcapi.select_destinations(self.context,"},{"line_number":164,"context_line":"                            request_spec, filter_properties)[0][\u0027host\u0027]"},{"line_number":165,"context_line":"            try:"},{"line_number":166,"context_line":"                self._check_compatible_with_source_hypervisor(host)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FWTs%3D","line":163,"updated":"2013-10-17 12:46:49.000000000","message":"it is not clear why the select_destinations is called in the loop. this method returns a lost of hosts. why not get the lists of hosts and then loop through the hosts?","commit_id":"6213626b8b8ff94626c7c10da4233d27b0e7bab5"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"c3c2d3c91331b857333ad2daa8b9866aa92868c7","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        while host is None:"},{"line_number":161,"context_line":"            self._check_not_over_max_retries(attempted_hosts)"},{"line_number":162,"context_line":"            filter_properties \u003d {\u0027ignore_hosts\u0027: attempted_hosts}"},{"line_number":163,"context_line":"            host \u003d self.scheduler_rpcapi.select_destinations(self.context,"},{"line_number":164,"context_line":"                            request_spec, filter_properties)[0][\u0027host\u0027]"},{"line_number":165,"context_line":"            try:"},{"line_number":166,"context_line":"                self._check_compatible_with_source_hypervisor(host)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2BiT8%3D","line":163,"in_reply_to":"AAAATH%2F%2FWQM%3D","updated":"2013-11-24 23:30:56.000000000","message":"It seems filter scheduler always assume the first host is the best","commit_id":"6213626b8b8ff94626c7c10da4233d27b0e7bab5"},{"author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"change_message_id":"92bc62071cbfcd4c369e9ea556591b31e045c03f","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        while host is None:"},{"line_number":161,"context_line":"            self._check_not_over_max_retries(attempted_hosts)"},{"line_number":162,"context_line":"            filter_properties \u003d {\u0027ignore_hosts\u0027: attempted_hosts}"},{"line_number":163,"context_line":"            host \u003d self.scheduler_rpcapi.select_destinations(self.context,"},{"line_number":164,"context_line":"                            request_spec, filter_properties)[0][\u0027host\u0027]"},{"line_number":165,"context_line":"            try:"},{"line_number":166,"context_line":"                self._check_compatible_with_source_hypervisor(host)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FWQM%3D","line":163,"in_reply_to":"AAAATH%2F%2FWTs%3D","updated":"2013-10-17 13:02:02.000000000","message":"So, not really related to this change but\n\nrequest_spec only contains one instance_uuid since we are only scheduling one host, therefore the result from calling either select_hosts() or select_destinations() is a list containing only one host.","commit_id":"6213626b8b8ff94626c7c10da4233d27b0e7bab5"}]}