)]}'
{"nova/network/base_api.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ef3a53f84e51ba52b32a2f6b8f8e9ad645da8518","unresolved":false,"context_lines":[{"line_number":365,"context_line":"        \"\"\""},{"line_number":366,"context_line":"        pass"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    def supports_port_binding_extension(self, context):"},{"line_number":369,"context_line":"        \"\"\"Checks to see if the networking API supports the binding-extended"},{"line_number":370,"context_line":"        ports API extension."},{"line_number":371,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_4ca535a1","line":368,"updated":"2017-11-28 22:41:41.000000000","message":"I think conductor will call this to see if we should even attempt to create a destination host port binding during live migration.","commit_id":"9f78223c8b5672e2d71c19585b034d7858607ea0"},{"author":{"_account_id":11604,"name":"sean mooney","email":"smooney@redhat.com","username":"sean-k-mooney"},"change_message_id":"32fe481cb81997d322fc1056fbe578d138290a5d","unresolved":false,"context_lines":[{"line_number":365,"context_line":"        \"\"\""},{"line_number":366,"context_line":"        pass"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"    def supports_port_binding_extension(self, context):"},{"line_number":369,"context_line":"        \"\"\"Checks to see if the networking API supports the binding-extended"},{"line_number":370,"context_line":"        ports API extension."},{"line_number":371,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ff82abbf_e9d2d7ff","line":368,"in_reply_to":"ff82abbf_4ca535a1","updated":"2017-11-30 00:29:39.000000000","message":"yes it would call it on line 215\nhttps://review.openstack.org/#/c/522537/1/nova/conductor/tasks/live_migrate.py","commit_id":"9f78223c8b5672e2d71c19585b034d7858607ea0"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"418960fb5cd0cbbaeebacb521063789105300e36","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    def has_substr_port_filtering_extension(self, context):"},{"line_number":372,"context_line":"        return False"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    def supports_port_binding_extension(self, context):"},{"line_number":375,"context_line":"        \"\"\"Checks to see if the networking API supports the binding-extended"},{"line_number":376,"context_line":"        ports API extension."},{"line_number":377,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_d105ff7b","line":374,"updated":"2018-03-26 11:13:09.000000000","message":"You decided to change the pattern we already have \"has_...()\" I prefer your, just that at some point we should think about to make all coherent.\n\n  supports_port_filtering_extension()\n  supports_qos_queue_extension()\n  ....","commit_id":"f1ddf97bd91c0b1ee9a995741f195a9aa6a46a2c"}],"nova/network/neutronv2/api.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"31dae27d3d895e6abd5b3576aeaf07da8d7181ba","unresolved":false,"context_lines":[{"line_number":1121,"context_line":"        self._refresh_neutron_extensions_cache(context)"},{"line_number":1122,"context_line":"        return constants.SUBSTR_PORT_FILTERING in self.extensions"},{"line_number":1123,"context_line":""},{"line_number":1124,"context_line":"    def supports_port_binding_extension(self, context):"},{"line_number":1125,"context_line":"        \"\"\"This is a simple check to see if the neutron \"binding-extended\""},{"line_number":1126,"context_line":"        extension exists and is enabled."},{"line_number":1127,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_9721a550","line":1124,"updated":"2018-03-26 23:27:32.000000000","message":"No test needed for this?\n\n[Later] Guess not.  No tests for any of the others.  Then again, you\u0027re already breaking with precedent by including this glorious docstring...","commit_id":"f1ddf97bd91c0b1ee9a995741f195a9aa6a46a2c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"85b5744298ce13cc31d8d022f7134dd14557ef08","unresolved":false,"context_lines":[{"line_number":1121,"context_line":"        self._refresh_neutron_extensions_cache(context)"},{"line_number":1122,"context_line":"        return constants.SUBSTR_PORT_FILTERING in self.extensions"},{"line_number":1123,"context_line":""},{"line_number":1124,"context_line":"    def supports_port_binding_extension(self, context):"},{"line_number":1125,"context_line":"        \"\"\"This is a simple check to see if the neutron \"binding-extended\""},{"line_number":1126,"context_line":"        extension exists and is enabled."},{"line_number":1127,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"bf659307_321f876d","line":1124,"in_reply_to":"bf659307_9721a550","updated":"2018-03-27 00:57:32.000000000","message":"Meh, I could add a test but it would be so trivial...","commit_id":"f1ddf97bd91c0b1ee9a995741f195a9aa6a46a2c"}],"nova/network/neutronv2/constants.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"62afcede3475c8c99c3f3bbbfeff3df6d97cd139","unresolved":false,"context_lines":[{"line_number":19,"context_line":"DNS_INTEGRATION \u003d \u0027DNS Integration\u0027"},{"line_number":20,"context_line":"MULTI_NET_EXT \u003d \u0027Multi Provider Network\u0027"},{"line_number":21,"context_line":"SUBSTR_PORT_FILTERING \u003d \u0027IP address substring filtering\u0027"},{"line_number":22,"context_line":"PORT_BINDING_EXTENDED \u003d \u0027Port Bindings Extended\u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_3c03e378","line":22,"updated":"2018-06-18 12:07:23.000000000","message":"Name checks out in https://review.openstack.org/#/c/484389/8/neutron_lib/api/definitions/portbindings_extended.py@43","commit_id":"9c2ede27124a3881a7631e43a82c0190229a4a11"}]}