)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0da67e674d545c2562c0ede4b7f35f636241ba7f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"converting images with qemu-img."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ifb47de00abf3f83442ca5264fbc24885df924a19"},{"line_number":20,"context_line":"Closes-Bug: #1734784"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ff82abbf_6710524f","line":20,"updated":"2017-11-28 22:57:47.000000000","message":"Good commit message ++","commit_id":"35dc09c509cd1fffb6ed0e8b809d2f110ff3985a"}],"nova/utils.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0da67e674d545c2562c0ede4b7f35f636241ba7f","unresolved":false,"context_lines":[{"line_number":1389,"context_line":""},{"line_number":1390,"context_line":"    testfile \u003d os.path.join(dirpath, \".directio.test\")"},{"line_number":1391,"context_line":""},{"line_number":1392,"context_line":"    hasDirectIO \u003d True"},{"line_number":1393,"context_line":"    fd \u003d None"},{"line_number":1394,"context_line":"    try:"},{"line_number":1395,"context_line":"        fd \u003d os.open(testfile, os.O_CREAT | os.O_WRONLY | os.O_DIRECT)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_6c53596c","line":1392,"range":{"start_line":1392,"start_character":4,"end_line":1392,"end_character":15},"updated":"2017-11-28 22:57:47.000000000","message":"Well, this is weird that we ever added a camel cased variable to the code! (I saw that it was like that originally)","commit_id":"35dc09c509cd1fffb6ed0e8b809d2f110ff3985a"}],"nova/virt/images.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0da67e674d545c2562c0ede4b7f35f636241ba7f","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    # in environments like live distributions. In such case, the best choice"},{"line_number":125,"context_line":"    # is writethrough, which is power-failure safe, but still faster than"},{"line_number":126,"context_line":"    # writeback."},{"line_number":127,"context_line":"    if supports_direct_io(CONF.instances_path):"},{"line_number":128,"context_line":"        cache_mode \u003d \u0027none\u0027"},{"line_number":129,"context_line":"    else:"},{"line_number":130,"context_line":"        cache_mode \u003d \u0027writethrough\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_cc64e54c","line":127,"range":{"start_line":127,"start_character":7,"end_line":127,"end_character":25},"updated":"2017-11-28 22:57:47.000000000","message":"This needs to be utils.supports_direct_io because it comes in via the \"from nova import utils\" at L35.","commit_id":"35dc09c509cd1fffb6ed0e8b809d2f110ff3985a"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"eb5cdd71890d797bb4c9b8daa68a7f0b6b73268c","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    # NOTE(zigo): we cannot use -t none if the instances dir is mounted on a"},{"line_number":122,"context_line":"    # filesystem that doesn\u0027t have support for O_DIRECT, which is the case"},{"line_number":123,"context_line":"    # for example with tmpfs. This simply crashes \"openstack server create\""},{"line_number":124,"context_line":"    # in environments like live distributions. In such case, the best choice"},{"line_number":125,"context_line":"    # is writethrough, which is power-failure safe, but still faster than"},{"line_number":126,"context_line":"    # writeback."},{"line_number":127,"context_line":"    if utils.supports_direct_io(CONF.instances_path):"},{"line_number":128,"context_line":"        cache_mode \u003d \u0027none\u0027"},{"line_number":129,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"df87a7cf_9bbab96b","line":126,"range":{"start_line":124,"start_character":47,"end_line":126,"end_character":16},"updated":"2017-12-08 16:11:20.000000000","message":"Agreed.","commit_id":"e6ce9557f84cdcdf4ffdd12ce73a008c96c7b94a"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"0da67e674d545c2562c0ede4b7f35f636241ba7f","unresolved":false,"context_lines":[{"line_number":410,"context_line":"            # is safe for migration provided the filesystem is cache coherent"},{"line_number":411,"context_line":"            # (cluster filesystems typically are, but things like NFS are not)."},{"line_number":412,"context_line":"            self._disk_cachemode \u003d \"none\""},{"line_number":413,"context_line":"            if not supports_direct_io(CONF.instances_path):"},{"line_number":414,"context_line":"                self._disk_cachemode \u003d \"writethrough\""},{"line_number":415,"context_line":"        return self._disk_cachemode"},{"line_number":416,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_acd2c1cf","line":413,"range":{"start_line":413,"start_character":19,"end_line":413,"end_character":37},"updated":"2017-11-28 22:57:47.000000000","message":"This needs to be utils.supports_direct_io as it comes from the utils import on L88.","commit_id":"35dc09c509cd1fffb6ed0e8b809d2f110ff3985a"}]}