)]}'
{"nova/objects/pci_device.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ab3d655db8073078c4c392fdfd5c04f66e620ec0","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        for k, v in dev_dict.items():"},{"line_number":160,"context_line":"            if k in self.fields.keys():"},{"line_number":161,"context_line":"                setattr(self, k, v)"},{"line_number":162,"context_line":"            else:"},{"line_number":163,"context_line":"                # NOTE(yjiang5): extra_info.update does not update"},{"line_number":164,"context_line":"                # obj_what_changed, set it explicitly"},{"line_number":165,"context_line":"                # NOTE(ralonsoh): list of parameters currently added to"},{"line_number":166,"context_line":"                # \"extra_info\" dict:"},{"line_number":167,"context_line":"                #     - \"capabilities\": dict of (strings/list of strings)"},{"line_number":168,"context_line":"                extra_info \u003d self.extra_info"},{"line_number":169,"context_line":"                data \u003d (v if isinstance(v, six.string_types) else"},{"line_number":170,"context_line":"                        jsonutils.dumps(v))"},{"line_number":171,"context_line":"                extra_info.update({k: data})"},{"line_number":172,"context_line":"                self.extra_info \u003d extra_info"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":175,"context_line":"        super(PciDevice, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_4238723c","line":172,"range":{"start_line":162,"start_character":0,"end_line":172,"end_character":44},"updated":"2017-11-30 09:27:35.000000000","message":"Is this still relevant if we\u0027re not actually using it anywhere?","commit_id":"1430f6c89a885cd041ee05db0ed683dbbb7d9aea"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"08d286ccaed2bc2b22a4687c4c58b7e951cd752b","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        for k, v in dev_dict.items():"},{"line_number":160,"context_line":"            if k in self.fields.keys():"},{"line_number":161,"context_line":"                setattr(self, k, v)"},{"line_number":162,"context_line":"            else:"},{"line_number":163,"context_line":"                # NOTE(yjiang5): extra_info.update does not update"},{"line_number":164,"context_line":"                # obj_what_changed, set it explicitly"},{"line_number":165,"context_line":"                # NOTE(ralonsoh): list of parameters currently added to"},{"line_number":166,"context_line":"                # \"extra_info\" dict:"},{"line_number":167,"context_line":"                #     - \"capabilities\": dict of (strings/list of strings)"},{"line_number":168,"context_line":"                extra_info \u003d self.extra_info"},{"line_number":169,"context_line":"                data \u003d (v if isinstance(v, six.string_types) else"},{"line_number":170,"context_line":"                        jsonutils.dumps(v))"},{"line_number":171,"context_line":"                extra_info.update({k: data})"},{"line_number":172,"context_line":"                self.extra_info \u003d extra_info"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":175,"context_line":"        super(PciDevice, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_eec158e6","line":172,"range":{"start_line":162,"start_character":0,"end_line":172,"end_character":44},"in_reply_to":"df87a7cf_4ef724d6","updated":"2017-12-13 15:42:23.000000000","message":"I saw L177 below and missed L115 above, meaning I thought \u0027self.extra_info\u0027 was a local-only attribute (e.g. not stored) and was therefore unused here.\n\nUnrelated, but we should probably remove the setting of those attributes below - dansmith said there\u0027s a reason, which I don\u0027t remember, for not doing this","commit_id":"1430f6c89a885cd041ee05db0ed683dbbb7d9aea"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"bfe1e521b300ee33898bf8d0c7178e36343242e3","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        for k, v in dev_dict.items():"},{"line_number":160,"context_line":"            if k in self.fields.keys():"},{"line_number":161,"context_line":"                setattr(self, k, v)"},{"line_number":162,"context_line":"            else:"},{"line_number":163,"context_line":"                # NOTE(yjiang5): extra_info.update does not update"},{"line_number":164,"context_line":"                # obj_what_changed, set it explicitly"},{"line_number":165,"context_line":"                # NOTE(ralonsoh): list of parameters currently added to"},{"line_number":166,"context_line":"                # \"extra_info\" dict:"},{"line_number":167,"context_line":"                #     - \"capabilities\": dict of (strings/list of strings)"},{"line_number":168,"context_line":"                extra_info \u003d self.extra_info"},{"line_number":169,"context_line":"                data \u003d (v if isinstance(v, six.string_types) else"},{"line_number":170,"context_line":"                        jsonutils.dumps(v))"},{"line_number":171,"context_line":"                extra_info.update({k: data})"},{"line_number":172,"context_line":"                self.extra_info \u003d extra_info"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":175,"context_line":"        super(PciDevice, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_4ef724d6","line":172,"range":{"start_line":162,"start_character":0,"end_line":172,"end_character":44},"in_reply_to":"df87a7cf_aecfd0ae","updated":"2017-12-13 15:28:31.000000000","message":"Looks like this was added as part of e6829f872aca03af6181557260637c8b601e476a and is separate (and came later) from the migration code hangover that I\u0027m removing in this patch.","commit_id":"1430f6c89a885cd041ee05db0ed683dbbb7d9aea"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"f0a292c3601926a16db5a71ebd45444409c179c1","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        for k, v in dev_dict.items():"},{"line_number":160,"context_line":"            if k in self.fields.keys():"},{"line_number":161,"context_line":"                setattr(self, k, v)"},{"line_number":162,"context_line":"            else:"},{"line_number":163,"context_line":"                # NOTE(yjiang5): extra_info.update does not update"},{"line_number":164,"context_line":"                # obj_what_changed, set it explicitly"},{"line_number":165,"context_line":"                # NOTE(ralonsoh): list of parameters currently added to"},{"line_number":166,"context_line":"                # \"extra_info\" dict:"},{"line_number":167,"context_line":"                #     - \"capabilities\": dict of (strings/list of strings)"},{"line_number":168,"context_line":"                extra_info \u003d self.extra_info"},{"line_number":169,"context_line":"                data \u003d (v if isinstance(v, six.string_types) else"},{"line_number":170,"context_line":"                        jsonutils.dumps(v))"},{"line_number":171,"context_line":"                extra_info.update({k: data})"},{"line_number":172,"context_line":"                self.extra_info \u003d extra_info"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":175,"context_line":"        super(PciDevice, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_aecfd0ae","line":172,"range":{"start_line":162,"start_character":0,"end_line":172,"end_character":44},"in_reply_to":"ff82abbf_4238723c","updated":"2017-12-13 15:26:46.000000000","message":"What do you mean by not using it anywhere? This is used when creating the object and it looks like the purpose here is to pull things out of the dev_dict and shove them into the extra_info dict.","commit_id":"1430f6c89a885cd041ee05db0ed683dbbb7d9aea"}]}