)]}'
{"nova/virt/hardware.py":[{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"dc4c87752e133efa55118a6dc5e203c0775e2ed5","unresolved":false,"context_lines":[{"line_number":919,"context_line":"    if host_cell.avail_memory \u003c instance_cell.memory:"},{"line_number":920,"context_line":"        LOG.debug(\u0027Not enough available memory to schedule instance. \u0027"},{"line_number":921,"context_line":"                  \u0027Oversubscription is not possible with pinned instances. \u0027"},{"line_number":922,"context_line":"                  \u0027Required: %(required)s, actual: %(actual)s, total: %(total)s. \u0027,"},{"line_number":923,"context_line":"                  {\u0027required\u0027: instance_cell.memory,"},{"line_number":924,"context_line":"                   \u0027actual\u0027: host_cell.avail_memory,"},{"line_number":925,"context_line":"                   \u0027total\u0027: host_cell.memory})"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_aa411aa8","line":922,"range":{"start_line":922,"start_character":69,"end_line":922,"end_character":83},"updated":"2017-11-30 06:39:43.000000000","message":"too long","commit_id":"f5eb8242ab5aec812237d863a39b6fb524fcb385"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"2642edb415db5f71629c41b116fe631e5fb6bc6f","unresolved":false,"context_lines":[{"line_number":919,"context_line":"    if host_cell.avail_memory \u003c instance_cell.memory:"},{"line_number":920,"context_line":"        LOG.debug(\u0027Not enough available memory to schedule instance. \u0027"},{"line_number":921,"context_line":"                  \u0027Oversubscription is not possible with pinned instances. \u0027"},{"line_number":922,"context_line":"                  \u0027Required: %(required)s, actual: %(actual)s, \u0027"},{"line_number":923,"context_line":"                  \u0027total: %(total)s. \u0027,"},{"line_number":924,"context_line":"                  {\u0027required\u0027: instance_cell.memory,"},{"line_number":925,"context_line":"                   \u0027actual\u0027: host_cell.avail_memory,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_5309182f","line":922,"range":{"start_line":922,"start_character":43,"end_line":922,"end_character":49},"updated":"2017-11-30 20:20:33.000000000","message":"Should we reword this to \"available\" since the \u0027total\u0027 thing probably got confused with what \u0027actual\u0027 meant.","commit_id":"9934fe044670cd59ff3db894bb2bea7070f42ae2"},{"author":{"_account_id":24042,"name":"Andreas Karis","email":"akaris@redhat.com","username":"akaris"},"change_message_id":"f3e556092ebb956be9bac35549e54fb6f78098e5","unresolved":false,"context_lines":[{"line_number":919,"context_line":"    if host_cell.avail_memory \u003c instance_cell.memory:"},{"line_number":920,"context_line":"        LOG.debug(\u0027Not enough available memory to schedule instance. \u0027"},{"line_number":921,"context_line":"                  \u0027Oversubscription is not possible with pinned instances. \u0027"},{"line_number":922,"context_line":"                  \u0027Required: %(required)s, actual: %(actual)s, \u0027"},{"line_number":923,"context_line":"                  \u0027total: %(total)s. \u0027,"},{"line_number":924,"context_line":"                  {\u0027required\u0027: instance_cell.memory,"},{"line_number":925,"context_line":"                   \u0027actual\u0027: host_cell.avail_memory,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_b94ba55d","line":922,"range":{"start_line":922,"start_character":43,"end_line":922,"end_character":49},"in_reply_to":"ff82abbf_5309182f","updated":"2017-11-30 20:58:45.000000000","message":"Hi,\n\nI was thinking about exactly the same thing! However, if you look a bit higher in the code (e.g. 907 - 916), we already use the word \u0027actual\u0027 for \u0027available\u0027 CPUs, because in this case, we are considering available CPUs. In lines 973 to 981, we use the word actual for host_cell.memory, because we are looking at and comparing that.\n\nDoesn\u0027t \u0027actual\u0027  simply mean: this is what I have (available or total), depending on the context of what we\u0027re currently looking at (available or total). In the 2 examples and anywhere else in this file, \u0027actual\u0027 always refers to the value that \"required\" is being compared to as a baseline. And this is why \"actual\" here is consistent with the rest of the code.\n\nThe keyword \u0027actual\u0027 is quite frankly a very bad choice of wording, but this is how it already is. It is easy to understand from the code, because \"actual\" is what we are comparing to, but from the logs, it\u0027s a bit difficult to read. This is why I added \"total\" as an additional reference.\n\nIn this case, we require X amount of RAM out of an actual available free RAM of Y out of a total RAM of Z.\n\nSo if you want to replace \"actual\", then you should be consistent and do it in all log output (at least 4 examples here), and it doesn\u0027t make sense for me in this small bugfix (because that\u0027s what it really is) to engage in style questions and discussions.\n\n    Andreas","commit_id":"9934fe044670cd59ff3db894bb2bea7070f42ae2"},{"author":{"_account_id":24042,"name":"Andreas Karis","email":"akaris@redhat.com","username":"akaris"},"change_message_id":"5a0d2b1eccbf1d99754107e041e687923c9c631e","unresolved":false,"context_lines":[{"line_number":919,"context_line":"    if host_cell.avail_memory \u003c instance_cell.memory:"},{"line_number":920,"context_line":"        LOG.debug(\u0027Not enough available memory to schedule instance. \u0027"},{"line_number":921,"context_line":"                  \u0027Oversubscription is not possible with pinned instances. \u0027"},{"line_number":922,"context_line":"                  \u0027Required: %(required)s, actual: %(actual)s, \u0027"},{"line_number":923,"context_line":"                  \u0027total: %(total)s. \u0027,"},{"line_number":924,"context_line":"                  {\u0027required\u0027: instance_cell.memory,"},{"line_number":925,"context_line":"                   \u0027actual\u0027: host_cell.avail_memory,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_85eaeea9","line":922,"range":{"start_line":922,"start_character":43,"end_line":922,"end_character":49},"in_reply_to":"ff82abbf_b94ba55d","updated":"2017-11-30 23:57:24.000000000","message":"By the way, is there a reason to ask a question and down vote at the same time before even letting me defend my logic? ;-)","commit_id":"9934fe044670cd59ff3db894bb2bea7070f42ae2"}]}