)]}'
{"nova/tests/functional/api/openstack/placement/gabbits/traits.yaml":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"8b7d3ba3e6a20fa6439ea53feb946d808a3f3d11","unresolved":false,"context_lines":[{"line_number":349,"context_line":"    - NON_EXISTED_TRAIT1"},{"line_number":350,"context_line":"    - NON_EXISTED_TRAIT2"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"- name: set traits for resource provider with invalid type of triats"},{"line_number":353,"context_line":"  PUT: /resource_providers/$ENVIRON[\u0027RP_UUID\u0027]/traits"},{"line_number":354,"context_line":"  request_headers:"},{"line_number":355,"context_line":"    content-type: application/json"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"9f91af0f_50574827","line":352,"range":{"start_line":352,"start_character":62,"end_line":352,"end_character":68},"updated":"2018-01-08 13:16:37.000000000","message":"traits","commit_id":"b074dd814024e842d4d90993b3b8ae0b2f66493a"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"4e79da91d8384ddbdbc0f4ae6e7283c04743ddb6","unresolved":false,"context_lines":[{"line_number":349,"context_line":"    - NON_EXISTED_TRAIT1"},{"line_number":350,"context_line":"    - NON_EXISTED_TRAIT2"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"- name: set traits for resource provider with invalid type of triats"},{"line_number":353,"context_line":"  PUT: /resource_providers/$ENVIRON[\u0027RP_UUID\u0027]/traits"},{"line_number":354,"context_line":"  request_headers:"},{"line_number":355,"context_line":"    content-type: application/json"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"7f96bb07_4c917d52","line":352,"range":{"start_line":352,"start_character":62,"end_line":352,"end_character":68},"in_reply_to":"9f91af0f_50574827","updated":"2018-01-11 05:14:28.000000000","message":"Done","commit_id":"b074dd814024e842d4d90993b3b8ae0b2f66493a"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"b78afb282bb9a108a465b202e519aa7625801982","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        - CUSTOM_TRAIT_1"},{"line_number":308,"context_line":"        - CUSTOM_TRAIT_2"},{"line_number":309,"context_line":"  response_strings:"},{"line_number":310,"context_line":"    - \"\u0027resource_provider_generation\u0027 is a required property\""},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"- name: set traits for resource provider with invalid resource provider generation"},{"line_number":313,"context_line":"  PUT: /resource_providers/$ENVIRON[\u0027RP_UUID\u0027]/traits"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3fa0c359_6705f213","line":310,"updated":"2018-02-09 10:57:01.000000000","message":"Why did not failed this before?","commit_id":"4a43353008fd831f5d6377ad5d33746b23aae7ff"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"d32bb64cdbbe4d96a69c054d3497e020d5398709","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        - CUSTOM_TRAIT_1"},{"line_number":308,"context_line":"        - CUSTOM_TRAIT_2"},{"line_number":309,"context_line":"  response_strings:"},{"line_number":310,"context_line":"    - \"\u0027resource_provider_generation\u0027 is a required property\""},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"- name: set traits for resource provider with invalid resource provider generation"},{"line_number":313,"context_line":"  PUT: /resource_providers/$ENVIRON[\u0027RP_UUID\u0027]/traits"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3fa0c359_920f1a36","line":310,"in_reply_to":"3fa0c359_6705f213","updated":"2018-02-09 11:33:26.000000000","message":"What this line is doing is saying \"is this string in the reponse\". So without the line there at all, there\u0027s nothing to check or validate. The string was already there, but we weren\u0027t validating it. Adding the line adds a bit more coverage.\n\nOr is that not your question?","commit_id":"4a43353008fd831f5d6377ad5d33746b23aae7ff"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"189ffc8f36850167d9eccff311750e26782e288b","unresolved":false,"context_lines":[{"line_number":307,"context_line":"        - CUSTOM_TRAIT_1"},{"line_number":308,"context_line":"        - CUSTOM_TRAIT_2"},{"line_number":309,"context_line":"  response_strings:"},{"line_number":310,"context_line":"    - \"\u0027resource_provider_generation\u0027 is a required property\""},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"- name: set traits for resource provider with invalid resource provider generation"},{"line_number":313,"context_line":"  PUT: /resource_providers/$ENVIRON[\u0027RP_UUID\u0027]/traits"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"3fa0c359_5a42af10","line":310,"in_reply_to":"3fa0c359_920f1a36","updated":"2018-02-14 01:09:23.000000000","message":"It is checked whether the response string is in the following string.\nThe \u0027CUSTOM_TRAIT_1\u0027 is in the request body. So it is not appropriate to check it. (\"\u0027resource_provider_generation\u0027 is a required property\" is more appropriate.)\n\n{\n   \"errors\":[\n      {\n         \"detail\":\"The server could not comply with the request since it is either malformed or otherwise incorrect.\\n\\n JSON does not validate: \u0027resource_provider_generation\u0027 is a required property  Failed validating \u0027required\u0027 in schema:     {\u0027additionalProperties\u0027: False,      \u0027properties\u0027: {\u0027resource_provider_generation\u0027: {\u0027type\u0027: \u0027integer\u0027},                     \u0027traits\u0027: {\u0027items\u0027: {\u0027maxLength\u0027: 255,                                          \u0027minLength\u0027: 1,                                          \u0027type\u0027: \u0027string\u0027},                                \u0027type\u0027: \u0027array\u0027}},      \u0027required\u0027: [\u0027traits\u0027, \u0027resource_provider_generation\u0027],      \u0027type\u0027: \u0027object\u0027}  On instance:     {u\u0027traits\u0027: [u\u0027CUSTOM_TRAIT_1\u0027, u\u0027CUSTOM_TRAIT_2\u0027]}  \",\n         \"status\":400,\n         \"request_id\":\"req-7f81bebc-ce99-44b3-a406-2b8ba19ef13b\",\n         \"title\":\"Bad Request\"\n      }\n   ]\n}","commit_id":"4a43353008fd831f5d6377ad5d33746b23aae7ff"}]}