)]}'
{"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"d69398f460bf01afaf15252670f403e3c0c2f141","unresolved":false,"context_lines":[{"line_number":4242,"context_line":"        # Only tests should use allow_null_uuid! It\u0027s purpose is exclusively to"},{"line_number":4243,"context_line":"        # test handling of legacy bdms without a uuid. New code must supply a"},{"line_number":4244,"context_line":"        # uuid."},{"line_number":4245,"context_line":"        assert(\u0027uuid\u0027 in values)"},{"line_number":4246,"context_line":""},{"line_number":4247,"context_line":"    _scrub_empty_str_values(values, [\u0027volume_size\u0027])"},{"line_number":4248,"context_line":"    values \u003d _from_legacy_values(values, legacy)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_8831bba5","line":4245,"range":{"start_line":4245,"start_character":8,"end_line":4245,"end_character":32},"updated":"2017-11-30 11:00:12.000000000","message":"If I recall correctly, assertions aren\u0027t supposed to be used in production code because they can be disabled. Could you just raise a generic exception instead?\n\nhttps://stackoverflow.com/questions/9097706/why-assert-is-not-largely-used","commit_id":"488d27e45b5366ebcfcd07d5b88366371d1f5565"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"3becfd8126d6ff7ee4197f488075df516e06392a","unresolved":false,"context_lines":[{"line_number":4242,"context_line":"        # Only tests should use allow_null_uuid! It\u0027s purpose is exclusively to"},{"line_number":4243,"context_line":"        # test handling of legacy bdms without a uuid. New code must supply a"},{"line_number":4244,"context_line":"        # uuid."},{"line_number":4245,"context_line":"        assert(\u0027uuid\u0027 in values)"},{"line_number":4246,"context_line":""},{"line_number":4247,"context_line":"    _scrub_empty_str_values(values, [\u0027volume_size\u0027])"},{"line_number":4248,"context_line":"    values \u003d _from_legacy_values(values, legacy)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff82abbf_36a9f08f","line":4245,"range":{"start_line":4245,"start_character":8,"end_line":4245,"end_character":32},"in_reply_to":"ff82abbf_8831bba5","updated":"2017-11-30 12:51:12.000000000","message":"That\u0027s ok: this is a pure assertion. I don\u0027t think we actually do disable them in practice, but as long as we don\u0027t disable them in CI it would be fine to disable this in production.\n\nHitting this indicates a programming error, so it\u0027s not intended to be recoverable.","commit_id":"488d27e45b5366ebcfcd07d5b88366371d1f5565"}]}