)]}'
{"nova/api/openstack/compute/quota_sets.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ede9926cc9cd2318a787b91d819ee498b261cf8d","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            # longer have a \u0027reserved\u0027 key returned from get_*_quotas, so set"},{"line_number":96,"context_line":"            # it here to satisfy the REST API response contract."},{"line_number":97,"context_line":"            for v in values.values():"},{"line_number":98,"context_line":"                v[\u0027reserved\u0027] \u003d 0"},{"line_number":99,"context_line":"            return values"},{"line_number":100,"context_line":"        else:"},{"line_number":101,"context_line":"            return {k: v[\u0027limit\u0027] for k, v in values.items()}"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_2277f504","line":98,"range":{"start_line":98,"start_character":32,"end_line":98,"end_character":33},"updated":"2017-12-06 20:12:18.000000000","message":"Hm, now that I asked for review, I notice I think this needs to be set to -1 if using the NoOpQuotaDriver to not change the behavior.","commit_id":"34c9ddb9650d927e0963425cbaf20fe66b97c17c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"a859c2a3cd004f1e9b8f6ebb73290c941649aee9","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            # longer have a \u0027reserved\u0027 key returned from get_*_quotas, so set"},{"line_number":96,"context_line":"            # it here to satisfy the REST API response contract."},{"line_number":97,"context_line":"            for v in values.values():"},{"line_number":98,"context_line":"                v[\u0027reserved\u0027] \u003d (-1 if \u0027NoopQuotaDriver\u0027 in CONF.quota.driver"},{"line_number":99,"context_line":"                                 else 0)"},{"line_number":100,"context_line":"            return values"},{"line_number":101,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_9c7ba6bc","line":98,"updated":"2017-12-07 21:52:57.000000000","message":"This check might be better as a utility in the QUOTAS engine code to hide the gross fact that the caller needs to know about the \"NoopQuotaDriver\" value...","commit_id":"3f9d87f44cbe7dc253a3eee34c6829696bfa1c99"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"368e40286964681e1a4dc02272de3bdf332f2e9e","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            # longer have a \u0027reserved\u0027 key returned from get_*_quotas, so set"},{"line_number":96,"context_line":"            # it here to satisfy the REST API response contract."},{"line_number":97,"context_line":"            for v in values.values():"},{"line_number":98,"context_line":"                v[\u0027reserved\u0027] \u003d (-1 if \u0027NoopQuotaDriver\u0027 in CONF.quota.driver"},{"line_number":99,"context_line":"                                 else 0)"},{"line_number":100,"context_line":"            return values"},{"line_number":101,"context_line":"        else:"},{"line_number":102,"context_line":"            return {k: v[\u0027limit\u0027] for k, v in values.items()}"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_1cbb1672","line":99,"range":{"start_line":98,"start_character":32,"end_line":99,"end_character":40},"updated":"2017-12-07 21:51:29.000000000","message":"super nit: you could do this conditional check outside the loop and set a reserved variable so we don\u0027t need to do this within the loop. If we used java the compiler would optimize this for us, but Python....","commit_id":"3f9d87f44cbe7dc253a3eee34c6829696bfa1c99"}],"nova/cmd/manage.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"ede9926cc9cd2318a787b91d819ee498b261cf8d","unresolved":false,"context_lines":[{"line_number":302,"context_line":"            # reservations, so we no longer have a \u0027reserved\u0027 key returned from"},{"line_number":303,"context_line":"            # get_*_quotas, so set it here to satisfy what\u0027s expected from the"},{"line_number":304,"context_line":"            # command output."},{"line_number":305,"context_line":"            value[\u0027reserved\u0027] \u003d 0"},{"line_number":306,"context_line":"            print(print_format % (key, value[\u0027limit\u0027], value[\u0027in_use\u0027],"},{"line_number":307,"context_line":"                                  value[\u0027reserved\u0027]))"},{"line_number":308,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_02667152","line":305,"range":{"start_line":305,"start_character":32,"end_line":305,"end_character":33},"updated":"2017-12-06 20:12:18.000000000","message":"Same here.","commit_id":"34c9ddb9650d927e0963425cbaf20fe66b97c17c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"368e40286964681e1a4dc02272de3bdf332f2e9e","unresolved":false,"context_lines":[{"line_number":302,"context_line":"            # reservations, so we no longer have a \u0027reserved\u0027 key returned from"},{"line_number":303,"context_line":"            # get_*_quotas, so set it here to satisfy what\u0027s expected from the"},{"line_number":304,"context_line":"            # command output."},{"line_number":305,"context_line":"            value[\u0027reserved\u0027] \u003d (-1 if \u0027NoopQuotaDriver\u0027 in CONF.quota.driver"},{"line_number":306,"context_line":"                                 else 0)"},{"line_number":307,"context_line":"            print(print_format % (key, value[\u0027limit\u0027], value[\u0027in_use\u0027],"},{"line_number":308,"context_line":"                                  value[\u0027reserved\u0027]))"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_bcb30a98","line":305,"updated":"2017-12-07 21:51:29.000000000","message":"same","commit_id":"3f9d87f44cbe7dc253a3eee34c6829696bfa1c99"}]}