)]}'
{"nova/service.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"715cc23303014bc0066f3c4ab52e44c2ee1c43cc","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        self.basic_config_check()"},{"line_number":165,"context_line":"        self.manager.init_host()"},{"line_number":166,"context_line":"        self.model_disconnected \u003d False"},{"line_number":167,"context_line":"        self.ctxt \u003d context.get_admin_context()"},{"line_number":168,"context_line":"        self.service_ref \u003d objects.Service.get_by_host_and_binary("},{"line_number":169,"context_line":"            self.ctxt, self.host, self.binary)"},{"line_number":170,"context_line":"        if self.service_ref:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_981b1f1a","line":167,"range":{"start_line":167,"start_character":8,"end_line":167,"end_character":47},"updated":"2018-02-06 13:42:32.000000000","message":"Doesn\u0027t this context expire after a while?  Or is it not being used across the wire?","commit_id":"682aac175c8a10cbf7223fbb4bcf756a16306f2e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"7090acaafbb3e803f8061255bf44f0f167425bf1","unresolved":false,"context_lines":[{"line_number":164,"context_line":"        self.basic_config_check()"},{"line_number":165,"context_line":"        self.manager.init_host()"},{"line_number":166,"context_line":"        self.model_disconnected \u003d False"},{"line_number":167,"context_line":"        self.ctxt \u003d context.get_admin_context()"},{"line_number":168,"context_line":"        self.service_ref \u003d objects.Service.get_by_host_and_binary("},{"line_number":169,"context_line":"            self.ctxt, self.host, self.binary)"},{"line_number":170,"context_line":"        if self.service_ref:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_bc736880","line":167,"range":{"start_line":167,"start_character":8,"end_line":167,"end_character":47},"in_reply_to":"3fa0c359_981b1f1a","updated":"2018-02-06 22:23:02.000000000","message":"It\u0027s not being used across the wire. It\u0027s just for periodic tasks to use if they make any DB queries (which does not involve keystone auth).","commit_id":"682aac175c8a10cbf7223fbb4bcf756a16306f2e"}],"nova/tests/fixtures.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"715cc23303014bc0066f3c4ab52e44c2ee1c43cc","unresolved":false,"context_lines":[{"line_number":1859,"context_line":"                        \u0027as an argument to the periodic task method, instead.\u0027)"},{"line_number":1860,"context_line":""},{"line_number":1861,"context_line":"    def _run_periodic_tasks(self, *a, **k):"},{"line_number":1862,"context_line":"        with fixtures.MonkeyPatch(\u0027nova.context.get_admin_context\u0027,"},{"line_number":1863,"context_line":"                                  self._poison_context):"},{"line_number":1864,"context_line":"            with fixtures.MonkeyPatch(\u0027nova.context.get_context\u0027,"},{"line_number":1865,"context_line":"                                      self._poison_context):"},{"line_number":1866,"context_line":"                self._real_run_periodic_tasks(*a, **k)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_7833b3ac","line":1865,"range":{"start_line":1862,"start_character":8,"end_line":1865,"end_character":60},"updated":"2018-02-06 13:42:32.000000000","message":"FYI, you can do this without nesting since py27:\n\n  with \u003cfirst thing\u003e, \u003csecond thing\u003e:","commit_id":"682aac175c8a10cbf7223fbb4bcf756a16306f2e"},{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"7090acaafbb3e803f8061255bf44f0f167425bf1","unresolved":false,"context_lines":[{"line_number":1859,"context_line":"                        \u0027as an argument to the periodic task method, instead.\u0027)"},{"line_number":1860,"context_line":""},{"line_number":1861,"context_line":"    def _run_periodic_tasks(self, *a, **k):"},{"line_number":1862,"context_line":"        with fixtures.MonkeyPatch(\u0027nova.context.get_admin_context\u0027,"},{"line_number":1863,"context_line":"                                  self._poison_context):"},{"line_number":1864,"context_line":"            with fixtures.MonkeyPatch(\u0027nova.context.get_context\u0027,"},{"line_number":1865,"context_line":"                                      self._poison_context):"},{"line_number":1866,"context_line":"                self._real_run_periodic_tasks(*a, **k)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa0c359_7c6de096","line":1865,"range":{"start_line":1862,"start_character":8,"end_line":1865,"end_character":60},"in_reply_to":"3fa0c359_7833b3ac","updated":"2018-02-06 22:23:02.000000000","message":"Oops, thanks.","commit_id":"682aac175c8a10cbf7223fbb4bcf756a16306f2e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0d99707b54ba2443b9cb4e5ab59bdd3007bd6df2","unresolved":false,"context_lines":[{"line_number":2134,"context_line":"            \u0027keystoneauth1.adapter.Adapter.get_api_major_version\u0027))"},{"line_number":2135,"context_line":""},{"line_number":2136,"context_line":""},{"line_number":2137,"context_line":"class PeriodicTaskPoisonFixture(fixtures.Fixture):"},{"line_number":2138,"context_line":"    \"\"\"A fixture to prevent calls of get_[admin_|]context() in periodic tasks."},{"line_number":2139,"context_line":""},{"line_number":2140,"context_line":"    When we start periodic tasks in nova.Service, we pass a RequestContext for"}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_02be1bad","line":2137,"updated":"2019-08-06 10:00:31.000000000","message":"It think we don\u0027t need this fixture if we go with https://review.opendev.org/#/c/542891","commit_id":"036b7b61c577749b93ab50827dbafab581fc81ad"}]}
