)]}'
{"nova/network/api.py":[{"author":{"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"},"change_message_id":"5ec7f225411f8cc3003ec86dae0438051231b9bb","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        \"\"\"Removes a fixed ip from instance from specified network.\"\"\""},{"line_number":196,"context_line":"        # NOTE(tr3buchet): poorly written, broken in all but flat manager"},{"line_number":197,"context_line":"        args \u003d {\u0027instance_id\u0027: instance_id,"},{"line_number":198,"context_line":"                \u0027host\u0027: host,"},{"line_number":199,"context_line":"                \u0027address\u0027: address}"},{"line_number":200,"context_line":"        rpc.cast(context, FLAGS.network_topic,"},{"line_number":201,"context_line":"                 {\u0027method\u0027: \u0027remove_fixed_ip_from_instance\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAE3%2F%2F%2FSw%3D","line":198,"updated":"2012-03-12 22:48:10.000000000","message":"this should be instance[\u0027host\u0027] to prevent having to pass host into this function, and change the signature. The only time this host would be used is in the case of multihost.","commit_id":"c6055339b129fa1f313bba3730b2545a78d38323"},{"author":{"_account_id":191,"name":"Trey Morris","email":"trey.morris@rackspace.com","username":"tr3buchet"},"change_message_id":"2b3f55538a07cbbd0a8701fe4380a7bb6ab559ae","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        \"\"\"Removes a fixed ip from instance from specified network.\"\"\""},{"line_number":196,"context_line":"        # NOTE(tr3buchet): poorly written, broken in all but flat manager"},{"line_number":197,"context_line":"        args \u003d {\u0027instance_id\u0027: instance_id,"},{"line_number":198,"context_line":"                \u0027host\u0027: host,"},{"line_number":199,"context_line":"                \u0027address\u0027: address}"},{"line_number":200,"context_line":"        rpc.cast(context, FLAGS.network_topic,"},{"line_number":201,"context_line":"                 {\u0027method\u0027: \u0027remove_fixed_ip_from_instance\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAE3%2F%2F%2FGg%3D","line":198,"in_reply_to":"AAAAE3%2F%2F%2FLs%3D","updated":"2012-03-13 15:49:31.000000000","message":"I think when we\u0027re in compute, there\u0027s no reason not to just pass the object, is there? If it were me, I\u0027d just pass the object. This way you can always know where host came from and not have to go track down the callers.","commit_id":"c6055339b129fa1f313bba3730b2545a78d38323"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"96474e3c168123f1f28ccd1fac62ab1a4842b665","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        \"\"\"Removes a fixed ip from instance from specified network.\"\"\""},{"line_number":196,"context_line":"        # NOTE(tr3buchet): poorly written, broken in all but flat manager"},{"line_number":197,"context_line":"        args \u003d {\u0027instance_id\u0027: instance_id,"},{"line_number":198,"context_line":"                \u0027host\u0027: host,"},{"line_number":199,"context_line":"                \u0027address\u0027: address}"},{"line_number":200,"context_line":"        rpc.cast(context, FLAGS.network_topic,"},{"line_number":201,"context_line":"                 {\u0027method\u0027: \u0027remove_fixed_ip_from_instance\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAE3%2F%2F%2FLs%3D","line":198,"in_reply_to":"AAAAE3%2F%2F%2FSw%3D","updated":"2012-03-13 06:53:11.000000000","message":"I agree that it is better to pass in the instance object and grab the host and id like we do in allocate for instance, but the same is true of add_fixed_ip_to_instance above, and I thought it better to keep the change small and match the add_fixed_ip than to change them both to use instance instead of instance_id.  If you disagree I will modify both of them to match deallocate_for_instance.","commit_id":"c6055339b129fa1f313bba3730b2545a78d38323"}]}