)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":28350,"name":"Sun Mengyun","email":"sun.mengyun@zte.com.cn","username":"sun.mengyun"},"change_message_id":"23a39c462d7384df58994fe7c31c7244422d16ee","unresolved":false,"context_lines":[{"line_number":4794,"context_line":""},{"line_number":4795,"context_line":"        if image:"},{"line_number":4796,"context_line":"            instance.image_ref \u003d shelved_image_ref"},{"line_number":4797,"context_line":"            self._delete_snapshot_of_shelved_instance(context, instance,"},{"line_number":4798,"context_line":"                                                      image[\u0027id\u0027])"},{"line_number":4799,"context_line":""},{"line_number":4800,"context_line":"        self._unshelve_instance_key_restore(instance, scrubbed_keys)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_4ff2199c","side":"PARENT","line":4797,"range":{"start_line":4797,"start_character":17,"end_line":4797,"end_character":53},"updated":"2018-08-14 06:53:33.000000000","message":"If you do not delete snapshot, do you use a lot of space as shelve/unshelve operations increase?","commit_id":"b6a245f0425a07be3871a976952646d2bdd44533"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"22beaffda6b8fc98fbbc0ac68b114ee2e01b9ef7","unresolved":false,"context_lines":[{"line_number":4794,"context_line":""},{"line_number":4795,"context_line":"        if image:"},{"line_number":4796,"context_line":"            instance.image_ref \u003d shelved_image_ref"},{"line_number":4797,"context_line":"            self._delete_snapshot_of_shelved_instance(context, instance,"},{"line_number":4798,"context_line":"                                                      image[\u0027id\u0027])"},{"line_number":4799,"context_line":""},{"line_number":4800,"context_line":"        self._unshelve_instance_key_restore(instance, scrubbed_keys)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_d232e85e","side":"PARENT","line":4797,"range":{"start_line":4797,"start_character":17,"end_line":4797,"end_character":53},"in_reply_to":"3f79a3b5_4ff2199c","updated":"2018-08-29 20:40:28.000000000","message":"Yes potentially. It\u0027s unclear to me what the contract with the user should be with respect to the shelve API. For createImage and createBackup server actions clearly as a user you\u0027d expect to see a snapshot of the disk in glance after those operations, but I guess that was never the intention with shelve.","commit_id":"b6a245f0425a07be3871a976952646d2bdd44533"}]}