)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"1a7572ff7a711669f8711acbe77dfa6d76370bf8","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This fixes that issue and leaves a TODO about investigating"},{"line_number":20,"context_line":"the usage of set_backend_setting for just setting the"},{"line_number":21,"context_line":"single force_tcg value instead of overrwriting all backend"},{"line_number":22,"context_line":"settings."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Credit to Clark Boylan for identifying the issue."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df87a7cf_3969da24","line":21,"range":{"start_line":21,"start_character":34,"end_line":21,"end_character":46},"updated":"2017-12-01 22:55:50.000000000","message":"d\u0027oh","commit_id":"f5b1a31a58210f2aa8edf98decae18264b4cd378"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"bc23c29892fe1343c8c6d4c5ee10f155f7a4555c","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This fixes that issue and leaves a TODO about investigating"},{"line_number":20,"context_line":"the usage of set_backend_setting for just setting the"},{"line_number":21,"context_line":"single force_tcg value instead of overrwriting all backend"},{"line_number":22,"context_line":"settings."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Credit to Clark Boylan for identifying the issue."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"df87a7cf_aaab051b","line":21,"range":{"start_line":21,"start_character":34,"end_line":21,"end_character":46},"in_reply_to":"df87a7cf_3969da24","updated":"2017-12-05 14:50:28.000000000","message":"Heh, if you respin, you can: s/overrwriting/overwriting/","commit_id":"f5b1a31a58210f2aa8edf98decae18264b4cd378"}],"nova/virt/disk/vfs/guestfs.py":[{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"94a77a82d0213780c89d4299bca6fb3fb84ff2cb","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        try:"},{"line_number":194,"context_line":"            if forceTCG:"},{"line_number":195,"context_line":"                # TODO(mriedem): Should we be using set_backend_setting"},{"line_number":196,"context_line":"                # instead to just set the single force_tcg setting? Because"},{"line_number":197,"context_line":"                # according to the guestfs docs, set_backend_settings will"},{"line_number":198,"context_line":"                # overwrite all backend settings. The question is, what would"},{"line_number":199,"context_line":"                # the value be? True? \"set_backend_setting\" is available"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_4717d452","line":196,"updated":"2017-12-05 14:27:46.000000000","message":"Good catch.\n\nIf we\u0027re not setting anything else, besides \u0027force_tcg\u0027, then we should indeed switch to the singular guestfs_set_backend_setting()[1] instead of the plural guestfs_set_backend_settings()[2].\n\nAnd for now, sticking with the plural _setings() method is okay, due to the backports argument you make further down below.\n\nAt least, this is fixing the more immediate issue of setting the option properly, by not turning it into a list.\n\n[1] http://libguestfs.org/guestfs.3.html#guestfs_set_backend_setting\n[2] http://libguestfs.org/guestfs.3.html#guestfs_set_backend_settings","commit_id":"f5b1a31a58210f2aa8edf98decae18264b4cd378"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"bc23c29892fe1343c8c6d4c5ee10f155f7a4555c","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        try:"},{"line_number":194,"context_line":"            if forceTCG:"},{"line_number":195,"context_line":"                # TODO(mriedem): Should we be using set_backend_setting"},{"line_number":196,"context_line":"                # instead to just set the single force_tcg setting? Because"},{"line_number":197,"context_line":"                # according to the guestfs docs, set_backend_settings will"},{"line_number":198,"context_line":"                # overwrite all backend settings. The question is, what would"},{"line_number":199,"context_line":"                # the value be? True? \"set_backend_setting\" is available"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_caf8c94a","line":196,"in_reply_to":"df87a7cf_4717d452","updated":"2017-12-05 14:50:28.000000000","message":"Also: We should probably add a note to the effect that eventually when the hosting providers (e.g. OVH) that do support KVM, we should rather make this configurable based on the run-time information we have: i.e. if we the /dev/kvm character device is present we use KVM, otherwise use TCG.","commit_id":"f5b1a31a58210f2aa8edf98decae18264b4cd378"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"414a00d0a30256b6aca86c7eecc430a560e5b443","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                # instead to just set the single force_tcg setting? Because"},{"line_number":197,"context_line":"                # according to the guestfs docs, set_backend_settings will"},{"line_number":198,"context_line":"                # overwrite all backend settings. The question is, what would"},{"line_number":199,"context_line":"                # the value be? True? \"set_backend_setting\" is available"},{"line_number":200,"context_line":"                # starting in 1.27.2 which should be new enough at this point"},{"line_number":201,"context_line":"                # on modern distributions."},{"line_number":202,"context_line":"                ret \u003d self.handle.set_backend_settings([\"force_tcg\"])"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_4fe64ceb","line":199,"range":{"start_line":199,"start_character":32,"end_line":199,"end_character":36},"updated":"2017-12-02 01:11:11.000000000","message":"Looks like \"1\" per how it works below:\n\nhttp://logs.openstack.org/50/524750/1/check/legacy-tempest-dsvm-neutron-full/ef524df/logs/screen-n-cpu.txt.gz#_Dec_01_23_22_31_093273\n\nDec 01 23:22:31.093273 ubuntu-xenial-citycloud-lon1-0001173687 nova-compute[16064]: DEBUG nova.virt.disk.vfs.guestfs [-] event\u003dtrace eh\u003d0 buf\u003d\u0027get_backend_setting \"force_tcg\"\u0027 array\u003d[] {{(pid\u003d16064) log_callback /opt/stack/new/nova/nova/virt/disk/vfs/guestfs.py:104}}\nDec 01 23:22:31.093988 ubuntu-xenial-citycloud-lon1-0001173687 nova-compute[16064]: DEBUG nova.virt.disk.vfs.guestfs [-] event\u003dtrace eh\u003d0 buf\u003d\u0027get_backend_setting \u003d \"1\"\u0027 array\u003d[] {{(pid\u003d16064) log_callback /opt/stack/new/nova/nova/virt/disk/vfs/guestfs.py:104}}","commit_id":"f5b1a31a58210f2aa8edf98decae18264b4cd378"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"6c981a4b027473a31276ba4de01efe4073c5bc84","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                # the value be? True? \"set_backend_setting\" is available"},{"line_number":200,"context_line":"                # starting in 1.27.2 which should be new enough at this point"},{"line_number":201,"context_line":"                # on modern distributions."},{"line_number":202,"context_line":"                ret \u003d self.handle.set_backend_settings([\"force_tcg\"])"},{"line_number":203,"context_line":"                if ret !\u003d 0:"},{"line_number":204,"context_line":"                    LOG.warning(\u0027Failed to force guestfs TCG mode. \u0027"},{"line_number":205,"context_line":"                                \u0027guestfs_set_backend_settings returned: %s\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_596cde07","line":202,"range":{"start_line":202,"start_character":57,"end_line":202,"end_character":66},"updated":"2017-12-01 23:18:47.000000000","message":"The problem has been reproduced reliably on CentOS and OpenSUSE but we haven\u0027t been able to witness it occuring on Ubuntu.\n\nIt would perhaps be worth understanding why ?\n\nThose are the versions found in the current gate jobs:\n- 1.32.2 Ubuntu\n- 1.32.4 OpenSuSE\n- 1.36.3 CentOS \n\nAt least as far as this particular binding seems concerned, it doesn\u0027t seem like it expected a string instead of a list before [1].\n\n[1]: http://paste.openstack.org/raw/627999/","commit_id":"f5b1a31a58210f2aa8edf98decae18264b4cd378"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"8f2e6e5d98d0b10a8bf4504a0cc3c57b6e323165","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                # the value be? True? \"set_backend_setting\" is available"},{"line_number":200,"context_line":"                # starting in 1.27.2 which should be new enough at this point"},{"line_number":201,"context_line":"                # on modern distributions."},{"line_number":202,"context_line":"                ret \u003d self.handle.set_backend_settings([\"force_tcg\"])"},{"line_number":203,"context_line":"                if ret !\u003d 0:"},{"line_number":204,"context_line":"                    LOG.warning(\u0027Failed to force guestfs TCG mode. \u0027"},{"line_number":205,"context_line":"                                \u0027guestfs_set_backend_settings returned: %s\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_f45ff90b","line":202,"range":{"start_line":202,"start_character":57,"end_line":202,"end_character":66},"in_reply_to":"df87a7cf_596cde07","updated":"2017-12-01 23:19:20.000000000","message":"I guess I should have mentioned that those are libguestfs versions.","commit_id":"f5b1a31a58210f2aa8edf98decae18264b4cd378"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8600074d75c3ff602bdd5879b0554866db67d837","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                # the value be? True? \"set_backend_setting\" is available"},{"line_number":200,"context_line":"                # starting in 1.27.2 which should be new enough at this point"},{"line_number":201,"context_line":"                # on modern distributions."},{"line_number":202,"context_line":"                ret \u003d self.handle.set_backend_settings([\"force_tcg\"])"},{"line_number":203,"context_line":"                if ret !\u003d 0:"},{"line_number":204,"context_line":"                    LOG.warning(\u0027Failed to force guestfs TCG mode. \u0027"},{"line_number":205,"context_line":"                                \u0027guestfs_set_backend_settings returned: %s\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_146cdd34","line":202,"range":{"start_line":202,"start_character":57,"end_line":202,"end_character":66},"in_reply_to":"df87a7cf_f45ff90b","updated":"2017-12-01 23:56:07.000000000","message":"The other reason I was going to leave this as set_backend_settings for now is backports. We could change to set_backend_setting in master when we\u0027re happy with that, but I figured we\u0027d backport the fix using the call we have been using (albeit incorrectly) all along.","commit_id":"f5b1a31a58210f2aa8edf98decae18264b4cd378"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c40c8e17f571d0e69d687ae7e5b76aff03539ac8","unresolved":false,"context_lines":[{"line_number":201,"context_line":"                # on modern distributions."},{"line_number":202,"context_line":"                ret \u003d self.handle.set_backend_settings([\"force_tcg\"])"},{"line_number":203,"context_line":"                if ret !\u003d 0:"},{"line_number":204,"context_line":"                    LOG.warning(\u0027Failed to force guestfs TCG mode. \u0027"},{"line_number":205,"context_line":"                                \u0027guestfs_set_backend_settings returned: %s\u0027,"},{"line_number":206,"context_line":"                                ret)"},{"line_number":207,"context_line":"        except AttributeError as ex:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_c11b707e","line":204,"updated":"2017-12-08 17:23:06.000000000","message":"I\u0027m seeing this in a devstack run where we have guestfs debug enabled and it depends on this patch:\n\nhttp://logs.openstack.org/50/524750/1/check/legacy-tempest-dsvm-neutron-full-centos-7/a7f051e/logs/screen-n-cpu.txt.gz#_Dec_04_13_43_19_923098\n\nDec 04 13:43:19.923098 centos-7-rax-dfw-0001196569 nova-compute[7962]: WARNING nova.virt.disk.vfs.guestfs [None req-47f55bab-57b2-4d88-a065-fcb796132c3a tempest-ServerDiagnosticsNegativeV248Test-1247032533 tempest-ServerDiagnosticsNegativeV248Test-1247032533] Failed to force guestfs TCG mode. guestfs_set_backend_settings returned: None","commit_id":"f5b1a31a58210f2aa8edf98decae18264b4cd378"}]}