)]}'
{"nova/virt/libvirt/driver.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"2269130dbdf71ffc4bd1248ab6b361d6f0a46c67","unresolved":false,"context_lines":[{"line_number":2569,"context_line":"        guest \u003d self._host.get_guest(instance)"},{"line_number":2570,"context_line":"        guest.resume()"},{"line_number":2571,"context_line":"        if instance.image_meta.properties.get(\u0027hw_qemu_guest_agent\u0027, False):"},{"line_number":2572,"context_line":"            guest.sync_guest_time()"},{"line_number":2573,"context_line":""},{"line_number":2574,"context_line":"    def _clean_shutdown(self, instance, timeout, retry_interval):"},{"line_number":2575,"context_line":"        \"\"\"Attempt to shutdown the instance gracefully."}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_21483385","line":2572,"range":{"start_line":2572,"start_character":12,"end_line":2572,"end_character":35},"updated":"2017-12-19 06:03:37.000000000","message":"guess a debug message might helpful here","commit_id":"b9b156e71a7ad154cc73114ef714a707a58ab6cb"},{"author":{"_account_id":19944,"name":"Chen Hanxiao","email":"chen_han_xiao@126.com","username":"chenhanxiao"},"change_message_id":"db8ce46926d3e423ee22914838a8317eef59bc09","unresolved":false,"context_lines":[{"line_number":2569,"context_line":"        guest \u003d self._host.get_guest(instance)"},{"line_number":2570,"context_line":"        guest.resume()"},{"line_number":2571,"context_line":"        if instance.image_meta.properties.get(\u0027hw_qemu_guest_agent\u0027, False):"},{"line_number":2572,"context_line":"            guest.sync_guest_time()"},{"line_number":2573,"context_line":""},{"line_number":2574,"context_line":"    def _clean_shutdown(self, instance, timeout, retry_interval):"},{"line_number":2575,"context_line":"        \"\"\"Attempt to shutdown the instance gracefully."}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_d0f6ee5d","line":2572,"range":{"start_line":2572,"start_character":12,"end_line":2572,"end_character":35},"in_reply_to":"df87a7cf_21483385","updated":"2017-12-19 10:58:41.000000000","message":"Done","commit_id":"b9b156e71a7ad154cc73114ef714a707a58ab6cb"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"78ac38321b221240bde953ea636d1bfa150ca0d1","unresolved":false,"context_lines":[{"line_number":2569,"context_line":"        guest \u003d self._host.get_guest(instance)"},{"line_number":2570,"context_line":"        guest.resume()"},{"line_number":2571,"context_line":"        if instance.image_meta.properties.get(\u0027hw_qemu_guest_agent\u0027, False):"},{"line_number":2572,"context_line":"            guest.sync_guest_time()"},{"line_number":2573,"context_line":"        else:"},{"line_number":2574,"context_line":"            LOG.debug(\"Guest agent disabled, skip sync_guest_time\","},{"line_number":2575,"context_line":"                    instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f91af0f_bcdd8171","line":2572,"updated":"2018-01-04 22:06:01.000000000","message":"The message you want to make it disappear is DEBUG log and that code is like:\n\nnova/virt/libvirt/guest.py\n 174             elif code \u003d\u003d libvirt.VIR_ERR_ARGUMENT_UNSUPPORTED:\n 175                 LOG.debug(\u0027Failed to set time: agent not configured\u0027,\n 176                           instance_uuid\u003dself.uuid)\n\nSo the original code seems to try it and it\u0027s ok even if  it fails. So I guess current code is not so bad.\n\nMy small concern is that this kind of check in caller side could make maintenance hard in long-term because we will need to take care of called sides every time.","commit_id":"87b661765dbe08f5d0ee068ed38e0bb5e35a93bd"}]}