)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"91846fbec814fbabd3b4f88584170f94b3145047","unresolved":false,"context_lines":[{"line_number":7,"context_line":"libvirt: remove TODO on validation of scsi model"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We\u0027ve already validated scsi model in"},{"line_number":10,"context_line":"nova.object.fields.SCSIModelField()"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2b164515368d4680f37a6e9f2d4328bebf5680ed"},{"line_number":13,"context_line":"Signed-off-by: Chen Hanxiao \u003cchenhx@certusnet.com.cn\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f93b717_620f2c37","line":10,"updated":"2018-01-30 08:34:47.000000000","message":"This validation is generic of all the virt drivers. some SCSI models can be available in one driver where not supported in an other. The point of this TODO is to validate those which are supported in context of libvirt driver.","commit_id":"07cfc77cb5a3901b1dbe0a6dc3c18f73f00fdf94"},{"author":{"_account_id":19944,"name":"Chen Hanxiao","email":"chen_han_xiao@126.com","username":"chenhanxiao"},"change_message_id":"55ad7a965c673ee825df6d7c814793a23d20821b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"libvirt: remove TODO on validation of scsi model"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We\u0027ve already validated scsi model in"},{"line_number":10,"context_line":"nova.object.fields.SCSIModelField()"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2b164515368d4680f37a6e9f2d4328bebf5680ed"},{"line_number":13,"context_line":"Signed-off-by: Chen Hanxiao \u003cchenhx@certusnet.com.cn\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"5f93b717_4b430d6d","line":10,"in_reply_to":"5f93b717_620f2c37","updated":"2018-01-31 07:20:43.000000000","message":"I checked code of libvirt, all models listed in SCSIModelField is existed in virDomainControllerModelSCSI.\nSo it\u0027s OK to rely on the validation from SCSIModelField.","commit_id":"07cfc77cb5a3901b1dbe0a6dc3c18f73f00fdf94"}],"nova/exception.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8731c41b8ae8c8c690c998531f6922e4e0ce34fd","unresolved":false,"context_lines":[{"line_number":2207,"context_line":"    msg_fmt \u003d _(\"Cannot migrate to the host where the server exists.\")"},{"line_number":2208,"context_line":""},{"line_number":2209,"context_line":""},{"line_number":2210,"context_line":"class UnsupportedScsiControllerModel(Invalid):"},{"line_number":2211,"context_line":"    msg_fmt \u003d _(\"Scsi contriller model \u0027%(model)\u0027 is not supported\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_f6ca6118","line":2210,"range":{"start_line":2210,"start_character":17,"end_line":2210,"end_character":21},"updated":"2017-12-05 11:52:33.000000000","message":"SCSI","commit_id":"e52a21b3d9170ab20a0e5c3a68d010ab6fab0d02"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8731c41b8ae8c8c690c998531f6922e4e0ce34fd","unresolved":false,"context_lines":[{"line_number":2208,"context_line":""},{"line_number":2209,"context_line":""},{"line_number":2210,"context_line":"class UnsupportedScsiControllerModel(Invalid):"},{"line_number":2211,"context_line":"    msg_fmt \u003d _(\"Scsi contriller model \u0027%(model)\u0027 is not supported\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_76517162","line":2211,"range":{"start_line":2211,"start_character":17,"end_line":2211,"end_character":21},"updated":"2017-12-05 11:52:33.000000000","message":"SCSI","commit_id":"e52a21b3d9170ab20a0e5c3a68d010ab6fab0d02"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"8731c41b8ae8c8c690c998531f6922e4e0ce34fd","unresolved":false,"context_lines":[{"line_number":2208,"context_line":""},{"line_number":2209,"context_line":""},{"line_number":2210,"context_line":"class UnsupportedScsiControllerModel(Invalid):"},{"line_number":2211,"context_line":"    msg_fmt \u003d _(\"Scsi contriller model \u0027%(model)\u0027 is not supported\")"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_5656ad5e","line":2211,"range":{"start_line":2211,"start_character":22,"end_line":2211,"end_character":32},"updated":"2017-12-05 11:52:33.000000000","message":"controller","commit_id":"e52a21b3d9170ab20a0e5c3a68d010ab6fab0d02"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"89ad9ee2ff059b4a46b731b7ec53be67ddf415da","unresolved":false,"context_lines":[{"line_number":2208,"context_line":""},{"line_number":2209,"context_line":""},{"line_number":2210,"context_line":"class UnsupportedSCSIControllerModel(Invalid):"},{"line_number":2211,"context_line":"    msg_fmt \u003d _(\"SCSI controller model \u0027%(model)\u0027 is not supported\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_1887ddd9","line":2211,"range":{"start_line":2211,"start_character":40,"end_line":2211,"end_character":48},"updated":"2017-12-06 02:58:12.000000000","message":"%(model)s","commit_id":"aa31375eb64ef83dc3ae2b9381f6d03973b06c8e"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"d866cc9d4ac7fefbc1a28e142e5f9989faf59051","unresolved":false,"context_lines":[{"line_number":4083,"context_line":"            \"disk_format\": \"raw\","},{"line_number":4084,"context_line":"            \"properties\": {\"hw_scsi_model\": \"virtio-scsi\","},{"line_number":4085,"context_line":"                           \"hw_disk_bus\": \"scsi\"}})"},{"line_number":4086,"context_line":"        with mock.patch.object(image_meta.properties, \u0027get\u0027,"},{"line_number":4087,"context_line":"                return_value\u003d\u0027fake-scsi\u0027) as mock_image_meta:"},{"line_number":4088,"context_line":"            self.assertRaises(exception.UnsupportedSCSIControllerModel,"},{"line_number":4089,"context_line":"                    drvr._get_scsi_controller,"},{"line_number":4090,"context_line":"                    mock_image_meta)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f93b717_d5a125ab","line":4087,"range":{"start_line":4086,"start_character":8,"end_line":4087,"end_character":61},"updated":"2018-01-29 23:54:42.000000000","message":"If we have to mock out the object, how would we get into this scenario for real? Wouldn\u0027t we fail long before this when trying to create the ImageMeta object in the API?","commit_id":"1e3c4440bbd5a82288cf6d5aaf1424f64bf4ebb5"},{"author":{"_account_id":19944,"name":"Chen Hanxiao","email":"chen_han_xiao@126.com","username":"chenhanxiao"},"change_message_id":"b55d036b4bcb5ee589625facdfaddfd6423c1bc3","unresolved":false,"context_lines":[{"line_number":4083,"context_line":"            \"disk_format\": \"raw\","},{"line_number":4084,"context_line":"            \"properties\": {\"hw_scsi_model\": \"virtio-scsi\","},{"line_number":4085,"context_line":"                           \"hw_disk_bus\": \"scsi\"}})"},{"line_number":4086,"context_line":"        with mock.patch.object(image_meta.properties, \u0027get\u0027,"},{"line_number":4087,"context_line":"                return_value\u003d\u0027fake-scsi\u0027) as mock_image_meta:"},{"line_number":4088,"context_line":"            self.assertRaises(exception.UnsupportedSCSIControllerModel,"},{"line_number":4089,"context_line":"                    drvr._get_scsi_controller,"},{"line_number":4090,"context_line":"                    mock_image_meta)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f93b717_87e5aa0b","line":4087,"range":{"start_line":4086,"start_character":8,"end_line":4087,"end_character":61},"in_reply_to":"5f93b717_d5a125ab","updated":"2018-01-30 07:17:45.000000000","message":"My fault.\nWe\u0027ve already did the validation, just remove TODO. Sorry for that.\nThanks for the review.","commit_id":"1e3c4440bbd5a82288cf6d5aaf1424f64bf4ebb5"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":18529,"name":"Dongdong Pei","email":"peidongdong121@163.com","username":"dongdongpei"},"change_message_id":"2e8f2ee2507e0b4908a021921e211fa02ffa32ba","unresolved":false,"context_lines":[{"line_number":3769,"context_line":"        if image_meta.properties.get(\u0027hw_scsi_model\u0027):"},{"line_number":3770,"context_line":"            hw_scsi_model \u003d image_meta.properties.hw_scsi_model"},{"line_number":3771,"context_line":"            if hw_scsi_model not in fields.SCSIModel.ALL:"},{"line_number":3772,"context_line":"                raise exception.UnsupportedSCSIControllerModel(hw_scsi_model)"},{"line_number":3773,"context_line":"            scsi_controller \u003d vconfig.LibvirtConfigGuestController()"},{"line_number":3774,"context_line":"            scsi_controller.type \u003d \u0027scsi\u0027"},{"line_number":3775,"context_line":"            scsi_controller.model \u003d hw_scsi_model"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf8cb3f7_9c5b2886","line":3772,"range":{"start_line":3772,"start_character":63,"end_line":3772,"end_character":76},"updated":"2017-12-21 10:26:32.000000000","message":"model\u003dhw_scsi_model","commit_id":"2dad8eb9da503649e5cc2a48cae1eb3560c560a5"},{"author":{"_account_id":19944,"name":"Chen Hanxiao","email":"chen_han_xiao@126.com","username":"chenhanxiao"},"change_message_id":"619fcb33e2ecc208a499b7a0fdcfc7762c85d917","unresolved":false,"context_lines":[{"line_number":3769,"context_line":"        if image_meta.properties.get(\u0027hw_scsi_model\u0027):"},{"line_number":3770,"context_line":"            hw_scsi_model \u003d image_meta.properties.hw_scsi_model"},{"line_number":3771,"context_line":"            if hw_scsi_model not in fields.SCSIModel.ALL:"},{"line_number":3772,"context_line":"                raise exception.UnsupportedSCSIControllerModel(hw_scsi_model)"},{"line_number":3773,"context_line":"            scsi_controller \u003d vconfig.LibvirtConfigGuestController()"},{"line_number":3774,"context_line":"            scsi_controller.type \u003d \u0027scsi\u0027"},{"line_number":3775,"context_line":"            scsi_controller.model \u003d hw_scsi_model"}],"source_content_type":"text/x-python","patch_set":4,"id":"bf8cb3f7_4fae44e8","line":3772,"range":{"start_line":3772,"start_character":63,"end_line":3772,"end_character":76},"in_reply_to":"bf8cb3f7_9c5b2886","updated":"2017-12-21 10:49:31.000000000","message":"Ahh, thanks! will be fixed soon","commit_id":"2dad8eb9da503649e5cc2a48cae1eb3560c560a5"}]}