)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"918d9ed80fbdf22ab2b2eede8c7cfad433aeb39f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Adds XenAPIMigrationTestBase which inherits from NoDB"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"* Split tests into separate classes to better share setUp logic"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"* Added test_xenserver_5 for completeness"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAATn%2F%2FlO4%3D","line":11,"updated":"2013-10-31 23:12:55.000000000","message":"BTW: https://rbtcollins.wordpress.com/2010/09/18/maintainable-pyunit-test-suites-fixtures/ - rather than reusing via setUp, consider wrapping that into a Fixture and using that - it\u0027s much more flexible.","commit_id":"4fa4cda63c7f11c79ce608b3d65f88bced719c64"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"6c4f1de7439933979549aef7b7acf44a9bcba7e7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Adds XenAPIMigrationTestBase which inherits from NoDB"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"* Split tests into separate classes to better share setUp logic"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"* Added test_xenserver_5 for completeness"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAATn%2F%2FjBg%3D","line":11,"in_reply_to":"AAAATn%2F%2FlO4%3D","updated":"2013-11-01 15:37:58.000000000","message":"Yeah, fixtures definitely have their place. I think inheritance here is fine, and actually quite natural, but long-term, it might be nice to decompose some of the setUp work into generic, reusable fixtures.","commit_id":"4fa4cda63c7f11c79ce608b3d65f88bced719c64"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"918d9ed80fbdf22ab2b2eede8c7cfad433aeb39f","unresolved":false,"context_lines":[{"line_number":15,"context_line":"* Removed revert-migrate tests because they were _literally_ just testing that"},{"line_number":16,"context_line":"  driver.py proxies the call back to vmops (the finish migrate tests aren\u0027t"},{"line_number":17,"context_line":"  terribly useful either, but at least they\u0027re testing that lower-level"},{"line_number":18,"context_line":"  functions are hit so we\u0027re getting some integration-test benefits)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Id0a5d28f59887926f115ddbf7bc96642b90b9667"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAATn%2F%2FlOg%3D","line":18,"updated":"2013-10-31 23:12:55.000000000","message":"This changeset appears to have 5 distinct changes: https://wiki.openstack.org/wiki/GitCommitMessages#Structural_split_of_changes\n\nI would appreciate it if you would split it into 5 changesets, to aid review. Thanks!","commit_id":"4fa4cda63c7f11c79ce608b3d65f88bced719c64"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"6c4f1de7439933979549aef7b7acf44a9bcba7e7","unresolved":false,"context_lines":[{"line_number":15,"context_line":"* Removed revert-migrate tests because they were _literally_ just testing that"},{"line_number":16,"context_line":"  driver.py proxies the call back to vmops (the finish migrate tests aren\u0027t"},{"line_number":17,"context_line":"  terribly useful either, but at least they\u0027re testing that lower-level"},{"line_number":18,"context_line":"  functions are hit so we\u0027re getting some integration-test benefits)"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Id0a5d28f59887926f115ddbf7bc96642b90b9667"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAATn%2F%2FjCI%3D","line":18,"in_reply_to":"AAAATn%2F%2FlOg%3D","updated":"2013-11-01 15:37:58.000000000","message":"I don\u0027t know that having 5 separate changesets here would be necessarily easier to review. IMHO these 5 alterations are small enough, and work harmoniously enough to constitute a single, logical change: Fix up the broken TestMigrationClass.\n\nThis change had actually received two +2s, but just needed a rebase.\n\nSplitting it into 5 changesets would just require lengthen the time until it merges, requiring even more rebasing.","commit_id":"4fa4cda63c7f11c79ce608b3d65f88bced719c64"}],"nova/tests/virt/xenapi/test_xenapi.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"f265bbcfdd997f4283fd57115f506df177c2bcd8","unresolved":false,"context_lines":[{"line_number":1580,"context_line":"        self.virtapi \u003d self.vmops._virtapi"},{"line_number":1581,"context_line":"        self.session \u003d self.vmops._session"},{"line_number":1582,"context_line":""},{"line_number":1583,"context_line":"        self.instance \u003d {\u0027id\u0027: 1,"},{"line_number":1584,"context_line":"                         \u0027uuid\u0027: \u0027fakeuuid\u0027,"},{"line_number":1585,"context_line":"                         \u0027project_id\u0027: \u0027fakeproject\u0027,"},{"line_number":1586,"context_line":"                         \u0027user_id\u0027: \u0027fakeuser\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FrIk%3D","line":1583,"updated":"2013-10-30 15:36:05.000000000","message":"eventually would be good to use the instance object.","commit_id":"ec3144a388f88f9c96a37659a956201b47c90ce4"}]}