)]}'
{"id":"openstack%2Fnova~52519","triplet_id":"openstack%2Fnova~master~Ib384c84e2954bd303661386256053b3c1ad38239","project":"openstack/nova","branch":"master","topic":"bug/1241117","hashtags":[],"change_id":"Ib384c84e2954bd303661386256053b3c1ad38239","subject":"Clean up test cases for compute.manager._check_instance_build_time","status":"MERGED","created":"2013-10-17 21:40:38.000000000","updated":"2013-12-06 21:24:04.000000000","submitted":"2013-12-06 21:24:01.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":26,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8f256be6f5c2e4a68ab45d52326086268d53b8c6","_number":52519,"virtual_id_number":52519,"owner":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},{"value":0,"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},{"value":0,"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":2,"date":"2013-12-06 21:24:01.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":5371,"name":"Mathew Odden","email":"locke105@gmail.com","username":"locke105"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":4912,"name":"Michael H Wilson","email":"geekinutah@gmail.com","username":"geekinutah"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"all":[{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},{"value":2,"date":"2013-12-06 11:47:10.000000000","_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},{"value":0,"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},{"value":2,"date":"2013-12-06 18:19:33.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-12-05 19:37:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},{"value":0,"date":"2013-12-03 22:02:43.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":5371,"name":"Mathew Odden","email":"locke105@gmail.com","username":"locke105"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":1,"date":"2013-12-03 22:31:28.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":1,"date":"2013-12-06 01:48:18.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":4912,"name":"Michael H Wilson","email":"geekinutah@gmail.com","username":"geekinutah"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"all":[{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},{"value":0,"date":"2013-12-06 11:47:10.000000000","_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},{"value":0,"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},{"value":1,"date":"2013-12-06 18:19:33.000000000","_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},{"value":0,"date":"2013-12-03 22:02:43.000000000","_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":5371,"name":"Mathew Odden","email":"locke105@gmail.com","username":"locke105"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":4912,"name":"Michael H Wilson","email":"geekinutah@gmail.com","username":"geekinutah"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},{"value":0,"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},{"value":0,"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},{"value":0,"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"value":0,"_account_id":5371,"name":"Mathew Odden","email":"locke105@gmail.com","username":"locke105"},{"value":0,"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"value":0,"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":4912,"name":"Michael H Wilson","email":"geekinutah@gmail.com","username":"geekinutah"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":4912,"name":"Michael H Wilson","email":"geekinutah@gmail.com","username":"geekinutah"},{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},{"_account_id":5371,"name":"Mathew Odden","email":"locke105@gmail.com","username":"locke105"},{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-10-18 22:35:21.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2013-10-21 16:56:30.000000000","updated_by":{"_account_id":5371,"name":"Mathew Odden","email":"locke105@gmail.com","username":"locke105"},"reviewer":{"_account_id":5371,"name":"Mathew Odden","email":"locke105@gmail.com","username":"locke105"},"state":"REVIEWER"},{"updated":"2013-10-22 13:36:12.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2013-11-18 17:46:57.000000000","updated_by":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"reviewer":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"state":"REVIEWER"},{"updated":"2013-11-28 16:48:43.000000000","updated_by":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"reviewer":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"state":"REVIEWER"},{"updated":"2013-11-30 02:52:16.000000000","updated_by":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"reviewer":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"state":"REVIEWER"},{"updated":"2013-12-03 22:31:28.000000000","updated_by":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"reviewer":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"state":"REVIEWER"},{"updated":"2013-12-05 19:37:35.000000000","updated_by":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"reviewer":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"state":"REVIEWER"},{"updated":"2013-12-06 01:48:18.000000000","updated_by":{"_account_id":4912,"name":"Michael H Wilson","email":"geekinutah@gmail.com","username":"geekinutah"},"reviewer":{"_account_id":4912,"name":"Michael H Wilson","email":"geekinutah@gmail.com","username":"geekinutah"},"state":"REVIEWER"},{"updated":"2013-12-06 11:47:10.000000000","updated_by":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"reviewer":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"state":"REVIEWER"},{"updated":"2013-12-06 18:19:33.000000000","updated_by":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"reviewer":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"state":"REVIEWER"},{"updated":"2013-12-06 21:24:01.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"5d25b18cc1cb8fdff3a7ff4e6cf3230162d59cbf","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2013-10-17 21:42:45.000000000","message":"Patch Set 1:\n\nBefore anyone says it, yes, I would like the two test cases consolidated somehow, but my brain is kind of fried today and couldn\u0027t think of a clean way to handle the assertions in a common way since in one test they are all failures and in another 4/5 are failures in the list.  If anyone has suggestions on consolidating into a common test case, please feel free to comment.","accounts_in_message":[],"_revision_number":1},{"id":"4f9f3e3bbe6731685159468f2e9831c3d0892f2a","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2013-10-17 21:48:52.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"9448810ecea6c8dcdc100803099b439e876b5bc1","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-10-17 21:49:07.000000000","message":"Patch Set 2:\n\nNew patchset patch-id matches previous patchset, but whitespace content has changed.","accounts_in_message":[],"_revision_number":2},{"id":"596f7da259635e45b355f45982b3f6eeba0bdc33","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2013-10-17 21:49:24.000000000","message":"Patch Set 2:\n\nPatch set 2 fixes a pep8 error.","accounts_in_message":[],"_revision_number":2},{"id":"facc602461671bacdb1e197ac8667e6b53e28d40","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-17 22:42:29.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-nova-pep8 http://logs.openstack.org/19/52519/2/check/gate-nova-pep8/4e95226 : SUCCESS in 4m 37s\n- gate-nova-docs http://docs-draft.openstack.org/19/52519/2/check/gate-nova-docs/e41f551/doc/build/html/ : SUCCESS in 3m 44s\n- gate-nova-python26 http://logs.openstack.org/19/52519/2/check/gate-nova-python26/6b9f49a : SUCCESS in 16m 28s\n- gate-nova-python27 http://logs.openstack.org/19/52519/2/check/gate-nova-python27/dc76b0b : SUCCESS in 12m 14s\n- check-tempest-devstack-vm-full http://logs.openstack.org/19/52519/2/check/check-tempest-devstack-vm-full/bbac221 : SUCCESS in 53m 17s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/19/52519/2/check/check-tempest-devstack-vm-postgres-full/06bec0a : SUCCESS in 41m 00s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/19/52519/2/check/check-tempest-devstack-vm-neutron/3ce6815 : SUCCESS in 20m 47s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/19/52519/2/check/gate-tempest-devstack-vm-large-ops/56eba6b : SUCCESS in 16m 15s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/19/52519/2/check/gate-tempest-devstack-vm-neutron-large-ops/83383a1 : SUCCESS in 17m 17s (non-voting)\n- check-grenade-devstack-vm http://logs.openstack.org/19/52519/2/check/check-grenade-devstack-vm/7f16f62 : SUCCESS in 27m 23s\n- gate-devstack-vm-cells http://logs.openstack.org/19/52519/2/check/gate-devstack-vm-cells/b496170 : SUCCESS in 9m 16s (non-voting)\n- gate-nova-pylint http://logs.openstack.org/19/52519/2/check/gate-nova-pylint/93b795a : SUCCESS in 13m 17s (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"b8426655222014769191fcf3cd80ab785d221076","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-10-17 22:52:07.000000000","message":"Patch Set 2: Works for me\n\nSmokeStack Results (patch set 2):\n- Libvirt (Fedora 19) https://smokestack.openstack.org/?go\u003d/jobs/147086 : SUCCESS \n- Libvirt (Centos 6.4) https://smokestack.openstack.org/?go\u003d/jobs/147088 : SUCCESS \n- XenServer (Fedora 18) https://smokestack.openstack.org/?go\u003d/jobs/147087 : SUCCESS \n","accounts_in_message":[],"_revision_number":2},{"id":"db38f7179e87f71da28c40ef074447c1b1188d07","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2013-10-18 12:24:24.000000000","message":"Patch Set 2: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"94f92c41ed967516e2365c1b8af6f7b0850435a1","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2013-10-18 16:16:03.000000000","message":"Patch Set 2: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"4aaf377f8a54f46f6a9e8e6648ca37a29d4e36a3","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2013-10-18 16:22:20.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"f3c37970e2ceecfe454199b36a309e856810d5b4","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-18 16:57:07.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- gate-nova-pep8 http://logs.openstack.org/19/52519/3/check/gate-nova-pep8/89618fc : SUCCESS in 4m 55s\n- gate-nova-docs http://docs-draft.openstack.org/19/52519/3/check/gate-nova-docs/468e42a/doc/build/html/ : SUCCESS in 4m 21s\n- gate-nova-python26 http://logs.openstack.org/19/52519/3/check/gate-nova-python26/0a01f0a : SUCCESS in 20m 41s\n- gate-nova-python27 http://logs.openstack.org/19/52519/3/check/gate-nova-python27/c783628 : SUCCESS in 15m 31s\n- check-tempest-devstack-vm-full http://logs.openstack.org/19/52519/3/check/check-tempest-devstack-vm-full/58e269e : SUCCESS in 33m 32s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/19/52519/3/check/check-tempest-devstack-vm-postgres-full/f6ccdcf : SUCCESS in 33m 00s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/19/52519/3/check/check-tempest-devstack-vm-neutron/cd03d62 : SUCCESS in 23m 44s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/19/52519/3/check/gate-tempest-devstack-vm-large-ops/afd5d83 : SUCCESS in 13m 54s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/19/52519/3/check/gate-tempest-devstack-vm-neutron-large-ops/40fd84e : SUCCESS in 17m 13s (non-voting)\n- check-grenade-devstack-vm http://logs.openstack.org/19/52519/3/check/check-grenade-devstack-vm/85bb692 : SUCCESS in 34m 25s\n- gate-devstack-vm-cells http://logs.openstack.org/19/52519/3/check/gate-devstack-vm-cells/02fd117 : SUCCESS in 14m 48s (non-voting)\n- gate-nova-pylint http://logs.openstack.org/19/52519/3/check/gate-nova-pylint/e8ca361 : SUCCESS in 13m 17s (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"4266bcf12ea4d874f3a0cb0203e940a94e177e1d","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2013-10-18 17:53:21.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":3},{"id":"9fcaf9388047b5847d08c0f08ba9693ff1bf59b7","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2013-10-18 22:35:21.000000000","message":"Patch Set 3: I would prefer that you didn\u0027t merge this\n\nThis actually *always* clears task_state when we set the vm_state to ERROR, not just in the build timeout case, right? I doubt that all of the possible states you can get to this way are ones where we want task_state reset. Further, I think you\u0027ll need to distinguish between a regular failure and a the timeout case in order to avoid just letting the user continue to hit the rebuild button for a situation that isn\u0027t going to change, right?","accounts_in_message":[],"_revision_number":3},{"id":"61a527a71442e12ede37040e01959cdd266c5a35","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2013-10-21 15:16:53.000000000","message":"Patch Set 3: Work In Progress\n\nDan, good point, I\u0027ll plan on changing _set_instance_error_state to take a task_state arg that defaults to the empty string for backwards compat (if empty string, don\u0027t pass it to instance_update). Then will only pass task_state\u003dNone from _check_instance_build_time which is the build timeout case.","accounts_in_message":[],"_revision_number":3},{"id":"250c5ef133625a513c6c3d265c6ccffb7df22c17","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2013-10-21 15:33:26.000000000","message":"Patch Set 3:\n\nAlthough on second thought, if the instance goes to ERROR state can you do anything with it besides delete or rebuild?  And rebuild expects the task_state to be None in that case, so it would fail w/o this change (if it failed in a non-timeout case).  Maybe I\u0027m missing something though so I\u0027ll talk with Dan about it in IRC later.","accounts_in_message":[],"_revision_number":3},{"id":"331a8d45709d22240aceb884ca460d3db9d2f2ee","author":{"_account_id":5371,"name":"Mathew Odden","email":"locke105@gmail.com","username":"locke105"},"date":"2013-10-21 16:56:30.000000000","message":"Patch Set 3:\n\nSo it appears rebuild isn\u0027t allowed anyways unless the instance successfully spawns at least once. See this commit for details:\n\nhttps://github.com/openstack/nova/commit/99c51e34230394cadf0b82e364ea10c38e193979\n\nThis basically means this change is just a cosmetic state machine change. I don\u0027t think its worth doing anything here yet. Apparently the compute vm_state/task_state system is going to be re-visited in Icehouse.","accounts_in_message":[],"_revision_number":3},{"id":"ed4e474e7a7e5ca299c7bb159c30cf24d7117fb2","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2013-10-21 19:07:37.000000000","message":"Patch Set 3:\n\nAlright, well my plan is to add a note in the code to say \u0027hey, don\u0027t set task_state\u003dNone here because...\u0027 and then preserve the test case refactor since it\u0027s mock-tastic now.","accounts_in_message":[],"_revision_number":3},{"id":"359335ec47fa2ec03dee021662968131c461a9b3","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2013-10-22 12:43:02.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"70acb4ddfdf01efab930bef1d8243a61d8297cd1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-22 13:23:36.000000000","message":"Patch Set 4: Works for me\n\nBuild succeeded.\n\n- gate-nova-pep8 http://logs.openstack.org/19/52519/4/check/gate-nova-pep8/175b1d3 : SUCCESS in 4m 00s\n- gate-nova-docs http://docs-draft.openstack.org/19/52519/4/check/gate-nova-docs/e4e7016/doc/build/html/ : SUCCESS in 3m 59s\n- gate-nova-python26 http://logs.openstack.org/19/52519/4/check/gate-nova-python26/7e280c0 : SUCCESS in 18m 06s\n- gate-nova-python27 http://logs.openstack.org/19/52519/4/check/gate-nova-python27/c24f1ed : SUCCESS in 15m 20s\n- check-tempest-devstack-vm-full http://logs.openstack.org/19/52519/4/check/check-tempest-devstack-vm-full/8778140 : SUCCESS in 31m 39s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/19/52519/4/check/check-tempest-devstack-vm-postgres-full/a2dead6 : SUCCESS in 40m 15s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/19/52519/4/check/check-tempest-devstack-vm-neutron/5ce1e10 : SUCCESS in 18m 25s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/19/52519/4/check/gate-tempest-devstack-vm-large-ops/b7e4f78 : SUCCESS in 15m 44s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/19/52519/4/check/gate-tempest-devstack-vm-neutron-large-ops/e1a7f37 : SUCCESS in 16m 28s (non-voting)\n- check-grenade-devstack-vm http://logs.openstack.org/19/52519/4/check/check-grenade-devstack-vm/d4355dc : SUCCESS in 27m 37s\n- gate-devstack-vm-cells http://logs.openstack.org/19/52519/4/check/gate-devstack-vm-cells/0972350 : FAILURE in 10m 09s (non-voting)\n- gate-nova-pylint http://logs.openstack.org/19/52519/4/check/gate-nova-pylint/ff90217 : SUCCESS in 14m 32s (non-voting)\n","accounts_in_message":[],"_revision_number":4},{"id":"559dc3b60453aebe3e212070d43eef3c0ee83a54","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-10-22 13:36:12.000000000","message":"Patch Set 4: Works for me\n\nSmokeStack Results (patch set 4):\n- Libvirt (Fedora 19) https://smokestack.openstack.org/?go\u003d/jobs/148742 : SUCCESS \n- Libvirt (Centos 6.4) https://smokestack.openstack.org/?go\u003d/jobs/148744 : SUCCESS \n- XenServer (Fedora 18) https://smokestack.openstack.org/?go\u003d/jobs/148743 : SUCCESS \n","accounts_in_message":[],"_revision_number":4},{"id":"ae25dd53fc4b3b386d32e121b297cfe1bb9251a2","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2013-10-25 16:15:09.000000000","message":"Patch Set 4: (2 inline comments)\n\nCouple comments inline, nothing that mandates a -1 IMO though.","accounts_in_message":[],"_revision_number":4},{"id":"0acc7c806c1c755d2b2a8f9997dd4cb41584905c","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2013-10-25 16:21:57.000000000","message":"Patch Set 4: (2 inline comments)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"8bd945b376ef15a3cae06cb4c19aab80eb386e63","author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"date":"2013-11-07 22:18:26.000000000","message":"Patch Set 4: (3 inline comments)\n\nAll my things are suggestions, but I would love to see them done :)","accounts_in_message":[],"_revision_number":4},{"id":"65999986dd4d0dbb3ccaa98cef7fe4e11517d002","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2013-11-08 22:41:00.000000000","message":"Patch Set 4:\n\nRobert, thanks for the review, I\u0027m not ignoring, just been too busy to process this right now.  I\u0027ll definitely check out the suggestions. I\u0027ll take any kind of love on this one I can get because no one likes to review test case refactoring patches.","accounts_in_message":[],"_revision_number":4},{"id":"47cd7577ccf65a15a9b5cb747e564798a4814968","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2013-11-09 19:21:11.000000000","message":"Patch Set 4: (3 inline comments)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"e8202dc03c99f9d69554d72a5cd225d092deda54","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2013-11-09 19:28:03.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"5d1ed6843cf64c5d63a8d931e27a121104161b7a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-09 20:09:23.000000000","message":"Patch Set 5: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGit#Test_Failures\n\n- gate-nova-pep8 http://logs.openstack.org/19/52519/5/check/gate-nova-pep8/8657d07 : SUCCESS in 4m 33s\n- gate-nova-docs http://docs-draft.openstack.org/19/52519/5/check/gate-nova-docs/e616614/doc/build/html/ : SUCCESS in 3m 21s\n- gate-nova-python26 http://logs.openstack.org/19/52519/5/check/gate-nova-python26/a50ce18 : SUCCESS in 21m 35s\n- gate-nova-python27 http://logs.openstack.org/19/52519/5/check/gate-nova-python27/1a6b12e : SUCCESS in 16m 01s\n- check-tempest-devstack-vm-full http://logs.openstack.org/19/52519/5/check/check-tempest-devstack-vm-full/be0047b : SUCCESS in 33m 39s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/19/52519/5/check/check-tempest-devstack-vm-postgres-full/dfa6ff1 : FAILURE in 32m 44s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/19/52519/5/check/check-tempest-devstack-vm-neutron/98b689d : SUCCESS in 26m 15s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/19/52519/5/check/gate-tempest-devstack-vm-large-ops/b1d0b87 : SUCCESS in 13m 24s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/19/52519/5/check/gate-tempest-devstack-vm-neutron-large-ops/34618ad : FAILURE in 20m 30s (non-voting)\n- check-grenade-devstack-vm http://logs.openstack.org/19/52519/5/check/check-grenade-devstack-vm/b5efc55 : SUCCESS in 40m 58s\n- gate-devstack-vm-cells http://logs.openstack.org/19/52519/5/check/gate-devstack-vm-cells/9594740 : SUCCESS in 8m 23s (non-voting)\n- gate-nova-pylint http://logs.openstack.org/19/52519/5/check/gate-nova-pylint/56e5386 : SUCCESS in 14m 23s (non-voting)\n","accounts_in_message":[],"_revision_number":5},{"id":"864a003b0700afa96d9efc1b615a31d43a309d0d","author":{"_account_id":8871,"name":"Elastic Recheck","username":"elasticrecheck"},"date":"2013-11-09 20:09:35.000000000","message":"Patch Set 5:\n\nI noticed tempest failed, I think you hit bug(s): https://bugs.launchpad.net/bugs/1218391 and https://bugs.launchpad.net/bugs/1239856","accounts_in_message":[],"_revision_number":5},{"id":"11734efc435c83f28c4c2cea39c744ebdfa2a5e6","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2013-11-10 00:57:25.000000000","message":"Patch Set 5:\n\nrecheck bug 1239856","accounts_in_message":[],"_revision_number":5},{"id":"0b2ee2380ace634289ff12d070627acab108fbaf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-11-10 01:33:11.000000000","message":"Patch Set 5: Works for me\n\nBuild succeeded.\n\n- gate-nova-pep8 http://logs.openstack.org/19/52519/5/check/gate-nova-pep8/498f70a : SUCCESS in 4m 30s\n- gate-nova-docs http://docs-draft.openstack.org/19/52519/5/check/gate-nova-docs/ba1c617/doc/build/html/ : SUCCESS in 3m 20s\n- gate-nova-python26 http://logs.openstack.org/19/52519/5/check/gate-nova-python26/32fdca2 : SUCCESS in 17m 28s\n- gate-nova-python27 http://logs.openstack.org/19/52519/5/check/gate-nova-python27/961720b : SUCCESS in 16m 02s\n- check-tempest-devstack-vm-full http://logs.openstack.org/19/52519/5/check/check-tempest-devstack-vm-full/580e7ef : SUCCESS in 31m 53s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/19/52519/5/check/check-tempest-devstack-vm-postgres-full/8fea0ee : SUCCESS in 32m 33s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/19/52519/5/check/check-tempest-devstack-vm-neutron/8d2314d : SUCCESS in 25m 23s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/19/52519/5/check/gate-tempest-devstack-vm-large-ops/4884496 : SUCCESS in 13m 41s\n- gate-tempest-devstack-vm-neutron-large-ops http://logs.openstack.org/19/52519/5/check/gate-tempest-devstack-vm-neutron-large-ops/13ac559 : FAILURE in 20m 02s (non-voting)\n- check-grenade-devstack-vm http://logs.openstack.org/19/52519/5/check/check-grenade-devstack-vm/a40537e : SUCCESS in 35m 25s\n- gate-devstack-vm-cells http://logs.openstack.org/19/52519/5/check/gate-devstack-vm-cells/d0802b7 : SUCCESS in 8m 35s (non-voting)\n- gate-nova-pylint http://logs.openstack.org/19/52519/5/check/gate-nova-pylint/831b623 : SUCCESS in 14m 29s (non-voting)\n","accounts_in_message":[],"_revision_number":5},{"id":"8678878d98850ac97c4bc14572c72f162407f2a0","author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"date":"2013-11-12 18:57:26.000000000","message":"Patch Set 5: Looks good to me, but someone else must approve\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":5},{"id":"2483b0e53a5ced3e6ed958bef21029b5aedc6abe","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2013-11-12 19:27:58.000000000","message":"Patch Set 4: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":4},{"id":"b5fdfcd03fa3d3d37cb5187bb8c9a5c2aa915a84","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2013-11-12 19:28:14.000000000","message":"Patch Set 5: Looks good to me, but someone else must approve\n\nMy comments were addressed.","accounts_in_message":[],"_revision_number":5},{"id":"8f0a3eb1137544517e89e2681964d2a577be5a8a","author":{"_account_id":7040,"name":"GuoHui LIu","email":"liuguohui@gmail.com","username":"guohliu"},"date":"2013-11-18 17:46:57.000000000","message":"Patch Set 5: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":5},{"id":"ee44daba04dfaaf400641742307909d95fe02800","author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"date":"2013-11-28 16:48:43.000000000","message":"Patch Set 5: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":5},{"id":"c1201933ad03ba933fb735d5adcf6c4c2e17f411","author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"date":"2013-11-30 02:52:16.000000000","message":"Patch Set 5: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":5},{"id":"4b51dea855b3717f12b787b10528ad70d496c0ef","author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"date":"2013-12-03 16:18:59.000000000","message":"Patch Set 5: I would prefer that you didn\u0027t merge this\n\n(3 inline comments)\n\nMinor nits so whatever - but I\u0027d really like to see the import thing fixed.","accounts_in_message":[],"_revision_number":5},{"id":"c24f5f7e3bfa1f9f73b06b8864684fd39f756339","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2013-12-03 16:31:07.000000000","message":"Patch Set 5: (3 inline comments)\n\nI\u0027ll clean it up.","accounts_in_message":[],"_revision_number":5},{"id":"0443a4b37c8af325ef5dcc14990a91efafe879d1","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2013-12-03 16:43:17.000000000","message":"Patch Set 5: (3 inline comments)\n\n","accounts_in_message":[],"_revision_number":5},{"id":"ec38894df79a28beea112c2fef713bc5959c924f","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2013-12-03 16:58:30.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"4990cfa413aa1ea1a5e57ffcfa39ba50b7e34907","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-03 17:43:32.000000000","message":"Patch Set 6: Works for me\n\nBuild succeeded.\n\n- gate-nova-pep8 http://logs.openstack.org/19/52519/6/check/gate-nova-pep8/fcc1e5e : SUCCESS in 4m 22s\n- gate-nova-docs http://docs-draft.openstack.org/19/52519/6/check/gate-nova-docs/608a46a/doc/build/html/ : SUCCESS in 4m 40s\n- gate-nova-python26 http://logs.openstack.org/19/52519/6/check/gate-nova-python26/e96695e : SUCCESS in 21m 28s\n- gate-nova-python27 http://logs.openstack.org/19/52519/6/check/gate-nova-python27/37fad60 : SUCCESS in 14m 27s\n- check-tempest-dsvm-full http://logs.openstack.org/19/52519/6/check/check-tempest-dsvm-full/d9f444d : SUCCESS in 36m 46s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/19/52519/6/check/check-tempest-dsvm-postgres-full/ff7c5d1 : SUCCESS in 44m 41s\n- check-tempest-dsvm-neutron http://logs.openstack.org/19/52519/6/check/check-tempest-dsvm-neutron/228da3c : SUCCESS in 35m 05s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/19/52519/6/check/gate-tempest-dsvm-large-ops/1471ed5 : SUCCESS in 15m 03s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/19/52519/6/check/gate-tempest-dsvm-neutron-large-ops/313f224 : SUCCESS in 15m 22s\n- check-grenade-dsvm http://logs.openstack.org/19/52519/6/check/check-grenade-dsvm/a37b2a1 : SUCCESS in 34m 30s\n- gate-devstack-dsvm-cells http://logs.openstack.org/19/52519/6/check/gate-devstack-dsvm-cells/2c2184e : SUCCESS in 10m 59s (non-voting)\n- gate-nova-pylint http://logs.openstack.org/19/52519/6/check/gate-nova-pylint/e82b445 : SUCCESS in 13m 36s (non-voting)\n","accounts_in_message":[],"_revision_number":6},{"id":"23f01fa54e712f3daa99da3b6084bfdb2a3ee368","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2013-12-03 21:48:25.000000000","message":"Patch Set 6: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":6},{"id":"4999e04279f2f90aed1db2afe93f04083b8b36b8","author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"date":"2013-12-03 22:02:43.000000000","message":"Patch Set 6: (1 inline comment)\n\n","accounts_in_message":[],"_revision_number":6},{"id":"134c02128b3df3e36347094c1bc28ffa442f8572","author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"date":"2013-12-03 22:31:28.000000000","message":"Patch Set 6: Looks good to me, but someone else must approve\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":6},{"id":"631dc746bd5c97636e7f4f1ce62c73444bdebdc0","author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"date":"2013-12-05 19:37:35.000000000","message":"Patch Set 6: Looks good to me, but someone else must approve\n\nWe really should land this before more conflicts hit it up.","accounts_in_message":[],"_revision_number":6},{"id":"dd276d604af73d4bdf164e818ec4629773433f82","author":{"_account_id":4912,"name":"Michael H Wilson","email":"geekinutah@gmail.com","username":"geekinutah"},"date":"2013-12-06 01:48:18.000000000","message":"Patch Set 6: Looks good to me, but someone else must approve\n\nlgtm","accounts_in_message":[],"_revision_number":6},{"id":"21c2d5fb2959961ccec6b6b38a72d56420a8783c","author":{"_account_id":5511,"name":"Nikola Dipanov","email":"ndipanov@redhat.com","username":"ndipanov"},"date":"2013-12-06 11:47:10.000000000","message":"Patch Set 6: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":6},{"id":"c8dbf1a6ee0e9e75ed3324330cd6f25083882772","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2013-12-06 18:19:33.000000000","message":"Patch Set 6: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":6},{"id":"cb45c667eec5dad501a19ac6e7f233eeb02712b6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-06 18:19:36.000000000","message":"Patch Set 6: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":6},{"id":"06283d1cdce749c9ce9f77fe87c94fdf54eb40af","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-06 21:24:01.000000000","message":"Patch Set 6: Verified\n\nBuild succeeded.\n\n- gate-nova-docs http://docs-draft.openstack.org/19/52519/6/gate/gate-nova-docs/f4071ed/doc/build/html/ : SUCCESS in 3m 55s\n- gate-nova-pep8 http://logs.openstack.org/19/52519/6/gate/gate-nova-pep8/f42cb1b : SUCCESS in 4m 58s\n- gate-nova-python26 http://logs.openstack.org/19/52519/6/gate/gate-nova-python26/b4021ff : SUCCESS in 20m 01s\n- gate-nova-python27 http://logs.openstack.org/19/52519/6/gate/gate-nova-python27/c17add0 : SUCCESS in 12m 38s\n- gate-tempest-dsvm-full http://logs.openstack.org/19/52519/6/gate/gate-tempest-dsvm-full/a662fe2 : SUCCESS in 39m 40s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/19/52519/6/gate/gate-tempest-dsvm-postgres-full/1255561 : SUCCESS in 46m 46s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/19/52519/6/gate/gate-tempest-dsvm-neutron/7147708 : SUCCESS in 26m 31s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/19/52519/6/gate/gate-tempest-dsvm-large-ops/1f70989 : SUCCESS in 13m 55s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/19/52519/6/gate/gate-tempest-dsvm-neutron-large-ops/e90e64c : SUCCESS in 13m 07s\n- gate-grenade-dsvm http://logs.openstack.org/19/52519/6/gate/gate-grenade-dsvm/6c0b227 : SUCCESS in 24m 31s\n","accounts_in_message":[],"_revision_number":6},{"id":"5e0bcb07439667557421042849d05690434c1976","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-06 21:24:04.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"ace4c9c0545e4887b9389a8136414adac101f048","revisions":{"14de424fcb4182e26f2c0c6c038d099ee1301cef":{"kind":"REWORK","_number":1,"created":"2013-10-17 21:40:38.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/19/52519/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/19/52519/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/19/52519/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/19/52519/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/19/52519/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/19/52519/1"}}},"commit":{"parents":[{"commit":"5f3dd2ea043279d0e49ad1f088ee68034c98fc84","subject":"Merge \"Fixes Hyper-V snapshot spawning issue\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/5f3dd2ea043279d0e49ad1f088ee68034c98fc84"}]}],"author":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2013-10-17 21:09:33.000000000","tz":-420},"committer":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2013-10-17 21:38:28.000000000","tz":-420},"subject":"Reset task_state when instance fails to build due to timeout","message":"Reset task_state when instance fails to build due to timeout\n\nWhen an instance fails to build due to a timeout the vm_state is set to\nERROR but the task_state is left as-is which can cause a problem when\ntrying to rebuild since the rebuild API expects the task_state to be\nNone.\n\nThis patch sets the task_state to None in the build failure case and\nalso cleans up the unit tests related to the _check_instance_build_time\nmethod so that they are actually verifying the expected vm_state and\ntask_state values when the instance is updated.\n\nCloses-Bug: #1241117\n\nChange-Id: Ib384c84e2954bd303661386256053b3c1ad38239\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/14de424fcb4182e26f2c0c6c038d099ee1301cef"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/14de424fcb4182e26f2c0c6c038d099ee1301cef"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"5f3dd2ea043279d0e49ad1f088ee68034c98fc84","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"de460045a66ee1300aff305719eefba5be46aca1":{"kind":"REWORK","_number":2,"created":"2013-10-17 21:48:52.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/19/52519/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/19/52519/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/19/52519/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/19/52519/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/19/52519/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/19/52519/2"}}},"commit":{"parents":[{"commit":"5f3dd2ea043279d0e49ad1f088ee68034c98fc84","subject":"Merge \"Fixes Hyper-V snapshot spawning issue\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/5f3dd2ea043279d0e49ad1f088ee68034c98fc84"}]}],"author":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2013-10-17 21:09:33.000000000","tz":-420},"committer":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2013-10-17 21:46:09.000000000","tz":-420},"subject":"Reset task_state when instance fails to build due to timeout","message":"Reset task_state when instance fails to build due to timeout\n\nWhen an instance fails to build due to a timeout the vm_state is set to\nERROR but the task_state is left as-is which can cause a problem when\ntrying to rebuild since the rebuild API expects the task_state to be\nNone.\n\nThis patch sets the task_state to None in the build failure case and\nalso cleans up the unit tests related to the _check_instance_build_time\nmethod so that they are actually verifying the expected vm_state and\ntask_state values when the instance is updated.\n\nCloses-Bug: #1241117\n\nChange-Id: Ib384c84e2954bd303661386256053b3c1ad38239\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/de460045a66ee1300aff305719eefba5be46aca1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/de460045a66ee1300aff305719eefba5be46aca1"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"5f3dd2ea043279d0e49ad1f088ee68034c98fc84","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"36dc8285b52e14157961b4f7c40e52d3bba198ed":{"kind":"REWORK","_number":3,"created":"2013-10-18 16:22:20.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/19/52519/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/19/52519/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/19/52519/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/19/52519/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/19/52519/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/19/52519/3"}}},"commit":{"parents":[{"commit":"2b9c147626ff82c86a400c420b928bf2e321c531","subject":"Merge \"Fail quickly if file injection for boot volume\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/2b9c147626ff82c86a400c420b928bf2e321c531"}]}],"author":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2013-10-17 21:09:33.000000000","tz":-420},"committer":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2013-10-18 16:17:45.000000000","tz":-420},"subject":"Reset task_state when instance fails to build due to timeout","message":"Reset task_state when instance fails to build due to timeout\n\nWhen an instance fails to build due to a timeout the vm_state is set to\nERROR but the task_state is left as-is which can cause a problem when\ntrying to rebuild since the rebuild API expects the task_state to be\nNone.\n\nThis patch sets the task_state to None in the build failure case and\nalso cleans up the unit tests related to the _check_instance_build_time\nmethod so that they are actually verifying the expected vm_state and\ntask_state values when the instance is updated.\n\nThis patch also removes the test_instance_build_timeout test case\nsince it was completely redundant with the other one modified\nhere. I checked the git history and both test cases were added\nin the same commit which confirms that they weren\u0027t added for\ndifferent reasons, i.e. separate bug fixes/use cases.\n\nCloses-Bug: #1241117\n\nChange-Id: Ib384c84e2954bd303661386256053b3c1ad38239\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/36dc8285b52e14157961b4f7c40e52d3bba198ed"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/36dc8285b52e14157961b4f7c40e52d3bba198ed"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"2b9c147626ff82c86a400c420b928bf2e321c531","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"340414425d7dbdd7500ddec3e39e5853a730ca0f":{"kind":"REWORK","_number":4,"created":"2013-10-22 12:43:02.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/19/52519/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/19/52519/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/19/52519/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/19/52519/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/19/52519/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/19/52519/4"}}},"commit":{"parents":[{"commit":"37e143c4eb701d716dc61ba08d3b0119c82594f5","subject":"Merge \"Remove .pyc files before generating sample conf.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/37e143c4eb701d716dc61ba08d3b0119c82594f5"}]}],"author":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2013-10-17 21:09:33.000000000","tz":-420},"committer":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2013-10-22 12:42:21.000000000","tz":-420},"subject":"Clean up test cases for compute.manager._check_instance_build_time","message":"Clean up test cases for compute.manager._check_instance_build_time\n\nThis patch cleans up the unit tests related to the\n_check_instance_build_time\nmethod so that they are actually verifying the expected vm_state value\nwhen the instance is updated.\n\nThis patch also removes the test_instance_build_timeout test case\nsince it was completely redundant with the other one modified\nhere. I checked the git history and both test cases were added\nin the same commit which confirms that they weren\u0027t added for\ndifferent reasons, i.e. separate bug fixes/use cases.\n\nChange-Id: Ib384c84e2954bd303661386256053b3c1ad38239\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/340414425d7dbdd7500ddec3e39e5853a730ca0f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/340414425d7dbdd7500ddec3e39e5853a730ca0f"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"37e143c4eb701d716dc61ba08d3b0119c82594f5","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"84f6680995f47372ed1fe3d9d0527ae703d2bfca":{"kind":"REWORK","_number":5,"created":"2013-11-09 19:28:03.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/19/52519/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/19/52519/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/19/52519/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/19/52519/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/19/52519/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/19/52519/5"}}},"commit":{"parents":[{"commit":"5ac0475845e1c7ee8cc19b38d37a0af7a3f4c1fa","subject":"Merge \"Move docker specific options into a group.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/5ac0475845e1c7ee8cc19b38d37a0af7a3f4c1fa"}]}],"author":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2013-10-17 21:09:33.000000000","tz":-420},"committer":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2013-11-09 19:27:32.000000000","tz":-480},"subject":"Clean up test cases for compute.manager._check_instance_build_time","message":"Clean up test cases for compute.manager._check_instance_build_time\n\nThis patch cleans up the unit tests related to the\n_check_instance_build_time method so that they are actually verifying\nthe expected vm_state value when the instance is updated.\n\nThis patch also removes the test_instance_build_timeout test case\nsince it was completely redundant with the other one modified\nhere. I checked the git history and both test cases were added\nin the same commit which confirms that they weren\u0027t added for\ndifferent reasons, i.e. separate bug fixes/use cases.\n\nChange-Id: Ib384c84e2954bd303661386256053b3c1ad38239\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/84f6680995f47372ed1fe3d9d0527ae703d2bfca"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/84f6680995f47372ed1fe3d9d0527ae703d2bfca"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"5ac0475845e1c7ee8cc19b38d37a0af7a3f4c1fa","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"ace4c9c0545e4887b9389a8136414adac101f048":{"kind":"REWORK","_number":6,"created":"2013-12-03 16:58:30.000000000","uploader":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"ref":"refs/changes/19/52519/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/19/52519/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/19/52519/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/19/52519/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/19/52519/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/19/52519/6"}}},"commit":{"parents":[{"commit":"6a1667424a12b192402276ee81eb26a87bbb08f8","subject":"Merge \"Remove _security_group_chain_name from nova/virt/firewall.py\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6a1667424a12b192402276ee81eb26a87bbb08f8"}]}],"author":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2013-10-17 21:09:33.000000000","tz":-420},"committer":{"name":"Matt Riedemann","email":"mriedem@us.ibm.com","date":"2013-12-03 16:57:59.000000000","tz":-480},"subject":"Clean up test cases for compute.manager._check_instance_build_time","message":"Clean up test cases for compute.manager._check_instance_build_time\n\nThis patch cleans up the unit tests related to the\n_check_instance_build_time method so that they are actually verifying\nthe expected vm_state value when the instance is updated.\n\nThis patch also removes the test_instance_build_timeout test case\nsince it was completely redundant with the other one modified\nhere. I checked the git history and both test cases were added\nin the same commit which confirms that they weren\u0027t added for\ndifferent reasons, i.e. separate bug fixes/use cases.\n\nChange-Id: Ib384c84e2954bd303661386256053b3c1ad38239\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ace4c9c0545e4887b9389a8136414adac101f048"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/ace4c9c0545e4887b9389a8136414adac101f048"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"6a1667424a12b192402276ee81eb26a87bbb08f8","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}