)]}'
{"nova/conductor/manager.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"ba0ccce7a97806e8cfd41de8da98ef63ae3a5d2c","unresolved":false,"context_lines":[{"line_number":227,"context_line":"        self.image_api \u003d image.API()"},{"line_number":228,"context_line":"        self.network_api \u003d network.API()"},{"line_number":229,"context_line":"        self.servicegroup_api \u003d servicegroup.API()"},{"line_number":230,"context_line":"        self.volume_api \u003d cinder.API()"},{"line_number":231,"context_line":"        self.scheduler_client \u003d scheduler_client.SchedulerClient()"},{"line_number":232,"context_line":"        self.notifier \u003d rpc.get_notifier(\u0027compute\u0027, CONF.host)"},{"line_number":233,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_4c95ba3f","line":230,"range":{"start_line":230,"start_character":8,"end_line":230,"end_character":38},"updated":"2017-12-05 13:02:13.000000000","message":"we seems don\u0027t need conductor to have cinder access before. this added cinder access request to conductor\ndo we need some reno about it ?","commit_id":"73b3304f7927f3f4d55807557e4d2e4eb45df06f"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"ba0ccce7a97806e8cfd41de8da98ef63ae3a5d2c","unresolved":false,"context_lines":[{"line_number":971,"context_line":"            # Unreserve volumes now since volume info will be lost"},{"line_number":972,"context_line":"            # once build_request is destroyed"},{"line_number":973,"context_line":"            for bdm in build_request.block_device_mappings:"},{"line_number":974,"context_line":"                self.volume_api.unreserve_volume(context, bdm.volume_id)"},{"line_number":975,"context_line":"            if build_request.instance_uuid not in instances_by_uuid:"},{"line_number":976,"context_line":"                # This is an instance object with no matching db entry."},{"line_number":977,"context_line":"                instance \u003d build_request.get_new_instance(context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_cc06aa87","line":974,"range":{"start_line":974,"start_character":32,"end_line":974,"end_character":48},"updated":"2017-12-05 13:02:13.000000000","message":"not an expert, but seems all unreserve_volume has some \nlogic like below and seems commit ae53c224579cc16d25ca2ee2134a706b4904a7a4 added some new style attach/detach operation..\n\n\n3824                 if new_attachment_id is None:\n3825                     self.volume_api.unreserve_volume(context, new_volume[\u0027id\u0027])\n3826                 else:\n3827                     self.volume_api.attachment_delete(\n3828                         context, new_attachment_id)","commit_id":"73b3304f7927f3f4d55807557e4d2e4eb45df06f"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"245466ded15959633ff0944d7b51f2609fe4851d","unresolved":false,"context_lines":[{"line_number":971,"context_line":"            # Unreserve volumes now since volume info will be lost"},{"line_number":972,"context_line":"            # once build_request is destroyed"},{"line_number":973,"context_line":"            for bdm in build_request.block_device_mappings:"},{"line_number":974,"context_line":"                self.volume_api.unreserve_volume(context, bdm.volume_id)"},{"line_number":975,"context_line":"            if build_request.instance_uuid not in instances_by_uuid:"},{"line_number":976,"context_line":"                # This is an instance object with no matching db entry."},{"line_number":977,"context_line":"                instance \u003d build_request.get_new_instance(context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa0c359_9f70fade","line":974,"range":{"start_line":974,"start_character":32,"end_line":974,"end_character":48},"in_reply_to":"df87a7cf_cc06aa87","updated":"2018-02-15 14:07:14.000000000","message":"Yes you\u0027re absolutely right. The other series that I linked to will handle this in a more generic way.","commit_id":"73b3304f7927f3f4d55807557e4d2e4eb45df06f"}]}