)]}'
{"nova/objects/block_device.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7c8f22d566beeb8ef88eeac60fa6632f71923614","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        @db_api.pick_context_manager_reader"},{"line_number":110,"context_line":"        def get_bdms_no_uuid(context):"},{"line_number":111,"context_line":"            return context.session.query(db_models.BlockDeviceMapping).\\"},{"line_number":112,"context_line":"                    filter_by(uuid\u003dNone).limit(count).all()"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        db_bdms \u003d get_bdms_no_uuid(context)"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9f91af0f_fded7e25","line":112,"updated":"2018-01-02 15:50:37.000000000","message":"I think you\u0027d want to filter out (soft) deleted records here, yeah? So deleted\u003d\u003d0?","commit_id":"f84a89e6c752bc2055425ef2086854fdcad0a59d"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"73beadb2127757106b26283fe5262cb239a16eed","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        @db_api.pick_context_manager_reader"},{"line_number":110,"context_line":"        def get_bdms_no_uuid(context):"},{"line_number":111,"context_line":"            return context.session.query(db_models.BlockDeviceMapping).\\"},{"line_number":112,"context_line":"                    filter_by(uuid\u003dNone).limit(count).all()"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        db_bdms \u003d get_bdms_no_uuid(context)"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9f91af0f_f894acea","line":112,"in_reply_to":"9f91af0f_9d279265","updated":"2018-01-02 17:01:50.000000000","message":"Test here: https://review.openstack.org/530774","commit_id":"f84a89e6c752bc2055425ef2086854fdcad0a59d"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"9108cb5d406943c7ff3f6b2f6abb9066d7282ad9","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        @db_api.pick_context_manager_reader"},{"line_number":110,"context_line":"        def get_bdms_no_uuid(context):"},{"line_number":111,"context_line":"            return context.session.query(db_models.BlockDeviceMapping).\\"},{"line_number":112,"context_line":"                    filter_by(uuid\u003dNone).limit(count).all()"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        db_bdms \u003d get_bdms_no_uuid(context)"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9f91af0f_9d279265","line":112,"in_reply_to":"9f91af0f_fded7e25","updated":"2018-01-02 16:03:08.000000000","message":"As discussed on IRC, this is actually intentional. We eventually want to add a not null constraint to this column, so even deleted records must be populated.\n\nNeither this nor the call to _create_uuid below loads the object, so this is purely a db operation. As you point out, though, this does need a test. I\u0027ll post a separate patch as this is already in the gate.","commit_id":"f84a89e6c752bc2055425ef2086854fdcad0a59d"}],"nova/tests/unit/objects/test_block_device.py":[{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"d5f532622c2b0b888a5eda5c2c0f5f7c3246c4ef","unresolved":false,"context_lines":[{"line_number":495,"context_line":"        self.assertEqual(expected_total, total)"},{"line_number":496,"context_line":"        self.assertEqual(expected_done, done)"},{"line_number":497,"context_line":""},{"line_number":498,"context_line":"    def test_online_migration(self):"},{"line_number":499,"context_line":"        self._assert_online_migration(0, 0)"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"        # Create 2 BDMs, one with a uuid and one without"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_3b389b9e","line":498,"range":{"start_line":498,"start_character":8,"end_line":498,"end_character":29},"updated":"2017-12-06 03:53:16.000000000","message":"\u0027test_populate_uuids\u0027 is better.","commit_id":"01ea3db7307c445959d18d6e087274f1df260bf5"}]}