)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7206d7e2c32af6e35055ea7f7d1c37161346021c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"send a regular notification when locked flag changing"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Watcher is a project for optimization, by migrating instances among hosts."},{"line_number":10,"context_line":"It builds a compute model at the begening, and update it by notifications."},{"line_number":11,"context_line":"When one instance is locked by end users, it is excepted to send a regular"},{"line_number":12,"context_line":"notification from Nova, so Watcher will update its compute model and not"},{"line_number":13,"context_line":"migrate the locked instances."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df87a7cf_9372c77a","line":10,"range":{"start_line":10,"start_character":33,"end_line":10,"end_character":41},"updated":"2017-12-07 11:53:40.000000000","message":"beginning","commit_id":"56892eb48655357110031e37078b3a1ab0c7b2d8"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"87061568591db8bd49d4982214b7f8350919bcc9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"send a regular notification when locked flag changing"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Watcher is a project for optimization, by migrating instances among hosts."},{"line_number":10,"context_line":"It builds a compute model at the begening, and update it by notifications."},{"line_number":11,"context_line":"When one instance is locked by end users, it is excepted to send a regular"},{"line_number":12,"context_line":"notification from Nova, so Watcher will update its compute model and not"},{"line_number":13,"context_line":"migrate the locked instances."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df87a7cf_eeb486d3","line":10,"range":{"start_line":10,"start_character":33,"end_line":10,"end_character":41},"in_reply_to":"df87a7cf_9372c77a","updated":"2017-12-07 12:18:58.000000000","message":"ok","commit_id":"56892eb48655357110031e37078b3a1ab0c7b2d8"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7206d7e2c32af6e35055ea7f7d1c37161346021c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"When one instance is locked by end users, it is excepted to send a regular"},{"line_number":12,"context_line":"notification from Nova, so Watcher will update its compute model and not"},{"line_number":13,"context_line":"migrate the locked instances."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ie3dc44403e85ec5fbb29354f517868e5715f80b1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df87a7cf_73e863e1","line":14,"updated":"2017-12-07 11:53:40.000000000","message":"As this is a new feature I think this needs at least a blueprint","commit_id":"56892eb48655357110031e37078b3a1ab0c7b2d8"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"87061568591db8bd49d4982214b7f8350919bcc9","unresolved":false,"context_lines":[{"line_number":11,"context_line":"When one instance is locked by end users, it is excepted to send a regular"},{"line_number":12,"context_line":"notification from Nova, so Watcher will update its compute model and not"},{"line_number":13,"context_line":"migrate the locked instances."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ie3dc44403e85ec5fbb29354f517868e5715f80b1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df87a7cf_6ea716a9","line":14,"in_reply_to":"df87a7cf_73e863e1","updated":"2017-12-07 12:18:58.000000000","message":"yes, this feature needs a good design.\nI will draft the spec asap.","commit_id":"56892eb48655357110031e37078b3a1ab0c7b2d8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4ce792bbd98057f39cc4de6939b44a5fdc83a0ea","unresolved":false,"context_lines":[{"line_number":12,"context_line":"notification from Nova, so Watcher will update its compute model and not"},{"line_number":13,"context_line":"migrate the locked instances."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ie3dc44403e85ec5fbb29354f517868e5715f80b1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa0c359_044e886e","line":15,"updated":"2018-02-08 14:38:10.000000000","message":"Link this to the blueprint using:\n\nImplements blueprint trigger-notifications-when-lock-unlock-instances","commit_id":"56892eb48655357110031e37078b3a1ab0c7b2d8"}],"nova/notifications/base.py":[{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"23fd1e2298275c7076f2336517050db0d49a0fa9","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    old_task_state \u003d old_instance[\"task_state\"]"},{"line_number":98,"context_line":"    new_task_state \u003d new_instance[\"task_state\"]"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    old_locked_flag \u003d old_instance[\"locked\"]"},{"line_number":101,"context_line":"    new_locked_flag \u003d new_instance[\"locked\"]"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    # we should check if we need to send a state change or a regular"},{"line_number":104,"context_line":"    # notification"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_60996cc2","line":101,"range":{"start_line":100,"start_character":4,"end_line":101,"end_character":44},"updated":"2017-12-07 06:22:35.000000000","message":"do you plan to add notifier for locked_by as well ?","commit_id":"56892eb48655357110031e37078b3a1ab0c7b2d8"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"f78a38e237cf81550eae5d61c93005ad3f5ad9c3","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    old_task_state \u003d old_instance[\"task_state\"]"},{"line_number":98,"context_line":"    new_task_state \u003d new_instance[\"task_state\"]"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    old_locked_flag \u003d old_instance[\"locked\"]"},{"line_number":101,"context_line":"    new_locked_flag \u003d new_instance[\"locked\"]"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    # we should check if we need to send a state change or a regular"},{"line_number":104,"context_line":"    # notification"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_30ee51ed","line":101,"range":{"start_line":100,"start_character":4,"end_line":101,"end_character":44},"in_reply_to":"df87a7cf_60996cc2","updated":"2017-12-07 10:27:18.000000000","message":"\u0027locked\u0027 is enough, while \u0027locked_by\u0027 is needless.","commit_id":"56892eb48655357110031e37078b3a1ab0c7b2d8"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"7206d7e2c32af6e35055ea7f7d1c37161346021c","unresolved":false,"context_lines":[{"line_number":109,"context_line":"          old_task_state !\u003d new_task_state):"},{"line_number":110,"context_line":"        # yes, the task state is changing:"},{"line_number":111,"context_line":"        update_with_state_change \u003d True"},{"line_number":112,"context_line":"    # when locked flag changing, send a regular notification"},{"line_number":113,"context_line":"    elif old_locked_flag !\u003d new_locked_flag:"},{"line_number":114,"context_line":"        update_with_state_change \u003d True"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    if update_with_state_change:"},{"line_number":117,"context_line":"        # send a notification with state changes"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_93cf2755","line":114,"range":{"start_line":112,"start_character":1,"end_line":114,"end_character":39},"updated":"2017-12-07 11:53:40.000000000","message":"Please do not make this logic more complex. If you need notification in case the user called the API \u0027/servers/{server_id}/action\u0027 with a lock key in the body then emit a notification from the nova.compute.api.API.lock() explicitly. I think it would be nice to have a separate instance.lock and instance.unlock notification similarly to other instance action notifications (like instance.reboot or instance.power_off, instance.power_on)\n\nBTW, your modification will only cause notification to be emitted if the CONF.notify_on_state_change is set.","commit_id":"56892eb48655357110031e37078b3a1ab0c7b2d8"},{"author":{"_account_id":24501,"name":"sue","display_name":"suzhengwei","email":"sugar-2008@163.com","username":"suzhengwei"},"change_message_id":"87061568591db8bd49d4982214b7f8350919bcc9","unresolved":false,"context_lines":[{"line_number":109,"context_line":"          old_task_state !\u003d new_task_state):"},{"line_number":110,"context_line":"        # yes, the task state is changing:"},{"line_number":111,"context_line":"        update_with_state_change \u003d True"},{"line_number":112,"context_line":"    # when locked flag changing, send a regular notification"},{"line_number":113,"context_line":"    elif old_locked_flag !\u003d new_locked_flag:"},{"line_number":114,"context_line":"        update_with_state_change \u003d True"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    if update_with_state_change:"},{"line_number":117,"context_line":"        # send a notification with state changes"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_8edcdae4","line":114,"range":{"start_line":112,"start_character":1,"end_line":114,"end_character":39},"in_reply_to":"df87a7cf_93cf2755","updated":"2017-12-07 12:18:58.000000000","message":"thx, your proposal is very important. i will think it over and re-design it.\nps, the notification will be sent eventhough the CONF.notify_on_state_change is not set.","commit_id":"56892eb48655357110031e37078b3a1ab0c7b2d8"}]}