)]}'
{"nova/api/openstack/placement/handlers/resource_provider.py":[{"author":{"_account_id":14070,"name":"Eric Fried","email":"openstack@fried.cc","username":"efried"},"change_message_id":"9ecc04218f31c0e61fb233b0b599b26ef8339993","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            {\u0027duplicate\u0027: duplicate})"},{"line_number":177,"context_line":"    except exception.ObjectActionError as exc:"},{"line_number":178,"context_line":"        raise webob.exc.HTTPBadRequest("},{"line_number":179,"context_line":"            _(\u0027Unable to create resource provider \"%(name)s\", %(rp_uuid)s: \u0027"},{"line_number":180,"context_line":"              \u0027%(error)s\u0027) %"},{"line_number":181,"context_line":"            {\u0027name\u0027: data[\u0027name\u0027], \u0027rp_uuid\u0027: uuid, \u0027error\u0027: exc})"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_9b24f9b0","line":179,"range":{"start_line":179,"start_character":53,"end_line":179,"end_character":57},"updated":"2017-12-08 15:40:10.000000000","message":"When the name is a UUID, as is often the case apparently, it would be clearer here if the message labeled which was which.\n\nOTOH, I think whenever the name is a UUID, it\u0027s the same as the provider\u0027s UUID, so it wouldn\u0027t really matter.\n\nMeh.","commit_id":"885ad10edc67eb1f64590f1aef120865926b133d"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"c0ac22c6d54a5f5e131b3bc486f913bccb7dd42d","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            {\u0027duplicate\u0027: duplicate})"},{"line_number":177,"context_line":"    except exception.ObjectActionError as exc:"},{"line_number":178,"context_line":"        raise webob.exc.HTTPBadRequest("},{"line_number":179,"context_line":"            _(\u0027Unable to create resource provider \"%(name)s\", %(rp_uuid)s: \u0027"},{"line_number":180,"context_line":"              \u0027%(error)s\u0027) %"},{"line_number":181,"context_line":"            {\u0027name\u0027: data[\u0027name\u0027], \u0027rp_uuid\u0027: uuid, \u0027error\u0027: exc})"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_447080dd","line":179,"range":{"start_line":179,"start_character":53,"end_line":179,"end_character":57},"in_reply_to":"df87a7cf_1bba2909","updated":"2017-12-12 21:32:28.000000000","message":"I was checking to see if this changed the error message in such a way that some client-side error parsing code might break, like in recent change I0c4ca6a81f213277fe7219cb905a805712f81e36, but I\u0027m not seeing anything that cares about this specific message so we should be fine.","commit_id":"885ad10edc67eb1f64590f1aef120865926b133d"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"27c059d78f7adcd40b35381d5ce3051add4169de","unresolved":false,"context_lines":[{"line_number":176,"context_line":"            {\u0027duplicate\u0027: duplicate})"},{"line_number":177,"context_line":"    except exception.ObjectActionError as exc:"},{"line_number":178,"context_line":"        raise webob.exc.HTTPBadRequest("},{"line_number":179,"context_line":"            _(\u0027Unable to create resource provider \"%(name)s\", %(rp_uuid)s: \u0027"},{"line_number":180,"context_line":"              \u0027%(error)s\u0027) %"},{"line_number":181,"context_line":"            {\u0027name\u0027: data[\u0027name\u0027], \u0027rp_uuid\u0027: uuid, \u0027error\u0027: exc})"},{"line_number":182,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_1bba2909","line":179,"range":{"start_line":179,"start_character":53,"end_line":179,"end_character":57},"in_reply_to":"df87a7cf_9b24f9b0","updated":"2017-12-08 15:47:25.000000000","message":"I struggled with how to do that without adding a bunch of words and being generally difficult, and ended up with the name quotes as a sort of weak signal. And also: meh.","commit_id":"885ad10edc67eb1f64590f1aef120865926b133d"}]}