)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"30d4ed0c8daf0b295f1581c34e9214c7ab90ae18","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"conf: Do not inherit image signature props with snapshots"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Both img_signature_hash_method and img_signature should not be inherited"},{"line_number":10,"context_line":"from the metadata of the original image when creating a snapshot of an"},{"line_number":11,"context_line":"instance. Otherwise Glance will attempt to verify the signature of the"},{"line_number":12,"context_line":"snapshot image and fail as this has changed from that of the original."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df87a7cf_dc579257","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":49},"updated":"2017-12-12 14:22:43.000000000","message":"All signature related custom properties instead?","commit_id":"b19a241e6d0e8f78255f5f3cab49f28f17354350"}],"nova/conf/compute.py":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"b96170d31da79cd506e8f6722aa0e28bf6e3a198","unresolved":false,"context_lines":[{"line_number":55,"context_line":"\"\"\"),"},{"line_number":56,"context_line":"    cfg.ListOpt(\u0027non_inheritable_image_properties\u0027,"},{"line_number":57,"context_line":"        default\u003d[\u0027cache_in_nova\u0027, \u0027bittorrent\u0027,"},{"line_number":58,"context_line":"                 \u0027img_signature_hash_method\u0027, \u0027img_signature\u0027],"},{"line_number":59,"context_line":"        help\u003d\"\"\""},{"line_number":60,"context_line":"Image properties that should not be inherited from the instance"},{"line_number":61,"context_line":"when taking a snapshot."}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_e27e7bad","line":58,"range":{"start_line":58,"start_character":18,"end_line":58,"end_character":60},"updated":"2017-12-12 03:47:55.000000000","message":"IMO, we should add all four signature related properties here.\n\u0027img_signature_key_type\u0027, \u0027img_signature_certificate_uuid\u0027, \u0027img_signature\u0027, \u0027img_signature_hash_method\u0027\n\nOtherwise \u0027img_signature_key_type\u0027, \u0027img_signature_certificate_uuid\u0027 will be added to snapshot image which will be of no use.","commit_id":"77c2901a51cb82c2822b3cc82b8cd9e2cba7ed29"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"f5d9952c33145476869270a2a9a1907a0b82f604","unresolved":false,"context_lines":[{"line_number":55,"context_line":"\"\"\"),"},{"line_number":56,"context_line":"    cfg.ListOpt(\u0027non_inheritable_image_properties\u0027,"},{"line_number":57,"context_line":"        default\u003d[\u0027cache_in_nova\u0027, \u0027bittorrent\u0027,"},{"line_number":58,"context_line":"                 \u0027img_signature_hash_method\u0027, \u0027img_signature\u0027],"},{"line_number":59,"context_line":"        help\u003d\"\"\""},{"line_number":60,"context_line":"Image properties that should not be inherited from the instance"},{"line_number":61,"context_line":"when taking a snapshot."}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_16016038","line":58,"range":{"start_line":58,"start_character":18,"end_line":58,"end_character":60},"in_reply_to":"df87a7cf_e27e7bad","updated":"2017-12-12 08:57:32.000000000","message":"Yup, good catch, I\u0027ll add these shortly.","commit_id":"77c2901a51cb82c2822b3cc82b8cd9e2cba7ed29"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a61a923881c5120f5bef6ddef4954cbdd91f4e09","unresolved":false,"context_lines":[{"line_number":53,"context_line":"the same host to the destination options. Also set to true"},{"line_number":54,"context_line":"if you allow the ServerGroupAffinityFilter and need to resize."},{"line_number":55,"context_line":"\"\"\"),"},{"line_number":56,"context_line":"    cfg.ListOpt(\u0027non_inheritable_image_properties\u0027,"},{"line_number":57,"context_line":"        default\u003d[\u0027cache_in_nova\u0027, \u0027bittorrent\u0027,"},{"line_number":58,"context_line":"                 \u0027img_signature_hash_method\u0027, \u0027img_signature\u0027,"},{"line_number":59,"context_line":"                 \u0027img_signature_key_type\u0027, \u0027img_signature_certificate_uuid\u0027],"},{"line_number":60,"context_line":"        help\u003d\"\"\""},{"line_number":61,"context_line":"Image properties that should not be inherited from the instance"},{"line_number":62,"context_line":"when taking a snapshot."}],"source_content_type":"text/x-python","patch_set":6,"id":"bf8cb3f7_f21e1b6f","line":59,"range":{"start_line":56,"start_character":0,"end_line":59,"end_character":77},"updated":"2017-12-21 12:20:31.000000000","message":"I hate to be that guy, but don\u0027t we need unit tests for this (runs for cover)?","commit_id":"68e9d1f90e4f168529e7bf9dcd21b30264a19fee"}],"releasenotes/notes/default-non-inheritable-image-properties-dfd13ba3b09278dd.yaml":[{"author":{"_account_id":9303,"name":"Abhishek Kekane","email":"akekane@redhat.com","username":"abhishekkekane"},"change_message_id":"30d4ed0c8daf0b295f1581c34e9214c7ab90ae18","unresolved":false,"context_lines":[{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The default list of non-inherited image properties to pop when creating a"},{"line_number":5,"context_line":"    snapshot has been extended to include image signature properties. The "},{"line_number":6,"context_line":"    properties img_signature_hash_method, img_signature, img_signature_key_type"},{"line_number":7,"context_line":"    and img_signature_certificate_uuid are no longer inherited by the snapshot"},{"line_number":8,"context_line":"    image as they would otherwise result in a Glance attempting to verify the"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df87a7cf_5cc94223","line":5,"range":{"start_line":5,"start_character":73,"end_line":5,"end_character":74},"updated":"2017-12-12 14:22:43.000000000","message":"remove trailing space","commit_id":"b19a241e6d0e8f78255f5f3cab49f28f17354350"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"a61a923881c5120f5bef6ddef4954cbdd91f4e09","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The default list of non-inherited image properties to pop when creating a"},{"line_number":5,"context_line":"    snapshot has been extended to include image signature properties. The"},{"line_number":6,"context_line":"    properties img_signature_hash_method, img_signature, img_signature_key_type"},{"line_number":7,"context_line":"    and img_signature_certificate_uuid are no longer inherited by the snapshot"},{"line_number":8,"context_line":"    image as they would otherwise result in a Glance attempting to verify the"},{"line_number":9,"context_line":"    snapshot image with the signature of the original."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"bf8cb3f7_923a2fe5","line":6,"range":{"start_line":6,"start_character":15,"end_line":6,"end_character":40},"updated":"2017-12-21 12:20:31.000000000","message":"can you format these as ``literals``, pretty please?","commit_id":"68e9d1f90e4f168529e7bf9dcd21b30264a19fee"}]}