)]}'
{"nova/tests/unit/volume/test_cinder.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"4ea7851ef3b434a37bb1cacd51f975f40613ab08","unresolved":false,"context_lines":[{"line_number":386,"context_line":"        result \u003d self.api.attachment_update("},{"line_number":387,"context_line":"            self.ctx, uuids.attachment_id, connector\u003dconnector)"},{"line_number":388,"context_line":"        self.assertEqual(expected_attachment_ref, result)"},{"line_number":389,"context_line":"        # Make sure the original connector wasn\u0027t modified."},{"line_number":390,"context_line":"        self.assertNotIn(\u0027mountpoint\u0027, connector)"},{"line_number":391,"context_line":"        mock_cinderclient.return_value.attachments.update.\\"},{"line_number":392,"context_line":"            assert_called_once_with(uuids.attachment_id, connector)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_6b30f656","line":389,"updated":"2017-12-12 17:49:39.000000000","message":"oops unrelated","commit_id":"447a41af7330bf1227b92cdd08607753c2ca22d6"}],"nova/volume/cinder.py":[{"author":{"_account_id":4690,"name":"melanie witt","display_name":"melwitt","email":"melwittt@gmail.com","username":"melwitt"},"change_message_id":"668cc5893f9c8db79ef8695bf6bfbe1241b9ffd4","unresolved":false,"context_lines":[{"line_number":588,"context_line":"            # Make a copy of the connector so we don\u0027t modify it by"},{"line_number":589,"context_line":"            # reference."},{"line_number":590,"context_line":"            _connector \u003d copy.deepcopy(connector)"},{"line_number":591,"context_line":"            _connector[\u0027mountpoint\u0027] \u003d mountpoint"},{"line_number":592,"context_line":""},{"line_number":593,"context_line":"        try:"},{"line_number":594,"context_line":"            attachment_ref \u003d cinderclient(context, \u00273.44\u0027).attachments.create("}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_ebd726be","line":591,"updated":"2017-12-12 17:53:25.000000000","message":"Maybe put this in a helper function since you\u0027re doing it in both attachment_create and attachment_update.","commit_id":"ba07cfa8790ab25d607945772cdbd9dbef018c37"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"490e7b7a970d59ac5990d6a9757f9b97283322c9","unresolved":false,"context_lines":[{"line_number":588,"context_line":"            # Make a copy of the connector so we don\u0027t modify it by"},{"line_number":589,"context_line":"            # reference."},{"line_number":590,"context_line":"            _connector \u003d copy.deepcopy(connector)"},{"line_number":591,"context_line":"            _connector[\u0027mountpoint\u0027] \u003d mountpoint"},{"line_number":592,"context_line":""},{"line_number":593,"context_line":"        try:"},{"line_number":594,"context_line":"            attachment_ref \u003d cinderclient(context, \u00273.44\u0027).attachments.create("}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_64d10430","line":591,"in_reply_to":"df87a7cf_ebd726be","updated":"2017-12-12 21:14:35.000000000","message":"I thought about that but didn\u0027t want to clutter up the initial patches here with a refactor before fixing the immediate bugs, and figured a refactor could be done in a later cleanup patch.","commit_id":"ba07cfa8790ab25d607945772cdbd9dbef018c37"}]}
