)]}'
{"nova/conf/libvirt.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"399b0ccedcfcd8dda70b5b2d5f30249a3aefdf35","unresolved":false,"context_lines":[{"line_number":491,"context_line":"* ``host-model``: Clones the host CPU feature flags;"},{"line_number":492,"context_line":"* ``host-passthrough``: Use the host CPU model exactly;"},{"line_number":493,"context_line":"* ``custom``: Use a named CPU model;"},{"line_number":494,"context_line":"* ``none``: \"Don\u0027t set a specific CPU model. For instances with"},{"line_number":495,"context_line":"``virt_type`` as KVM/QEMU, the default CPU model from QEMU will be used,"},{"line_number":496,"context_line":"which provides a basic set of CPU features that are compatible with most"},{"line_number":497,"context_line":"hosts\"\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf8cb3f7_702bdc93","line":494,"range":{"start_line":494,"start_character":12,"end_line":494,"end_character":13},"updated":"2017-12-21 18:21:55.000000000","message":"Why the double quotes?","commit_id":"6807b299d5326f40f2c7b530a6680ba88e4192b1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"dadbac4b07af757644e4ea001e3b29ed139752ec","unresolved":false,"context_lines":[{"line_number":494,"context_line":"* ``none``: \"Don\u0027t set a specific CPU model. For instances with"},{"line_number":495,"context_line":"``virt_type`` as KVM/QEMU, the default CPU model from QEMU will be used,"},{"line_number":496,"context_line":"which provides a basic set of CPU features that are compatible with most"},{"line_number":497,"context_line":"hosts\"\u0027"},{"line_number":498,"context_line":""},{"line_number":499,"context_line":"Related options:"},{"line_number":500,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf8cb3f7_cb08fd29","line":497,"range":{"start_line":497,"start_character":5,"end_line":497,"end_character":7},"updated":"2017-12-21 18:23:11.000000000","message":"and this","commit_id":"6807b299d5326f40f2c7b530a6680ba88e4192b1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"b3fa341c163e8fffe015dcc14d302e5dca6c2344","unresolved":false,"context_lines":[{"line_number":499,"context_line":"Related options:"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"* ``cpu_model``: This should be set ONLY when ``cpu_mode`` is set to"},{"line_number":502,"context_line":"``custom``. Otherwise, it would result in an error and the instance"},{"line_number":503,"context_line":"launch will fail."},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"\"\"\"),"},{"line_number":506,"context_line":"    cfg.StrOpt(\u0027cpu_model\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_d803febd","line":503,"range":{"start_line":502,"start_character":12,"end_line":503,"end_character":17},"updated":"2017-12-13 14:21:05.000000000","message":"Not entirely related to this, but what kind of error do we throw? Just the raw libvirt error or our own \"these options aren\u0027t compatible\" error?","commit_id":"6807b299d5326f40f2c7b530a6680ba88e4192b1"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"c57c447896b110fbb8bdb5d7d1d9f6d7c17ef1d2","unresolved":false,"context_lines":[{"line_number":499,"context_line":"Related options:"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"* ``cpu_model``: This should be set ONLY when ``cpu_mode`` is set to"},{"line_number":502,"context_line":"``custom``. Otherwise, it would result in an error and the instance"},{"line_number":503,"context_line":"launch will fail."},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"\"\"\"),"},{"line_number":506,"context_line":"    cfg.StrOpt(\u0027cpu_model\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_78d672c6","line":503,"range":{"start_line":502,"start_character":12,"end_line":503,"end_character":17},"in_reply_to":"df87a7cf_78cc3261","updated":"2017-12-13 14:38:03.000000000","message":"Spot on. Thanks for the info :)","commit_id":"6807b299d5326f40f2c7b530a6680ba88e4192b1"},{"author":{"_account_id":6962,"name":"Kashyap Chamarthy","email":"kchamart@redhat.com","username":"kashyapc"},"change_message_id":"fd762b3c9c7f700ea8c591f25a8bd93bb97dc344","unresolved":false,"context_lines":[{"line_number":499,"context_line":"Related options:"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"* ``cpu_model``: This should be set ONLY when ``cpu_mode`` is set to"},{"line_number":502,"context_line":"``custom``. Otherwise, it would result in an error and the instance"},{"line_number":503,"context_line":"launch will fail."},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"\"\"\"),"},{"line_number":506,"context_line":"    cfg.StrOpt(\u0027cpu_model\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_78cc3261","line":503,"range":{"start_line":502,"start_character":12,"end_line":503,"end_character":17},"in_reply_to":"df87a7cf_d803febd","updated":"2017-12-13 14:33:25.000000000","message":"A variant of the latter, from libvirt/driver.py:\n\n    [...]\n    if mode \u003d\u003d \"custom\" and model is None:\n        msg \u003d _(\"Config requested a custom CPU model, but no \"\n                \"model name was provided\")\n        raise exception.Invalid(msg)\n    elif mode !\u003d \"custom\" and model is not None:\n        msg \u003d _(\"A CPU model name should not be set when a \"\n                \"host CPU model is requested\")\n        raise exception.Invalid(msg)\n    [...]","commit_id":"6807b299d5326f40f2c7b530a6680ba88e4192b1"}]}