)]}'
{"nova/virt/baremetal/driver.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"f9daf45285bc6c42918864ff93f54756bc11a16a","unresolved":false,"context_lines":[{"line_number":317,"context_line":"                                \"baremetal database: %s\") % e)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def cleanup(self, instance, network_info, block_device_info\u003dNone,"},{"line_number":320,"context_line":"                destroy_disks\u003dTrue, context\u003dNone):"},{"line_number":321,"context_line":"        \"\"\"Cleanup after instance being destroyed.\"\"\""},{"line_number":322,"context_line":"        pass"},{"line_number":323,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2F1Xs%3D","line":320,"updated":"2013-10-28 09:18:12.000000000","message":"In the parent class \u0027context\u0027 is the second parameter.","commit_id":"c2d6cb6a497d2a709e0d0742dd4a069fb11dec85"}],"nova/virt/docker/driver.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"f9daf45285bc6c42918864ff93f54756bc11a16a","unresolved":false,"context_lines":[{"line_number":324,"context_line":"        self.docker.destroy_container(container_id)"},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"    def cleanup(self, instance, network_info, block_device_info\u003dNone,"},{"line_number":327,"context_line":"                destroy_disks\u003dTrue, context\u003dNone):"},{"line_number":328,"context_line":"        \"\"\"Cleanup after instance being destroyed by Hypervisor.\"\"\""},{"line_number":329,"context_line":"        pass"},{"line_number":330,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2F1Xw%3D","line":327,"updated":"2013-10-28 09:18:12.000000000","message":"In the parent class \u0027context\u0027 is the second parameter.","commit_id":"c2d6cb6a497d2a709e0d0742dd4a069fb11dec85"}],"nova/virt/driver.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"f9daf45285bc6c42918864ff93f54756bc11a16a","unresolved":false,"context_lines":[{"line_number":272,"context_line":"           :py:meth:`~nova.network.manager.NetworkManager.get_instance_nw_info`"},{"line_number":273,"context_line":"        :param block_device_info: Information about block devices that should"},{"line_number":274,"context_line":"                                  be detached from the instance."},{"line_number":275,"context_line":"        :param destroy_disks: Indicates if disks should be destroyed"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        \"\"\""},{"line_number":278,"context_line":"        raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2F1Xk%3D","line":275,"updated":"2013-10-28 09:18:12.000000000","message":"\"context\" isn\u0027t documented.","commit_id":"c2d6cb6a497d2a709e0d0742dd4a069fb11dec85"}],"nova/virt/fake.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"f9daf45285bc6c42918864ff93f54756bc11a16a","unresolved":false,"context_lines":[{"line_number":217,"context_line":"                         \u0027inst\u0027: self.instances}, instance\u003dinstance)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def cleanup(self, instance, network_info, block_device_info\u003dNone,"},{"line_number":220,"context_line":"                destroy_disks\u003dTrue, context\u003dNone):"},{"line_number":221,"context_line":"        pass"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    def attach_volume(self, context, connection_info, instance, mountpoint,"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2F1Yc%3D","line":220,"updated":"2013-10-28 09:18:12.000000000","message":"In the parent class \u0027context\u0027 is the second parameter.","commit_id":"c2d6cb6a497d2a709e0d0742dd4a069fb11dec85"}],"nova/virt/hyperv/driver.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"f9daf45285bc6c42918864ff93f54756bc11a16a","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                            destroy_disks)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def cleanup(self, instance, network_info, block_device_info\u003dNone,"},{"line_number":67,"context_line":"                destroy_disks\u003dTrue, context\u003dNone):"},{"line_number":68,"context_line":"        \"\"\"Cleanup after instance being destroyed by Hypervisor.\"\"\""},{"line_number":69,"context_line":"        pass"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2F1YY%3D","line":67,"updated":"2013-10-28 09:18:12.000000000","message":"In the parent class \u0027context\u0027 is the second parameter.","commit_id":"c2d6cb6a497d2a709e0d0742dd4a069fb11dec85"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"95ebfea9be4681759addd2d6d1ded039595460e6","unresolved":false,"context_lines":[{"line_number":829,"context_line":"            self._destroy(instance)"},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"    def destroy(self, instance, network_info, block_device_info\u003dNone,"},{"line_number":832,"context_line":"                destroy_disks\u003dTrue, context\u003dNone, instance_exist\u003dTrue):"},{"line_number":833,"context_line":"        if instance_exist:"},{"line_number":834,"context_line":"            self._destroy(instance)"},{"line_number":835,"context_line":"        self._cleanup(instance, network_info, block_device_info,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATX%2F%2F9lQ%3D","line":832,"updated":"2013-10-23 16:04:49.000000000","message":"This method is defined by the nova.virt.driver API and is common to all hypervisors. You can\u0027t just add parameters to libvirt only.\n\nIMHO this is the wrong way to address the bug in any case. The bug is about silencing the log error message - I think that the LOG.error call should just be changed to LOG.debug - if you are trying to destroy a guest, it is not an error if it dies on its own accord first. So it should merely be debug.","commit_id":"20b89ca21574bedd2e6f7d6a03f5d5e4ad9e3719"},{"author":{"_account_id":1313,"name":"yaguang","display_name":"Yaguang Tang","email":"heut2008@gmail.com","username":"heut2008"},"change_message_id":"1a3b4bcfe73f159a61416e29d1efd6f7db89304c","unresolved":false,"context_lines":[{"line_number":829,"context_line":"            self._destroy(instance)"},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"    def destroy(self, instance, network_info, block_device_info\u003dNone,"},{"line_number":832,"context_line":"                destroy_disks\u003dTrue, context\u003dNone, instance_exist\u003dTrue):"},{"line_number":833,"context_line":"        if instance_exist:"},{"line_number":834,"context_line":"            self._destroy(instance)"},{"line_number":835,"context_line":"        self._cleanup(instance, network_info, block_device_info,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2F8j0%3D","line":832,"in_reply_to":"AAAATX%2F%2F9lQ%3D","updated":"2013-10-24 19:13:37.000000000","message":"sorry,  the bug description has been updated, what I want to fix is that it\u0027s may be not appropriate to call destroy for just cleanup instance resource after live migration.","commit_id":"20b89ca21574bedd2e6f7d6a03f5d5e4ad9e3719"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"1bc901e0518a7bae6863a7f65e7b2e9459da9bd0","unresolved":false,"context_lines":[{"line_number":867,"context_line":"                              {\u0027errcode\u0027: errcode, \u0027e\u0027: e}, instance\u003dinstance)"},{"line_number":868,"context_line":""},{"line_number":869,"context_line":"    def cleanup(self, instance, network_info, block_device_info,"},{"line_number":870,"context_line":"                 destroy_disks, context\u003dNone):"},{"line_number":871,"context_line":"        self._undefine_domain(instance)"},{"line_number":872,"context_line":"        self.unplug_vifs(instance, network_info)"},{"line_number":873,"context_line":"        retry \u003d True"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2F63s%3D","line":870,"updated":"2013-10-25 08:11:08.000000000","message":"The parent class only defines this method with 4 arguments, of which 2 are compulsory, here you have 5, of which 4 are compulsory. The compute driver calls this with only  arguments. Please make the signatures consistent.","commit_id":"12ca1f0faa652d5afd3a9b6ee7c720434dab25de"},{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"f9daf45285bc6c42918864ff93f54756bc11a16a","unresolved":false,"context_lines":[{"line_number":873,"context_line":"                              {\u0027errcode\u0027: errcode, \u0027e\u0027: e}, instance\u003dinstance)"},{"line_number":874,"context_line":""},{"line_number":875,"context_line":"    def cleanup(self, context, instance, network_info, block_device_info,"},{"line_number":876,"context_line":"                destroy_disks):"},{"line_number":877,"context_line":"        self._undefine_domain(instance)"},{"line_number":878,"context_line":"        self.unplug_vifs(instance, network_info)"},{"line_number":879,"context_line":"        retry \u003d True"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2F1Yk%3D","line":876,"updated":"2013-10-28 09:18:12.000000000","message":"Missing default values - all the other drivers have defaults set, except this one.","commit_id":"c2d6cb6a497d2a709e0d0742dd4a069fb11dec85"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"46be8b233c0b958ecb8913e94f17c4cfd5e69f2d","unresolved":false,"context_lines":[{"line_number":937,"context_line":"                              {\u0027errcode\u0027: errcode, \u0027e\u0027: e}, instance\u003dinstance)"},{"line_number":938,"context_line":""},{"line_number":939,"context_line":"    def cleanup(self, context, instance, network_info, block_device_info,"},{"line_number":940,"context_line":"                destroy_disks):"},{"line_number":941,"context_line":"        self._undefine_domain(instance)"},{"line_number":942,"context_line":"        self.unplug_vifs(instance, network_info)"},{"line_number":943,"context_line":"        retry \u003d True"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F%2Fl24%3D","line":940,"updated":"2014-01-10 17:46:36.000000000","message":"block_device_info and destroy_disks should have defaults to match all the other drivers.","commit_id":"8447ffcc5a771c38f0f89647f42aee0c7002d633"}],"nova/virt/powervm/driver.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"f9daf45285bc6c42918864ff93f54756bc11a16a","unresolved":false,"context_lines":[{"line_number":114,"context_line":"        self._powervm.destroy(instance[\u0027name\u0027], destroy_disks)"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def cleanup(self, instance, network_info, block_device_info\u003dNone,"},{"line_number":117,"context_line":"                destroy_disks\u003dTrue, context\u003dNone):"},{"line_number":118,"context_line":"        \"\"\"Cleanup after instance being destroyed by Hypervisor.\"\"\""},{"line_number":119,"context_line":"        pass"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2F1YM%3D","line":117,"updated":"2013-10-28 09:18:12.000000000","message":"In the parent class \u0027context\u0027 is the second parameter.","commit_id":"c2d6cb6a497d2a709e0d0742dd4a069fb11dec85"}],"nova/virt/vmwareapi/driver.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"f9daf45285bc6c42918864ff93f54756bc11a16a","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        self._vmops.destroy(instance, network_info, destroy_disks)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def cleanup(self, instance, network_info, block_device_info\u003dNone,"},{"line_number":195,"context_line":"                destroy_disks\u003dTrue, context\u003dNone):"},{"line_number":196,"context_line":"        \"\"\"Cleanup after instance being destroyed by Hypervisor.\"\"\""},{"line_number":197,"context_line":"        pass"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2F1YI%3D","line":195,"updated":"2013-10-28 09:18:12.000000000","message":"In the parent class \u0027context\u0027 is the second parameter.","commit_id":"c2d6cb6a497d2a709e0d0742dd4a069fb11dec85"}],"nova/virt/xenapi/driver.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"f9daf45285bc6c42918864ff93f54756bc11a16a","unresolved":false,"context_lines":[{"line_number":268,"context_line":"                            destroy_disks)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    def cleanup(self, instance, network_info, block_device_info\u003dNone,"},{"line_number":271,"context_line":"                destroy_disks\u003dTrue, context\u003dNone):"},{"line_number":272,"context_line":"        \"\"\"Cleanup after instance being destroyed by Hypervisor.\"\"\""},{"line_number":273,"context_line":"        pass"},{"line_number":274,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2F1X0%3D","line":271,"updated":"2013-10-28 09:18:12.000000000","message":"In the parent class \u0027context\u0027 is the second parameter.","commit_id":"c2d6cb6a497d2a709e0d0742dd4a069fb11dec85"}]}