)]}'
{"nova/objects/request_spec.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"41b457c416b99e1340ae5aef82949a7b0247c8ec","unresolved":false,"context_lines":[{"line_number":498,"context_line":"        if updates:"},{"line_number":499,"context_line":"            # NOTE(danms): Don\u0027t persist the could-be-large and could-be-stale"},{"line_number":500,"context_line":"            # properties of InstanceGroup"},{"line_number":501,"context_line":"            spec \u003d self.obj_clone()"},{"line_number":502,"context_line":"            if \u0027instance_group\u0027 in spec:"},{"line_number":503,"context_line":"                spec.instance_group.members \u003d None"},{"line_number":504,"context_line":"                spec.instance_group.hosts \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_0c835b58","line":501,"range":{"start_line":501,"start_character":24,"end_line":501,"end_character":33},"updated":"2017-12-13 22:31:11.000000000","message":"You\u0027re cloning it so you don\u0027t modify self to trigger obj_what_changed() to return instance_group?\n\nCould we instead convert the object to the primitive and then null out the members/hosts keys within the primitive that gets stored in the DB? Maybe that\u0027s more complicated for no gain.","commit_id":"e1c7219b291bf686c53e363e8d67846c08ce9bb2"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"01ea6aec64531a00de38802a3bf7d5ce4d7b02c2","unresolved":false,"context_lines":[{"line_number":498,"context_line":"        if updates:"},{"line_number":499,"context_line":"            # NOTE(danms): Don\u0027t persist the could-be-large and could-be-stale"},{"line_number":500,"context_line":"            # properties of InstanceGroup"},{"line_number":501,"context_line":"            spec \u003d self.obj_clone()"},{"line_number":502,"context_line":"            if \u0027instance_group\u0027 in spec:"},{"line_number":503,"context_line":"                spec.instance_group.members \u003d None"},{"line_number":504,"context_line":"                spec.instance_group.hosts \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"df87a7cf_cc3fb385","line":501,"range":{"start_line":501,"start_character":24,"end_line":501,"end_character":33},"in_reply_to":"df87a7cf_0c835b58","updated":"2017-12-13 22:34:25.000000000","message":"I\u0027m cloning so I don\u0027t modify self in place during a save. I don\u0027t want the caller of save to end up with a neutered instance_group property.\n\nWe could, but it doesn\u0027t seem as clear to me. Whichever you want though.","commit_id":"e1c7219b291bf686c53e363e8d67846c08ce9bb2"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"58ccbc6ccbf0b266c0e8a08a867be3d481040ded","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            policies \u003d list(filter_properties.get(\u0027group_policies\u0027))"},{"line_number":204,"context_line":"            hosts \u003d list(filter_properties.get(\u0027group_hosts\u0027))"},{"line_number":205,"context_line":"            members \u003d list(filter_properties.get(\u0027group_members\u0027))"},{"line_number":206,"context_line":"            self.instance_group \u003d objects.InstanceGroup(policies\u003dpolicies,"},{"line_number":207,"context_line":"                                                        hosts\u003dhosts,"},{"line_number":208,"context_line":"                                                        members\u003dmembers)"},{"line_number":209,"context_line":"            # hosts has to be not part of the updates for saving the object"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_695e1745","line":206,"updated":"2019-05-28 15:57:46.000000000","message":"No uuid set here, yayyyyy request spec!!!","commit_id":"94fd36f0582c5dbcf2b9886da7c7bf986d3ad5d1"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"58ccbc6ccbf0b266c0e8a08a867be3d481040ded","unresolved":false,"context_lines":[{"line_number":452,"context_line":"            # Instead, load it by uuid here so it\u0027s up-to-date."},{"line_number":453,"context_line":"            try:"},{"line_number":454,"context_line":"                spec.instance_group \u003d objects.InstanceGroup.get_by_uuid("},{"line_number":455,"context_line":"                    context, spec.instance_group.uuid)"},{"line_number":456,"context_line":"            except exception.InstanceGroupNotFound:"},{"line_number":457,"context_line":"                # NOTE(danms): Instance group may have been deleted"},{"line_number":458,"context_line":"                spec.instance_group \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_c94dc39a","line":455,"range":{"start_line":455,"start_character":29,"end_line":455,"end_character":53},"updated":"2019-05-28 15:57:46.000000000","message":"Weeeee this might not be set if you\u0027ve rescheduled a cold migration or resize, see bug 1830747.","commit_id":"94fd36f0582c5dbcf2b9886da7c7bf986d3ad5d1"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"5b5f6f231c1e78bf027ab701b27a155958bf0451","unresolved":false,"context_lines":[{"line_number":501,"context_line":"            spec \u003d self.obj_clone()"},{"line_number":502,"context_line":"            if \u0027instance_group\u0027 in spec and spec.instance_group:"},{"line_number":503,"context_line":"                spec.instance_group.members \u003d None"},{"line_number":504,"context_line":"                spec.instance_group.hosts \u003d None"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"            db_updates \u003d {\u0027spec\u0027: jsonutils.dumps(spec.obj_to_primitive())}"},{"line_number":507,"context_line":"            if \u0027instance_uuid\u0027 in updates:"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_aaf79cd4","line":504,"range":{"start_line":504,"start_character":16,"end_line":504,"end_character":48},"updated":"2017-12-14 16:17:30.000000000","message":"hosts is lazy-loadable so in theory you shouldn\u0027t need to unset it.","commit_id":"94fd36f0582c5dbcf2b9886da7c7bf986d3ad5d1"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b9dfa6f43961a9e68443aed84f3c41f5bf6a9c6c","unresolved":false,"context_lines":[{"line_number":501,"context_line":"            spec \u003d self.obj_clone()"},{"line_number":502,"context_line":"            if \u0027instance_group\u0027 in spec and spec.instance_group:"},{"line_number":503,"context_line":"                spec.instance_group.members \u003d None"},{"line_number":504,"context_line":"                spec.instance_group.hosts \u003d None"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"            db_updates \u003d {\u0027spec\u0027: jsonutils.dumps(spec.obj_to_primitive())}"},{"line_number":507,"context_line":"            if \u0027instance_uuid\u0027 in updates:"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_08d570b9","line":504,"range":{"start_line":504,"start_character":16,"end_line":504,"end_character":48},"in_reply_to":"df87a7cf_aaf79cd4","updated":"2017-12-14 17:39:02.000000000","message":"If we store it and load it, then it won\u0027t lazy-load on the other end. That and storing something that we don\u0027t need is wasteful.","commit_id":"94fd36f0582c5dbcf2b9886da7c7bf986d3ad5d1"}]}