)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"59814e0862535f1347121a3998cca60986344809","unresolved":false,"context_lines":[{"line_number":10,"context_line":"for LVM based VM, the image was not re-created after the for this"},{"line_number":11,"context_line":"case, and this will cause resize revert failed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The fix was re-create the image when resize revert a VM."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I39c95400bf813fe4ce4490731832a83701848dc7"},{"line_number":16,"context_line":"Closes-Bug: #1242233"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATX%2F%2F7%2Bw%3D","line":13,"updated":"2013-10-23 23:40:28.000000000","message":"I think I\u0027d prefer to see us address the root cause - ie don\u0027t delete the original image when we still have a chance of needing it, and ensure that LVM operates in the same way as raw file handling from this POV.","commit_id":"e87c0fa8bbab57d3601231c1dbd1d2b97378a669"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"4883d770410a214565c10aad0c405ddcfe3d73a8","unresolved":false,"context_lines":[{"line_number":10,"context_line":"for LVM based VM, the image was not re-created after the for this"},{"line_number":11,"context_line":"case, and this will cause resize revert failed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The fix was re-create the image when resize revert a VM."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I39c95400bf813fe4ce4490731832a83701848dc7"},{"line_number":16,"context_line":"Closes-Bug: #1242233"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAATn%2F%2F2oI%3D","line":13,"in_reply_to":"AAAATX%2F%2F7%2Bw%3D","updated":"2013-10-27 10:53:04.000000000","message":"Done","commit_id":"e87c0fa8bbab57d3601231c1dbd1d2b97378a669"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"63bf289bb10884429590b3cb4edad00800069c24","unresolved":false,"context_lines":[{"line_number":11,"context_line":"case, and this will cause resize revert failed."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The fix was re-create the image when resize revert a LVM based VM"},{"line_number":14,"context_line":"to make sure the VM has a LVM image."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I39c95400bf813fe4ce4490731832a83701848dc7"},{"line_number":17,"context_line":"Closes-Bug: #1242233"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAATn%2F%2F1XY%3D","line":14,"updated":"2013-10-28 09:20:53.000000000","message":"@Daniel, the commit log was updated to reflect that we only re-create image for LVM image, does this OK? I did not mention other image types since this fix is targeted LVM.","commit_id":"7b340b1a3d58d4166352992db0e47a1cd3b8c323"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"change_message_id":"59814e0862535f1347121a3998cca60986344809","unresolved":false,"context_lines":[{"line_number":4602,"context_line":"        disk_info \u003d blockinfo.get_disk_info(CONF.libvirt_type,"},{"line_number":4603,"context_line":"                                            instance,"},{"line_number":4604,"context_line":"                                            block_device_info)"},{"line_number":4605,"context_line":"        # assume _create_image do nothing if a target file exists."},{"line_number":4606,"context_line":"        self._create_image(nova_context.get_admin_context(), instance,"},{"line_number":4607,"context_line":"                           disk_mapping\u003ddisk_info[\u0027mapping\u0027],"},{"line_number":4608,"context_line":"                           network_info\u003dnetwork_info,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATX%2F%2F7%2Fc%3D","line":4605,"updated":"2013-10-23 23:40:28.000000000","message":"I\u0027m not at all convinced this assumption is safe.\n\nIf you want to make such an assumption, then IMHO we need a test case for _create_image that validates it is 100% side-effect free if the target already exists.","commit_id":"e87c0fa8bbab57d3601231c1dbd1d2b97378a669"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"4883d770410a214565c10aad0c405ddcfe3d73a8","unresolved":false,"context_lines":[{"line_number":4602,"context_line":"        disk_info \u003d blockinfo.get_disk_info(CONF.libvirt_type,"},{"line_number":4603,"context_line":"                                            instance,"},{"line_number":4604,"context_line":"                                            block_device_info)"},{"line_number":4605,"context_line":"        # assume _create_image do nothing if a target file exists."},{"line_number":4606,"context_line":"        self._create_image(nova_context.get_admin_context(), instance,"},{"line_number":4607,"context_line":"                           disk_mapping\u003ddisk_info[\u0027mapping\u0027],"},{"line_number":4608,"context_line":"                           network_info\u003dnetwork_info,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2F2iM%3D","line":4605,"in_reply_to":"AAAATX%2F%2F7%2Fc%3D","updated":"2013-10-27 10:53:04.000000000","message":"Thanks Daniel, actually I was using same logic with finish_migration. Please take a look at Line 4560 in this file, so we can assume that finish_migration should already guarantee that _create_image() works well for such case. Make sense? Thanks.","commit_id":"e87c0fa8bbab57d3601231c1dbd1d2b97378a669"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"63bf289bb10884429590b3cb4edad00800069c24","unresolved":false,"context_lines":[{"line_number":4631,"context_line":"        disk_info \u003d blockinfo.get_disk_info(CONF.libvirt_type,"},{"line_number":4632,"context_line":"                                            instance,"},{"line_number":4633,"context_line":"                                            block_device_info)"},{"line_number":4634,"context_line":"        # assume _create_image do nothing if a target file exists."},{"line_number":4635,"context_line":"        self._create_image(nova_context.get_admin_context(), instance,"},{"line_number":4636,"context_line":"                           disk_mapping\u003ddisk_info[\u0027mapping\u0027],"},{"line_number":4637,"context_line":"                           network_info\u003dnetwork_info,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2F1W4%3D","line":4634,"updated":"2013-10-28 09:20:53.000000000","message":"@Daniel, actually I was using same logic with finish_migration. Please take a look at Line 4560 in this file, so we can assume that finish_migration should already guarantee that _create_image() works well for such case. Make sense? Thanks.","commit_id":"7b340b1a3d58d4166352992db0e47a1cd3b8c323"}]}